Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

fix Filter.Select filtering input logic

Steven Tey21c4f339c5a5
diff --git a/packages/ui/src/filter/filter-select.tsx b/packages/ui/src/filter/filter-select.tsx
index 6994614c21..9837cf26e0 100644
--- a/packages/ui/src/filter/filter-select.tsx
+++ b/packages/ui/src/filter/filter-select.tsx
@@ -439,11 +439,14 @@ const CommandEmpty = ({
onSelect: () => void;
askAI?: boolean;
}>) => {
- // If the selected filter has no options, show the search input as an option
+ // If the selected filter has no options (and shouldFilter is true,
+ // meaning it's leveraging Command.List's native filtering and not external/async filtering),
+ // show the search input as an option
if (
selectedFilter &&
selectedFilter.options &&
- selectedFilter.options.length === 0
+ selectedFilter.options.length === 0 &&
+ selectedFilter.shouldFilter !== false
) {
if (!search)
return (