Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Layout small improvements (#3898)

Pedro Ladeira2909c6436c74
diff --git a/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/network-partner-application-sheet.tsx b/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/network-partner-application-sheet.tsx
index 121412e9e2..6f4ee86709 100644
--- a/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/network-partner-application-sheet.tsx
+++ b/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/network-partner-application-sheet.tsx
@@ -229,7 +229,7 @@ export function NetworkPartnerApplicationSheet({
<Sheet
open={isOpen}
onOpenChange={setIsOpen}
- onClose={() => queryParams({ del: "partnerId", scroll: false })}
+ onClose={() => queryParams({ del: "partnerId" })}
contentProps={{
className: "md:w-[max(min(calc(100vw-334px),1170px),540px)]",
}}
diff --git a/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/page.tsx b/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/page.tsx
index d5c0909f5e..6a586ecd73 100644
--- a/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/page.tsx
+++ b/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/page.tsx
@@ -261,11 +261,10 @@ export default function NetworkApplicationsPage() {
set: {
partnerId: fallbackPartnerId,
},
- scroll: false,
});
} else {
setDetailsSheetState({ open: false, partnerId: null });
- queryParams({ del: "partnerId", scroll: false });
+ queryParams({ del: "partnerId" });
}
} catch (error) {
toast.error(
@@ -391,7 +390,6 @@ export default function NetworkApplicationsPage() {
set: {
partnerId: row.original.id,
},
- scroll: false,
}),
loading: isLoading,
sortableColumns: ["createdAt"],
@@ -404,7 +402,6 @@ export default function NetworkApplicationsPage() {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
pagination,
@@ -428,7 +425,6 @@ export default function NetworkApplicationsPage() {
set: {
partnerId: previousPartnerId,
},
- scroll: false,
})
: undefined
}
@@ -439,7 +435,6 @@ export default function NetworkApplicationsPage() {
set: {
partnerId: nextPartnerId,
},
- scroll: false,
})
: undefined
}
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-table.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-table.tsx
index 6ae17b32e8..183a3f780b 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-table.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/payouts/payout-table.tsx
@@ -203,14 +203,12 @@ export function PayoutTable() {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
onRowClick: (row) => {
queryParams({
set: {
payoutId: row.original.id,
},
- scroll: false,
});
},
thClassName: "border-l-0",
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/leads/page.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/leads/page.tsx
index 0b42f170cb..14ab7b53b8 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/leads/page.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/leads/page.tsx
@@ -233,7 +233,6 @@ export default function PartnerProgramSubmittedLeadsPage() {
onRowClick: (row) => {
queryParams({
set: { leadId: row.original.id },
- scroll: false,
});
setDetailsSheetState({
leadId: row.original.id,
@@ -291,7 +290,6 @@ export default function PartnerProgramSubmittedLeadsPage() {
? () => {
queryParams({
set: { leadId: previousLeadId },
- scroll: false,
});
setDetailsSheetState({
leadId: previousLeadId,
@@ -305,7 +303,6 @@ export default function PartnerProgramSubmittedLeadsPage() {
? () => {
queryParams({
set: { leadId: nextLeadId },
- scroll: false,
});
setDetailsSheetState({
leadId: nextLeadId,
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page.tsx
index 20bac3ac8e..6b4ba8dcfd 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page.tsx
@@ -248,7 +248,6 @@ export default function PartnerProgramCustomersPage() {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
thClassName: "border-l-0",
tdClassName: "border-l-0",
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/use-partner-customer-filters.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/use-partner-customer-filters.tsx
index e93794fdcd..8a8be3fd8e 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/use-partner-customer-filters.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/use-partner-customer-filters.tsx
@@ -81,7 +81,6 @@ export function usePartnerCustomerFilters() {
[key]: value,
},
del: "page",
- scroll: false,
}),
[queryParams],
);
@@ -90,7 +89,6 @@ export function usePartnerCustomerFilters() {
(key: string) =>
queryParams({
del: [key, "page"],
- scroll: false,
}),
[queryParams],
);
@@ -99,7 +97,6 @@ export function usePartnerCustomerFilters() {
() =>
queryParams({
del: ["country", "linkId", "search", "page"],
- scroll: false,
}),
[queryParams],
);
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/earnings/earnings-composite-chart.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/earnings/earnings-composite-chart.tsx
index d43f65d648..3c605a3c27 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/earnings/earnings-composite-chart.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/earnings/earnings-composite-chart.tsx
@@ -170,7 +170,6 @@ export function EarningsCompositeChart() {
selectAction={(option) => {
queryParams({
set: { groupBy: option },
- scroll: false,
});
}}
/>
@@ -362,19 +361,16 @@ function EarningsTableControls() {
[key]: value,
},
del: "page",
- scroll: false,
});
const onRemove = (key: string, _value: any) =>
queryParams({
del: [key, "page"],
- scroll: false,
});
const onRemoveAll = () =>
queryParams({
del: ["linkId", "customerId", "status", "page"],
- scroll: false,
});
return (
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/earnings/earnings-table.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/earnings/earnings-table.tsx
index 17ac4f7d9a..2a8a74e89b 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/earnings/earnings-table.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/earnings/earnings-table.tsx
@@ -297,7 +297,6 @@ export function EarningsTablePartner({ limit }: { limit?: number }) {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
enableColumnResizing: true,
}),
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/analytics-partners-table.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/analytics-partners-table.tsx
index 5b5c992e41..fad4d4349a 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/analytics-partners-table.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/analytics-partners-table.tsx
@@ -60,7 +60,6 @@ export function AnalyticsPartnersTable() {
queryParams({
set: { partnerId: stagedPartnerIds.join(",") },
del: "page",
- scroll: false,
});
setStagedPartnerIds(null);
}, [queryParams, stagedPartnerIds]);
@@ -68,7 +67,7 @@ export function AnalyticsPartnersTable() {
const clearFilter = useCallback(() => {
setStagedPartnerIds(null);
if (searchParams.has("partnerId")) {
- queryParams({ del: ["partnerId", "page"], scroll: false });
+ queryParams({ del: ["partnerId", "page"] });
}
}, [queryParams, searchParams]);
@@ -118,7 +117,7 @@ export function AnalyticsPartnersTable() {
isApplied={activePartnerIdsFromUrl.includes(partnerId)}
onToggle={() => toggleStagePartner(partnerId)}
onApplyImmediate={() => {
- queryParams({ set: { partnerId }, del: "page", scroll: false });
+ queryParams({ set: { partnerId }, del: "page" });
setStagedPartnerIds(null);
}}
/>
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-analytics-cards.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-analytics-cards.tsx
index 1b210eeedb..38759a9742 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-analytics-cards.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-analytics-cards.tsx
@@ -94,12 +94,11 @@ function ApplicationsAnalyticsCardShell({
const onApplyFilterValues = useCallback(
(values: string[]) => {
if (values.length === 0) {
- queryParams({ del: [filterParamKey, "page"], scroll: false });
+ queryParams({ del: [filterParamKey, "page"] });
} else {
queryParams({
set: { [filterParamKey]: values.join(",") },
del: "page",
- scroll: false,
});
}
setSelectedItems([]);
@@ -110,7 +109,7 @@ function ApplicationsAnalyticsCardShell({
const onClearFilter = useCallback(() => {
setSelectedItems([]);
if (isFilterActive) {
- queryParams({ del: [filterParamKey, "page"], scroll: false });
+ queryParams({ del: [filterParamKey, "page"] });
}
}, [filterParamKey, isFilterActive, queryParams]);
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-funnel-chart.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-funnel-chart.tsx
index 72c252d924..0c593addef 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-funnel-chart.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-funnel-chart.tsx
@@ -138,7 +138,6 @@ export function ApplicationsFunnelChart({
queryParams({
set: { applicationEvent: id },
del: "page",
- scroll: false,
getNewPath: true,
}) as string
}
@@ -277,7 +276,6 @@ export function ApplicationsFunnelChart({
selectAction={(next) =>
queryParams({
set: { view: next },
- scroll: false,
})
}
/>
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-partners-table.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-partners-table.tsx
index 63e3fd8f6d..47679dcf6c 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-partners-table.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/applications-partners-table.tsx
@@ -54,7 +54,6 @@ export function ApplicationsPartnersTable() {
queryParams({
set: { partnerId: stagedPartnerIds.join(",") },
del: "page",
- scroll: false,
});
setStagedPartnerIds(null);
@@ -64,7 +63,7 @@ export function ApplicationsPartnersTable() {
setStagedPartnerIds(null);
if (searchParams.has("partnerId")) {
- queryParams({ del: ["partnerId", "page"], scroll: false });
+ queryParams({ del: ["partnerId", "page"] });
}
}, [queryParams, searchParams]);
@@ -103,7 +102,6 @@ export function ApplicationsPartnersTable() {
queryParams({
set: { partnerId: partner.id },
del: "page",
- scroll: false,
});
setStagedPartnerIds(null);
}}
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/use-applications-analytics-filters.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/use-applications-analytics-filters.tsx
index e8770d8829..9308b17f39 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/use-applications-analytics-filters.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/applications/use-applications-analytics-filters.tsx
@@ -153,7 +153,7 @@ export function useApplicationAnalyticsFilters() {
const currentParam = searchParamsObj[key];
if (!currentParam) {
- queryParams({ set: { [key]: value }, del: "page", scroll: false });
+ queryParams({ set: { [key]: value }, del: "page" });
return;
}
@@ -163,7 +163,7 @@ export function useApplicationAnalyticsFilters() {
const newParam = parsed.operator.includes("NOT")
? `-${newValues.join(",")}`
: newValues.join(",");
- queryParams({ set: { [key]: newParam }, del: "page", scroll: false });
+ queryParams({ set: { [key]: newParam }, del: "page" });
}
},
[searchParamsObj, queryParams],
@@ -176,25 +176,25 @@ export function useApplicationAnalyticsFilters() {
const parsed = parseFilterValue(currentParam);
if (!parsed) {
- queryParams({ del: [key, "page"], scroll: false });
+ queryParams({ del: [key, "page"] });
return;
}
const newValues = parsed.values.filter((v) => v !== value);
if (newValues.length === 0) {
- queryParams({ del: [key, "page"], scroll: false });
+ queryParams({ del: [key, "page"] });
} else {
const newParam = parsed.operator.includes("NOT")
? `-${newValues.join(",")}`
: newValues.join(",");
- queryParams({ set: { [key]: newParam }, del: "page", scroll: false });
+ queryParams({ set: { [key]: newParam }, del: "page" });
}
},
[searchParamsObj, queryParams],
);
const onRemoveFilter = useCallback(
- (key: string) => queryParams({ del: [key, "page"], scroll: false }),
+ (key: string) => queryParams({ del: [key, "page"] }),
[queryParams],
);
@@ -202,7 +202,6 @@ export function useApplicationAnalyticsFilters() {
() =>
queryParams({
del: [...FILTER_KEYS, "page"],
- scroll: false,
}),
[queryParams],
);
@@ -216,7 +215,6 @@ export function useApplicationAnalyticsFilters() {
queryParams({
set: { [key]: isNegated ? cleanValue : `-${cleanValue}` },
del: "page",
- scroll: false,
});
},
[searchParamsObj, queryParams],
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-analytics-cards.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-analytics-cards.tsx
index eda5c5ce95..eeec5afb55 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-analytics-cards.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-analytics-cards.tsx
@@ -86,9 +86,9 @@ function useUrlListFilter(paramKey: string) {
const applyFilterValues = useCallback(
(values: string[]) => {
if (values.length === 0) {
- queryParams({ del: paramKey, scroll: false });
+ queryParams({ del: paramKey });
} else {
- queryParams({ set: { [paramKey]: values.join(",") }, scroll: false });
+ queryParams({ set: { [paramKey]: values.join(",") } });
}
setSelected([]);
},
@@ -98,7 +98,7 @@ function useUrlListFilter(paramKey: string) {
const clearFilter = useCallback(() => {
setSelected([]);
if (searchParams.has(paramKey)) {
- queryParams({ del: paramKey, scroll: false });
+ queryParams({ del: paramKey });
}
}, [paramKey, queryParams, searchParams]);
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-partners-table.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-partners-table.tsx
index 1aa93e7163..79a8071402 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-partners-table.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-partners-table.tsx
@@ -51,7 +51,6 @@ export function CommissionsPartnersTable() {
queryParams({
set: { partnerId: stagedPartnerIds.join(",") },
del: "page",
- scroll: false,
});
setStagedPartnerIds(null);
}, [queryParams, stagedPartnerIds]);
@@ -59,7 +58,7 @@ export function CommissionsPartnersTable() {
const clearFilter = useCallback(() => {
setStagedPartnerIds(null);
if (searchParams.has("partnerId")) {
- queryParams({ del: ["partnerId", "page"], scroll: false });
+ queryParams({ del: ["partnerId", "page"] });
}
}, [queryParams, searchParams]);
@@ -106,7 +105,6 @@ export function CommissionsPartnersTable() {
queryParams({
set: { partnerId },
del: "page",
- scroll: false,
});
setStagedPartnerIds(null);
}}
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-status-selector.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-status-selector.tsx
index 0409214890..7397bb2805 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-status-selector.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/commissions-status-selector.tsx
@@ -97,7 +97,6 @@ export function CommissionsStatusSelector({
...(id === undefined
? { del: "status" }
: { set: { status: id } }),
- scroll: false,
getNewPath: true,
}) as string
}
@@ -165,7 +164,7 @@ export function CommissionsStatusSelector({
]}
selected={unit}
selectAction={(v) =>
- queryParams({ set: { commissionUnit: v }, scroll: false })
+ queryParams({ set: { commissionUnit: v } })
}
/>
)}
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/use-commissions-analytics-filters.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/use-commissions-analytics-filters.tsx
index a4d2e21ce0..5d7f2998f2 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/use-commissions-analytics-filters.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/analytics/use-commissions-analytics-filters.tsx
@@ -212,7 +212,7 @@ export function useCommissionsAnalyticsFilters() {
const currentParam = searchParamsObj[key];
if (!currentParam) {
- queryParams({ set: { [key]: value }, del: "page", scroll: false });
+ queryParams({ set: { [key]: value }, del: "page" });
return;
}
@@ -222,7 +222,7 @@ export function useCommissionsAnalyticsFilters() {
const newParam = parsed.operator.includes("NOT")
? `-${newValues.join(",")}`
: newValues.join(",");
- queryParams({ set: { [key]: newParam }, del: "page", scroll: false });
+ queryParams({ set: { [key]: newParam }, del: "page" });
}
},
[searchParamsObj, queryParams],
@@ -235,25 +235,25 @@ export function useCommissionsAnalyticsFilters() {
const parsed = parseFilterValue(currentParam);
if (!parsed) {
- queryParams({ del: [key, "page"], scroll: false });
+ queryParams({ del: [key, "page"] });
return;
}
const newValues = parsed.values.filter((v) => v !== value);
if (newValues.length === 0) {
- queryParams({ del: [key, "page"], scroll: false });
+ queryParams({ del: [key, "page"] });
} else {
const newParam = parsed.operator.includes("NOT")
? `-${newValues.join(",")}`
: newValues.join(",");
- queryParams({ set: { [key]: newParam }, del: "page", scroll: false });
+ queryParams({ set: { [key]: newParam }, del: "page" });
}
},
[searchParamsObj, queryParams],
);
const onRemoveFilter = useCallback(
- (key: string) => queryParams({ del: [key, "page"], scroll: false }),
+ (key: string) => queryParams({ del: [key, "page"] }),
[queryParams],
);
@@ -261,7 +261,6 @@ export function useCommissionsAnalyticsFilters() {
() =>
queryParams({
del: [...FILTER_KEYS, "customerId", "page"],
- scroll: false,
}),
[queryParams],
);
@@ -275,7 +274,6 @@ export function useCommissionsAnalyticsFilters() {
queryParams({
set: { [key]: isNegated ? cleanValue : `-${cleanValue}` },
del: "page",
- scroll: false,
});
},
[searchParamsObj, queryParams],
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submission-details-sheet.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submission-details-sheet.tsx
index c9b2e5e8b4..86843091ac 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submission-details-sheet.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submission-details-sheet.tsx
@@ -618,7 +618,7 @@ export function BountySubmissionDetailsSheet({
<Sheet
open={isOpen}
onOpenChange={rest.setIsOpen}
- onClose={() => queryParams({ del: "submissionId", scroll: false })}
+ onClose={() => queryParams({ del: "submissionId" })}
>
<BountySubmissionDetailsSheetContent {...rest} />
</Sheet>
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submission-row-menu.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submission-row-menu.tsx
index 111be90e5c..4872a6ba20 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submission-row-menu.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submission-row-menu.tsx
@@ -70,7 +70,6 @@ export function BountySubmissionRowMenu({
set: {
submissionId: submission.id,
},
- scroll: false,
});
setIsOpen(false);
}}
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submissions-table.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submissions-table.tsx
index 8bed3d4b8e..f38bc2c8b3 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submissions-table.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/[bountyId]/bounty-submissions-table.tsx
@@ -390,7 +390,6 @@ export function BountySubmissionsTable() {
set: {
submissionId: row.original.id,
},
- scroll: false,
});
},
sortableColumns: [
@@ -407,7 +406,6 @@ export function BountySubmissionsTable() {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
pagination,
onPaginationChange: setPagination,
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty/add-edit-bounty-sheet.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty/add-edit-bounty-sheet.tsx
index 4173b04b05..f5d57b6233 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty/add-edit-bounty-sheet.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/bounties/add-edit-bounty/add-edit-bounty-sheet.tsx
@@ -616,7 +616,7 @@ export function BountySheet({
<Sheet
open={isOpen}
onOpenChange={rest.setIsOpen}
- onClose={() => queryParams({ del: "bountyId", scroll: false })}
+ onClose={() => queryParams({ del: "bountyId" })}
nested={nested}
>
<BountySheetContent {...rest} />
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/commissions-table.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/commissions-table.tsx
index 333de0ceb2..6e198b578d 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/commissions-table.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/commissions/commissions-table.tsx
@@ -341,7 +341,6 @@ export function CommissionsTable() {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
onRowClick: (row, e) => {
const url = `/${slug}/program/commissions/${row.original.id}`;
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/fraud-group-table.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/fraud-group-table.tsx
index b4989b29f2..cd20e03f27 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/fraud-group-table.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/fraud-group-table.tsx
@@ -209,7 +209,6 @@ export function FraudGroupTable() {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
getRowId: (row) => row.id,
onRowClick: (row) => {
@@ -217,7 +216,6 @@ export function FraudGroupTable() {
set: {
groupId: row.original.id,
},
- scroll: false,
});
},
cellRight: (cell) => {
@@ -327,7 +325,6 @@ export function FraudGroupTable() {
? () =>
queryParams({
set: { groupId: previousGroupId },
- scroll: false,
})
: undefined
}
@@ -336,7 +333,6 @@ export function FraudGroupTable() {
? () =>
queryParams({
set: { groupId: nextGroupId },
- scroll: false,
})
: undefined
}
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/resolved/resolved-fraud-group-table.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/resolved/resolved-fraud-group-table.tsx
index f60db14e55..c634d563b9 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/resolved/resolved-fraud-group-table.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/resolved/resolved-fraud-group-table.tsx
@@ -183,7 +183,6 @@ export function ResolvedFraudGroupTable() {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
getRowId: (row) => row.id,
onRowClick: (row) => {
@@ -191,7 +190,6 @@ export function ResolvedFraudGroupTable() {
set: {
groupId: row.original.id,
},
- scroll: false,
});
},
thClassName: "border-l-0",
@@ -233,7 +231,6 @@ export function ResolvedFraudGroupTable() {
? () =>
queryParams({
set: { groupId: previousGroupId },
- scroll: false,
})
: undefined
}
@@ -242,7 +239,6 @@ export function ResolvedFraudGroupTable() {
? () =>
queryParams({
set: { groupId: nextGroupId },
- scroll: false,
})
: undefined
}
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/use-fraud-group-filters.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/use-fraud-group-filters.tsx
index c33426f5ef..87cfddcfb7 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/use-fraud-group-filters.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/fraud/use-fraud-group-filters.tsx
@@ -83,7 +83,6 @@ export function useFraudGroupFilters({
[key]: value,
},
del: "page",
- scroll: false,
}),
[queryParams],
);
@@ -92,7 +91,6 @@ export function useFraudGroupFilters({
(key: string, _value?: any) =>
queryParams({
del: [key, "page"],
- scroll: false,
}),
[queryParams],
);
@@ -101,7 +99,6 @@ export function useFraudGroupFilters({
() =>
queryParams({
del: ["type", "partnerId", "page"],
- scroll: false,
}),
[queryParams],
);
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/discounts/group-discounts.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/discounts/group-discounts.tsx
index 3f28c8157d..60b64e5633 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/discounts/group-discounts.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/discounts/group-discounts.tsx
@@ -92,7 +92,6 @@ const DiscountItem = ({
set: {
discountId: discount?.id ?? "new",
},
- scroll: false,
});
}}
>
@@ -127,7 +126,6 @@ const DiscountItem = ({
set: {
discountId: discount?.id ?? "new",
},
- scroll: false,
});
}}
/>
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/rewards/group-rewards.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/rewards/group-rewards.tsx
index 5eac17aec0..d910226173 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/rewards/group-rewards.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/rewards/group-rewards.tsx
@@ -267,7 +267,6 @@ const RewardItem = ({
set: {
rewardId: reward.id,
},
- scroll: false,
});
}}
/>
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/groups-table.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/groups-table.tsx
index 4b3f03259c..00c75d3578 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/groups-table.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/groups-table.tsx
@@ -203,7 +203,6 @@ export function GroupsTable() {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
thClassName: "border-l-0",
tdClassName: "border-l-0",
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/network/network-partner-card.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/network/network-partner-card.tsx
index 3ae738ff28..a197f62360 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/network/network-partner-card.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/network/network-partner-card.tsx
@@ -101,7 +101,7 @@ export function NetworkPartnerCard({
"_blank",
);
} else {
- queryParams({ set: { partnerId: partner.id }, scroll: false });
+ queryParams({ set: { partnerId: partner.id } });
}
}}
>
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/network/page-client.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/network/page-client.tsx
index 3c93b584be..2372f89da4 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/network/page-client.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/network/page-client.tsx
@@ -133,7 +133,6 @@ export function ProgramPartnerNetworkPageClient({
? () =>
queryParams({
set: { partnerId: previousPartnerId },
- scroll: false,
})
: undefined
}
@@ -142,7 +141,6 @@ export function ProgramPartnerNetworkPageClient({
? () =>
queryParams({
set: { partnerId: nextPartnerId },
- scroll: false,
})
: undefined
}
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/page-client.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/page-client.tsx
index 6435bc10d4..b58dac7cd9 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/page-client.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/page-client.tsx
@@ -349,7 +349,6 @@ export function ProgramPartnersApplicationsPageClient() {
set: {
partnerId: row.original.id,
},
- scroll: false,
});
},
pagination,
@@ -366,7 +365,6 @@ export function ProgramPartnersApplicationsPageClient() {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
getRowId: (row) => row.id,
@@ -437,7 +435,6 @@ export function ProgramPartnersApplicationsPageClient() {
? () =>
queryParams({
set: { partnerId: previousPartnerId },
- scroll: false,
})
: undefined
}
@@ -446,7 +443,6 @@ export function ProgramPartnersApplicationsPageClient() {
? () =>
queryParams({
set: { partnerId: nextPartnerId },
- scroll: false,
})
: undefined
}
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/rejected/page-client.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/rejected/page-client.tsx
index f2cf6bd814..83f549e4d5 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/rejected/page-client.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/applications/rejected/page-client.tsx
@@ -323,7 +323,6 @@ export function ProgramPartnersRejectedApplicationsPageClient() {
set: {
partnerId: row.original.id,
},
- scroll: false,
});
},
pagination,
@@ -340,7 +339,6 @@ export function ProgramPartnersRejectedApplicationsPageClient() {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
thClassName: "border-l-0",
tdClassName: "border-l-0",
@@ -378,7 +376,6 @@ export function ProgramPartnersRejectedApplicationsPageClient() {
? () =>
queryParams({
set: { partnerId: previousPartnerId },
- scroll: false,
})
: undefined
}
@@ -387,7 +384,6 @@ export function ProgramPartnersRejectedApplicationsPageClient() {
? () =>
queryParams({
set: { partnerId: nextPartnerId },
- scroll: false,
})
: undefined
}
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/partners-table.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/partners-table.tsx
index f9fc936bcd..1dbbbf8af2 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/partners-table.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/partners-table.tsx
@@ -494,7 +494,6 @@ export function PartnersTable() {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
getRowId: (row) => row.id,
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-stats.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-stats.tsx
index 0ba7304a1d..97533ff621 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-stats.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-stats.tsx
@@ -68,7 +68,6 @@ export function PayoutStats() {
set: {
confirmPayouts: "true",
},
- scroll: false,
});
}
});
@@ -92,7 +91,6 @@ export function PayoutStats() {
set: {
confirmPayouts: "true",
},
- scroll: false,
});
}}
disabled={eligiblePayoutsLoading || confirmButtonDisabled}
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-table.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-table.tsx
index ccc6969d99..1c749ba164 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-table.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/payouts/payout-table.tsx
@@ -237,7 +237,6 @@ export function PayoutTable() {
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
onRowClick: (row, e) => {
const url = `/${workspaceSlug}/program/payouts/${row.original.id}`;
@@ -329,7 +328,6 @@ export function PayoutTable() {
selectedPayoutIds: pendingEligible.map((p) => p.id).join(","),
},
del: ["selectedPayoutId", "excludedPayoutIds"],
- scroll: false,
});
}}
/>
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/billing/usage-chart.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/billing/usage-chart.tsx
index 994f4a7331..20f07df6fe 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/billing/usage-chart.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/billing/usage-chart.tsx
@@ -84,21 +84,18 @@ export function UsageChart() {
const onSelect = (key: string, value: string) => {
queryParams({
set: { [key]: value },
- scroll: false,
});
};
const onRemove = (key: string) => {
queryParams({
del: key,
- scroll: false,
});
};
const onRemoveAll = () => {
queryParams({
del: ["folderId", "domain"],
- scroll: false,
});
};
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/page-client.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/page-client.tsx
index 553db96dae..b2107d56d6 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/page-client.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/page-client.tsx
@@ -149,7 +149,6 @@ export function WorkspaceTrackingSettingsPageClient() {
if (expandedStep === step) {
queryParams({
del: ["step", "guide"],
- scroll: false,
});
} else {
queryParams({
@@ -157,7 +156,6 @@ export function WorkspaceTrackingSettingsPageClient() {
set: {
step,
},
- scroll: false,
});
}
};
@@ -166,7 +164,6 @@ export function WorkspaceTrackingSettingsPageClient() {
if (expandedStep === step) {
queryParams({
del: ["step", "guide"],
- scroll: false,
});
}
};
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/use-selected-guide.ts b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/use-selected-guide.ts
index c526a9eaa2..ef541c3693 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/use-selected-guide.ts
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/use-selected-guide.ts
@@ -25,6 +25,6 @@ export function useSelectedGuide({ guides }: { guides: IntegrationGuide[] }) {
return {
selectedGuide,
setSelectedGuide: (guide: IntegrationGuide) =>
- queryParams({ set: { guide: guide.key }, scroll: false }),
+ queryParams({ set: { guide: guide.key } }),
};
}
diff --git a/apps/web/ui/analytics/device-section.tsx b/apps/web/ui/analytics/device-section.tsx
index daef326252..289dfc9604 100644
--- a/apps/web/ui/analytics/device-section.tsx
+++ b/apps/web/ui/analytics/device-section.tsx
@@ -39,11 +39,10 @@ export function DeviceSection() {
const onApplyFilterValues = useCallback(
(values: string[]) => {
if (values.length === 0) {
- queryParams({ del: singularTabName, scroll: false });
+ queryParams({ del: singularTabName });
} else {
queryParams({
set: { [singularTabName]: values.join(",") },
- scroll: false,
});
}
setSelectedItems([]);
diff --git a/apps/web/ui/analytics/location-section.tsx b/apps/web/ui/analytics/location-section.tsx
index b5f146216e..ecd513ec0d 100644
--- a/apps/web/ui/analytics/location-section.tsx
+++ b/apps/web/ui/analytics/location-section.tsx
@@ -47,11 +47,10 @@ export function LocationSection() {
const onApplyFilterValues = useCallback(
(values: string[]) => {
if (values.length === 0) {
- queryParams({ del: singularTabName, scroll: false });
+ queryParams({ del: singularTabName });
} else {
queryParams({
set: { [singularTabName]: values.join(",") },
- scroll: false,
});
}
setSelectedItems([]);
diff --git a/apps/web/ui/analytics/partner-segments-section.tsx b/apps/web/ui/analytics/partner-segments-section.tsx
index 038c4a36eb..464fa8ef18 100644
--- a/apps/web/ui/analytics/partner-segments-section.tsx
+++ b/apps/web/ui/analytics/partner-segments-section.tsx
@@ -112,11 +112,10 @@ export function PartnerSegmentsSection() {
(values: string[]) => {
if (!filterParamKey) return;
if (values.length === 0) {
- queryParams({ del: filterParamKey, scroll: false });
+ queryParams({ del: filterParamKey });
} else {
queryParams({
set: { [filterParamKey]: values.join(",") },
- scroll: false,
});
}
setSelectedItems([]);
diff --git a/apps/web/ui/analytics/referrers-utms.tsx b/apps/web/ui/analytics/referrers-utms.tsx
index bf7bb4bd82..2b7ef694c6 100644
--- a/apps/web/ui/analytics/referrers-utms.tsx
+++ b/apps/web/ui/analytics/referrers-utms.tsx
@@ -78,11 +78,10 @@ export function ReferrersUTMs() {
const onApplyFilterValues = useCallback(
(values: string[]) => {
if (values.length === 0) {
- queryParams({ del: singularTabName, scroll: false });
+ queryParams({ del: singularTabName });
} else {
queryParams({
set: { [singularTabName]: values.join(",") },
- scroll: false,
});
}
setSelectedItems([]);
diff --git a/apps/web/ui/analytics/toggle.tsx b/apps/web/ui/analytics/toggle.tsx
index 521ae6763a..34d8eded7a 100644
--- a/apps/web/ui/analytics/toggle.tsx
+++ b/apps/web/ui/analytics/toggle.tsx
@@ -112,7 +112,6 @@ export function AnalyticsToggle({
set: {
interval: preset.id,
},
- scroll: false,
});
return;
@@ -127,7 +126,6 @@ export function AnalyticsToggle({
start: range.from.toISOString(),
end: range.to.toISOString(),
},
- scroll: false,
});
}}
presets={INTERVAL_DISPLAYS.map(({ display, value, shortcut }) => {
diff --git a/apps/web/ui/analytics/top-links.tsx b/apps/web/ui/analytics/top-links.tsx
index 5ec86aff53..b81a76df91 100644
--- a/apps/web/ui/analytics/top-links.tsx
+++ b/apps/web/ui/analytics/top-links.tsx
@@ -94,11 +94,10 @@ export function TopLinks() {
if (!filterParamKey) return;
if (values.length === 0) {
- queryParams({ del: filterParamKey, scroll: false });
+ queryParams({ del: filterParamKey });
} else {
queryParams({
set: { [filterParamKey]: values.join(",") },
- scroll: false,
});
}
diff --git a/apps/web/ui/analytics/use-analytics-filters.tsx b/apps/web/ui/analytics/use-analytics-filters.tsx
index 2664296b97..030056c248 100644
--- a/apps/web/ui/analytics/use-analytics-filters.tsx
+++ b/apps/web/ui/analytics/use-analytics-filters.tsx
@@ -910,7 +910,6 @@ export function useAnalyticsFilters({
if (value.length === 0) {
queryParams({
del: key,
- scroll: false,
});
} else {
const currentParam = searchParamsObj[key];
@@ -921,7 +920,6 @@ export function useAnalyticsFilters({
queryParams({
set: { [key]: newParam },
del: "page",
- scroll: false,
});
}
@@ -955,7 +953,6 @@ export function useAnalyticsFilters({
queryParams({
set: { [key]: value },
del: "page",
- scroll: false,
});
} else {
const parsed = parseFilterParam(currentParam);
@@ -969,7 +966,6 @@ export function useAnalyticsFilters({
queryParams({
set: { [key]: newParam },
del: "page",
- scroll: false,
});
}
}
@@ -987,7 +983,7 @@ export function useAnalyticsFilters({
searchParamsObj.key &&
!searchParamsObj.linkId
) {
- queryParams({ del: ["domain", "key"], scroll: false });
+ queryParams({ del: ["domain", "key"] });
return;
}
@@ -997,14 +993,14 @@ export function useAnalyticsFilters({
const parsed = parseFilterParam(currentParam);
if (!parsed) {
- queryParams({ del: key, scroll: false });
+ queryParams({ del: key });
return;
}
const newValues = parsed.values.filter((v) => v !== value);
if (newValues.length === 0) {
- queryParams({ del: key, scroll: false });
+ queryParams({ del: key });
} else {
const newParam = parsed.operator.includes("NOT")
? `-${newValues.join(",")}`
@@ -1012,7 +1008,6 @@ export function useAnalyticsFilters({
queryParams({
set: { [key]: newParam },
- scroll: false,
});
}
},
@@ -1026,7 +1021,6 @@ export function useAnalyticsFilters({
del: VALID_ANALYTICS_FILTERS.concat(["page"]).filter(
(f) => !["interval", "start", "end"].includes(f),
),
- scroll: false,
}),
[queryParams],
);
@@ -1048,14 +1042,13 @@ export function useAnalyticsFilters({
queryParams({
set: { [key]: newParam },
del: "page",
- scroll: false,
});
},
[searchParamsObj, queryParams],
);
const onRemoveFilter = useCallback(
- (key) => queryParams({ del: key, scroll: false }),
+ (key) => queryParams({ del: key }),
[queryParams],
);
diff --git a/apps/web/ui/customers/customers-table/customers-table.tsx b/apps/web/ui/customers/customers-table/customers-table.tsx
index 25a4a6183e..073a201222 100644
--- a/apps/web/ui/customers/customers-table/customers-table.tsx
+++ b/apps/web/ui/customers/customers-table/customers-table.tsx
@@ -371,7 +371,6 @@ export function CustomersTable({
...(sortOrder && { sortOrder }),
},
del: "page",
- scroll: false,
}),
cellRight: (cell) => {
const meta = cell.column.columnDef.meta as ColumnMeta | undefined;
diff --git a/apps/web/ui/guides/guide-list.tsx b/apps/web/ui/guides/guide-list.tsx
index ba98f5d53f..26b453656b 100644
--- a/apps/web/ui/guides/guide-list.tsx
+++ b/apps/web/ui/guides/guide-list.tsx
@@ -49,7 +49,6 @@ export function GuideList() {
set: {
step: value || "none",
},
- scroll: false,
});
}}
className="space-y-4"
@@ -128,7 +127,6 @@ export function GuideList() {
set: {
step: sections[index + 1].type,
},
- scroll: false,
});
}}
/>
diff --git a/apps/web/ui/modals/start-paid-plan-modal.tsx b/apps/web/ui/modals/start-paid-plan-modal.tsx
index 39254285fb..a7fc2772ee 100644
--- a/apps/web/ui/modals/start-paid-plan-modal.tsx
+++ b/apps/web/ui/modals/start-paid-plan-modal.tsx
@@ -57,7 +57,6 @@ function StartPaidPlanModal({
plan: plan ?? "pro",
},
replace: true,
- scroll: false,
});
setShowModal(false);
} else {
diff --git a/apps/web/ui/modals/trial-limit-activate-modal.tsx b/apps/web/ui/modals/trial-limit-activate-modal.tsx
index a7efa22f82..a15786dfc4 100644
--- a/apps/web/ui/modals/trial-limit-activate-modal.tsx
+++ b/apps/web/ui/modals/trial-limit-activate-modal.tsx
@@ -54,7 +54,6 @@ function TrialLimitActivateModalInner({
plan: plan ?? "pro",
},
replace: true,
- scroll: false,
});
setShowModal(false);
} else {
diff --git a/apps/web/ui/partners/fraud-risks/fraud-review-sheet.tsx b/apps/web/ui/partners/fraud-risks/fraud-review-sheet.tsx
index 779f5580be..268e514f89 100644
--- a/apps/web/ui/partners/fraud-risks/fraud-review-sheet.tsx
+++ b/apps/web/ui/partners/fraud-risks/fraud-review-sheet.tsx
@@ -399,7 +399,7 @@ export function FraudReviewSheet({
// Clear the groupId from URL when closing
if (!open) {
- queryParams({ del: "groupId", scroll: false });
+ queryParams({ del: "groupId" });
}
};
diff --git a/apps/web/ui/partners/partner-application-sheet.tsx b/apps/web/ui/partners/partner-application-sheet.tsx
index 9c78066b38..f3a4225f4b 100644
--- a/apps/web/ui/partners/partner-application-sheet.tsx
+++ b/apps/web/ui/partners/partner-application-sheet.tsx
@@ -201,7 +201,7 @@ export function PartnerApplicationSheet({
<Sheet
open={isOpen}
onOpenChange={rest.setIsOpen}
- onClose={() => queryParams({ del: "partnerId", scroll: false })}
+ onClose={() => queryParams({ del: "partnerId" })}
nested={nested}
contentProps={{
// 540px - 1170px width based on viewport
diff --git a/apps/web/ui/partners/partner-network/network-partner-sheet.tsx b/apps/web/ui/partners/partner-network/network-partner-sheet.tsx
index 75490a7545..74c92b49ac 100644
--- a/apps/web/ui/partners/partner-network/network-partner-sheet.tsx
+++ b/apps/web/ui/partners/partner-network/network-partner-sheet.tsx
@@ -178,7 +178,7 @@ export function NetworkPartnerSheet({
<Sheet
open={isOpen}
onOpenChange={rest.setIsOpen}
- onClose={() => queryParams({ del: "partnerId", scroll: false })}
+ onClose={() => queryParams({ del: "partnerId" })}
nested={nested}
contentProps={{
// 540px - 1170px width based on viewport
diff --git a/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx b/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
index d706c72aee..ea69ef28a8 100644
--- a/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
+++ b/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
@@ -309,7 +309,7 @@ function RewardSheetContent({
updateRewardAction,
{
onSuccess: async () => {
- queryParams({ del: "rewardId", scroll: false });
+ queryParams({ del: "rewardId" });
toast.success("Reward updated!");
await mutateProgram();
await mutateGroup();
@@ -825,7 +825,7 @@ export function RewardSheet({
open={isOpen}
onOpenChange={rest.setIsOpen}
nested={nested}
- onClose={() => queryParams({ del: "rewardId", scroll: false })}
+ onClose={() => queryParams({ del: "rewardId" })}
>
<RewardSheetContent {...rest} />
</Sheet>
diff --git a/apps/web/ui/shared/simple-date-range-picker.tsx b/apps/web/ui/shared/simple-date-range-picker.tsx
index c1e64dac8e..c03be07c23 100644
--- a/apps/web/ui/shared/simple-date-range-picker.tsx
+++ b/apps/web/ui/shared/simple-date-range-picker.tsx
@@ -51,7 +51,6 @@ export default function SimpleDateRangePicker({
set: {
interval: preset.id,
},
- scroll: false,
});
return;
@@ -66,7 +65,6 @@ export default function SimpleDateRangePicker({
start: range.from.toISOString(),
end: range.to.toISOString(),
},
- scroll: false,
});
}}
presets={(presets
diff --git a/apps/web/ui/submitted-leads/partner-profile-submitted-lead-sheet.tsx b/apps/web/ui/submitted-leads/partner-profile-submitted-lead-sheet.tsx
index a228c240ad..d1c14ee27a 100644
--- a/apps/web/ui/submitted-leads/partner-profile-submitted-lead-sheet.tsx
+++ b/apps/web/ui/submitted-leads/partner-profile-submitted-lead-sheet.tsx
@@ -111,7 +111,7 @@ export function PartnerProfileSubmittedLeadSheet({
<Sheet
open={isOpen}
onOpenChange={rest.setIsOpen}
- onClose={() => queryParams({ del: "leadId", scroll: false })}
+ onClose={() => queryParams({ del: "leadId" })}
nested={nested}
contentProps={{
// 540px - 1170px width based on viewport
diff --git a/apps/web/ui/submitted-leads/submitted-lead-sheet.tsx b/apps/web/ui/submitted-leads/submitted-lead-sheet.tsx
index f09a40ec96..24ec74c01a 100644
--- a/apps/web/ui/submitted-leads/submitted-lead-sheet.tsx
+++ b/apps/web/ui/submitted-leads/submitted-lead-sheet.tsx
@@ -176,7 +176,7 @@ export function SubmittedLeadSheet({
<Sheet
open={isOpen}
onOpenChange={rest.setIsOpen}
- onClose={() => queryParams({ del: "leadId", scroll: false })}
+ onClose={() => queryParams({ del: "leadId" })}
nested={nested}
contentProps={{
// 540px - 1170px width based on viewport
diff --git a/apps/web/ui/submitted-leads/submitted-lead-table.tsx b/apps/web/ui/submitted-leads/submitted-lead-table.tsx
index 261736dad0..858db2299e 100644
--- a/apps/web/ui/submitted-leads/submitted-lead-table.tsx
+++ b/apps/web/ui/submitted-leads/submitted-lead-table.tsx
@@ -173,7 +173,6 @@ export function SubmittedLeadTable() {
onRowClick: (row) => {
queryParams({
set: { leadId: row.original.id },
- scroll: false,
});
setDetailsSheetState({
leadId: row.original.id,
@@ -231,7 +230,6 @@ export function SubmittedLeadTable() {
? () => {
queryParams({
set: { leadId: previousLeadId },
- scroll: false,
});
setDetailsSheetState({
leadId: previousLeadId,
@@ -245,7 +243,6 @@ export function SubmittedLeadTable() {
? () => {
queryParams({
set: { leadId: nextLeadId },
- scroll: false,
});
setDetailsSheetState({
leadId: nextLeadId,
diff --git a/packages/ui/src/hooks/use-pagination.ts b/packages/ui/src/hooks/use-pagination.ts
index fe175c930a..8172953067 100644
--- a/packages/ui/src/hooks/use-pagination.ts
+++ b/packages/ui/src/hooks/use-pagination.ts
@@ -22,12 +22,11 @@ export function usePagination(pageSize = DEFAULT_PAGINATION_LIMIT) {
onPageChange: (p) => {
queryParams(
p === 1
- ? { del: "page", scroll: false }
+ ? { del: "page" }
: {
set: {
page: p.toString(),
},
- scroll: false,
},
);
},
@@ -46,12 +45,11 @@ export function usePagination(pageSize = DEFAULT_PAGINATION_LIMIT) {
useEffect(() => {
queryParams(
pagination.pageIndex === 1
- ? { del: "page", scroll: false }
+ ? { del: "page" }
: {
set: {
page: pagination.pageIndex.toString(),
},
- scroll: false,
},
);
}, [pagination]);
diff --git a/packages/ui/src/hooks/use-router-stuff.ts b/packages/ui/src/hooks/use-router-stuff.ts
index a532d3e4cb..aa5d44c5c7 100644
--- a/packages/ui/src/hooks/use-router-stuff.ts
+++ b/packages/ui/src/hooks/use-router-stuff.ts
@@ -57,7 +57,7 @@ export function useRouterStuff() {
set,
del,
replace,
- scroll = true,
+ scroll = false,
getNewPath,
arrayDelimiter = ",",
}: {