Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

subscriptionDurationMonths

Steven Tey2971ebfbb704
diff --git a/apps/web/lib/partners/create-partner-commission.ts b/apps/web/lib/partners/create-partner-commission.ts
index c1ddcac7e4..085448fa8e 100644
--- a/apps/web/lib/partners/create-partner-commission.ts
+++ b/apps/web/lib/partners/create-partner-commission.ts
@@ -216,12 +216,12 @@ export const createPartnerCommission = async ({
// Recurring sale reward (maxDuration > 0)
else {
- const subscriptionDuration = differenceInMonths(
+ const subscriptionDurationMonths = differenceInMonths(
new Date(),
firstCommission.createdAt,
);
- if (subscriptionDuration >= reward.maxDuration) {
+ if (subscriptionDurationMonths >= reward.maxDuration) {
console.log(
`Partner ${partnerId} has reached max duration for ${event} event, skipping commission creation...`,
);
@@ -240,14 +240,14 @@ export const createPartnerCommission = async ({
...context,
customer: {
...context?.customer,
- subscriptionDuration,
+ subscriptionDurationMonths,
},
},
});
if (!reward) {
console.log(
- `Partner ${partnerId} does not have a qualifying reward for subscription duration ${subscriptionDuration}, skipping commission creation...`,
+ `Partner ${partnerId} does not have a qualifying reward for subscription duration ${subscriptionDurationMonths}, skipping commission creation...`,
);
return {
commission: null,
diff --git a/apps/web/lib/zod/schemas/rewards.ts b/apps/web/lib/zod/schemas/rewards.ts
index f950effbc9..cf3ceb1e25 100644
--- a/apps/web/lib/zod/schemas/rewards.ts
+++ b/apps/web/lib/zod/schemas/rewards.ts
@@ -148,7 +148,7 @@ export const REWARD_CONDITIONS: Record<
],
},
{
- id: "subscriptionDuration",
+ id: "subscriptionDurationMonths",
label: "Subscription duration",
type: "number",
},
@@ -352,7 +352,7 @@ export const rewardContextSchema = z.object({
.object({
country: z.string().nullish(),
source: z.enum(CUSTOMER_SOURCES).default("tracked").nullish(),
- subscriptionDuration: z.number().nullish(),
+ subscriptionDurationMonths: z.number().nullish(),
})
.optional(),
diff --git a/apps/web/tests/rewards/reward-conditions.test.ts b/apps/web/tests/rewards/reward-conditions.test.ts
index b7558ed37e..cc28f4c154 100644
--- a/apps/web/tests/rewards/reward-conditions.test.ts
+++ b/apps/web/tests/rewards/reward-conditions.test.ts
@@ -1662,7 +1662,7 @@ describe("evaluateRewardConditions", () => {
});
describe("subscription duration conditions", () => {
- describe("customer.subscriptionDuration", () => {
+ describe("customer.subscriptionDurationMonths", () => {
test("should match when subscription duration meets greater_than_or_equal condition", () => {
const conditions = [
{
@@ -1672,7 +1672,7 @@ describe("evaluateRewardConditions", () => {
conditions: [
{
entity: "customer" as const,
- attribute: "subscriptionDuration" as const,
+ attribute: "subscriptionDurationMonths" as const,
operator: "greater_than_or_equal" as const,
value: 12,
},
@@ -1682,7 +1682,7 @@ describe("evaluateRewardConditions", () => {
const context: RewardContext = {
customer: {
- subscriptionDuration: 12,
+ subscriptionDurationMonths: 12,
},
};
@@ -1703,7 +1703,7 @@ describe("evaluateRewardConditions", () => {
conditions: [
{
entity: "customer" as const,
- attribute: "subscriptionDuration" as const,
+ attribute: "subscriptionDurationMonths" as const,
operator: "greater_than_or_equal" as const,
value: 12,
},
@@ -1713,7 +1713,7 @@ describe("evaluateRewardConditions", () => {
const context: RewardContext = {
customer: {
- subscriptionDuration: 6,
+ subscriptionDurationMonths: 6,
},
};
diff --git a/apps/web/ui/partners/program-reward-modifiers-tooltip.tsx b/apps/web/ui/partners/program-reward-modifiers-tooltip.tsx
index 6e2efe9c18..58f992d4e2 100644
--- a/apps/web/ui/partners/program-reward-modifiers-tooltip.tsx
+++ b/apps/web/ui/partners/program-reward-modifiers-tooltip.tsx
@@ -174,7 +174,7 @@ const RewardItem = ({
{condition.entity}{" "}
{(
attribute?.label ??
- (condition.attribute === "subscriptionDuration"
+ (condition.attribute === "subscriptionDurationMonths"
? "Subscription duration"
: condition.attribute)
)?.toLowerCase()}{" "}
@@ -188,7 +188,7 @@ const RewardItem = ({
.join(", ")
: COUNTRIES[condition.value?.toString()] ??
condition.value
- : condition.attribute === "subscriptionDuration"
+ : condition.attribute === "subscriptionDurationMonths"
? Array.isArray(condition.value)
? (condition.value as number[])
.map(formatSubscriptionDuration)
diff --git a/apps/web/ui/partners/rewards/rewards-logic.tsx b/apps/web/ui/partners/rewards/rewards-logic.tsx
index ab3ca7a39b..af7c4a4656 100644
--- a/apps/web/ui/partners/rewards/rewards-logic.tsx
+++ b/apps/web/ui/partners/rewards/rewards-logic.tsx
@@ -565,7 +565,7 @@ function ConditionLogic({
)}
</InlineBadgePopover>
- {condition.attribute === "subscriptionDuration" && (
+ {condition.attribute === "subscriptionDurationMonths" && (
<span> months</span>
)}