Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Handle nullable saleAmount on partner link UI types.

Kiran K2a45e94587c5
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx
index 36105e8484..d2a6eceb84 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx
@@ -274,27 +274,31 @@ const StatsBadge = memo(({ link }: { link: PartnerProfileLinkProps }) => {
className,
iconClassName,
currency,
- }) => (
- <div
- key={tab}
- className={cn(
- "flex items-center gap-1.5 whitespace-nowrap rounded px-[5px] py-[3px] transition-colors",
- className,
- )}
- >
- <Icon
- data-active={value > 0}
- className={cn("h-4 w-4 shrink-0", iconClassName)}
- />
- <span>
- {currency
- ? currencyFormatter(value, {
- trailingZeroDisplay: "stripIfInteger",
- })
- : nFormatter(value)}
- </span>
- </div>
- ),
+ }) => {
+ const displayValue = value ?? 0;
+
+ return (
+ <div
+ key={tab}
+ className={cn(
+ "flex items-center gap-1.5 whitespace-nowrap rounded px-[5px] py-[3px] transition-colors",
+ className,
+ )}
+ >
+ <Icon
+ data-active={displayValue > 0}
+ className={cn("h-4 w-4 shrink-0", iconClassName)}
+ />
+ <span>
+ {currency
+ ? currencyFormatter(displayValue, {
+ trailingZeroDisplay: "stripIfInteger",
+ })
+ : nFormatter(displayValue)}
+ </span>
+ </div>
+ );
+ },
)}
</As>
);
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/links/referral-links.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/links/referral-links.tsx
index 02c135f79c..1616d501e0 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/links/referral-links.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/partners/[partnerId]/links/referral-links.tsx
@@ -202,11 +202,15 @@ const PARTNER_LINK_STATS = [
icon: InvoiceDollar,
event: "sales",
iconClassName: "data-[active=true]:text-teal-500",
- getValue: (link: PartnerLink) => ({
- count: link.saleAmount,
- formatted: `$${nFormatter(link.saleAmount / 100)}`,
- tooltip: `${currencyFormatter(link.saleAmount, { trailingZeroDisplay: "stripIfInteger" })} revenue`,
- }),
+ getValue: (link: PartnerLink) => {
+ const saleAmount = link.saleAmount ?? 0;
+
+ return {
+ count: saleAmount,
+ formatted: `$${nFormatter(saleAmount / 100)}`,
+ tooltip: `${currencyFormatter(saleAmount, { trailingZeroDisplay: "stripIfInteger" })} revenue`,
+ };
+ },
},
] as const;
diff --git a/apps/web/ui/partners/partner-link-selector.tsx b/apps/web/ui/partners/partner-link-selector.tsx
index 9111e0aa98..2ba72356db 100644
--- a/apps/web/ui/partners/partner-link-selector.tsx
+++ b/apps/web/ui/partners/partner-link-selector.tsx
@@ -9,10 +9,9 @@ import { cn, getApexDomain, linkConstructor } from "@dub/utils";
import { ReactNode, useEffect, useMemo, useState } from "react";
import { useDebounce } from "use-debounce";
-type PartnerLinkOption = Pick<
- LinkProps,
- "id" | "domain" | "key" | "url" | "saleAmount"
->;
+type PartnerLinkOption = Pick<LinkProps, "id" | "domain" | "key" | "url"> & {
+ saleAmount?: number | null;
+};
const getLinkOption = (link: PartnerLinkOption) => ({
value: link.id,
@@ -99,7 +98,7 @@ export function PartnerLinkSelector({
if (!links?.length) return null;
return links.reduce((best, current) =>
- current.saleAmount > best.saleAmount ? current : best,
+ (current.saleAmount ?? 0) > (best.saleAmount ?? 0) ? current : best,
);
}, [links]);