Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Remove `partnerDuplicatePayoutMethod` enum (#3783)

Kiran K2e211246dfca
diff --git a/apps/web/lib/api/fraud/execute-fraud-rule.ts b/apps/web/lib/api/fraud/execute-fraud-rule.ts
index d8ef692a4d..a7ae12868a 100644
--- a/apps/web/lib/api/fraud/execute-fraud-rule.ts
+++ b/apps/web/lib/api/fraud/execute-fraud-rule.ts
@@ -23,9 +23,6 @@ const FRAUD_RULES_REGISTRY: Record<
referralSourceBanned: checkReferralSourceBanned,
paidTrafficDetected: checkPaidTrafficDetected,
partnerCrossProgramBan: defineFraudRuleStub("partnerCrossProgramBan"),
- partnerDuplicatePayoutMethod: defineFraudRuleStub(
- "partnerDuplicatePayoutMethod",
- ),
partnerDuplicateAccount: defineFraudRuleStub("partnerDuplicateAccount"),
};
diff --git a/apps/web/lib/api/fraud/utils.ts b/apps/web/lib/api/fraud/utils.ts
index d2e66ee8fc..917a76f5a2 100644
--- a/apps/web/lib/api/fraud/utils.ts
+++ b/apps/web/lib/api/fraud/utils.ts
@@ -94,10 +94,6 @@ function getIdentityFieldsForFraudEvent({
duplicatePartnerId: eventMetadata?.duplicatePartnerId,
};
- // Note: This will be removed in the next PR
- case "partnerDuplicatePayoutMethod":
- throw new Error("Fraud rule is no longer supported.");
-
case "partnerCrossProgramBan":
if (!sourceProgramId) {
throw new Error(`sourceProgramId is required for ${type} fraud rule.`);
@@ -106,6 +102,9 @@ function getIdentityFieldsForFraudEvent({
return {
sourceProgramId,
};
+
+ default:
+ return {};
}
}
diff --git a/apps/web/scripts/migrations/consolidate-duplicate-account-fraud.ts b/apps/web/scripts/migrations/consolidate-duplicate-account-fraud.ts
deleted file mode 100644
index f958f0235d..0000000000
--- a/apps/web/scripts/migrations/consolidate-duplicate-account-fraud.ts
+++ /dev/null
@@ -1,41 +0,0 @@
-import { prisma } from "@dub/prisma";
-import "dotenv-flow/config";
-
-async function main() {
- // Migrate FraudRule
- const { count } = await prisma.fraudRule.updateMany({
- where: {
- type: "partnerDuplicatePayoutMethod",
- },
- data: {
- type: "partnerDuplicateAccount",
- },
- });
-
- console.log(
- `Updated ${count} fraud rules from partnerDuplicatePayoutMethod to partnerDuplicateAccount`,
- );
-
- // Migrate FraudEventGroup
- while (true) {
- const { count } = await prisma.fraudEventGroup.updateMany({
- where: {
- type: "partnerDuplicatePayoutMethod",
- },
- data: {
- type: "partnerDuplicateAccount",
- },
- limit: 100,
- });
-
- console.log(
- `Updated ${count} fraud event groups from partnerDuplicatePayoutMethod to partnerDuplicateAccount`,
- );
-
- if (count === 0) {
- break;
- }
- }
-}
-
-main();
diff --git a/packages/prisma/schema/fraud.prisma b/packages/prisma/schema/fraud.prisma
index f831377661..c8bfdcdddd 100644
--- a/packages/prisma/schema/fraud.prisma
+++ b/packages/prisma/schema/fraud.prisma
@@ -9,7 +9,6 @@ enum FraudRuleType {
referralSourceBanned
paidTrafficDetected
partnerCrossProgramBan // Cross-program ban from other programs
- partnerDuplicatePayoutMethod // Duplicate payout method with other partners
partnerDuplicateAccount // Duplicate identity with other partners
}