Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Fix: Allow free plan users to update the domain (#3347)

Kiran K2fd1afa54e71
diff --git a/apps/web/app/api/domains/[domain]/route.ts b/apps/web/app/api/domains/[domain]/route.ts
index 6f0e9ae37b..ec5ac25742 100644
--- a/apps/web/app/api/domains/[domain]/route.ts
+++ b/apps/web/app/api/domains/[domain]/route.ts
@@ -7,6 +7,7 @@ import { transformDomain } from "@/lib/api/domains/transform-domain";
import { validateDomain } from "@/lib/api/domains/utils";
import { DubApiError } from "@/lib/api/errors";
import { parseRequestBody } from "@/lib/api/utils";
+import { isNonEmptyJson } from "@/lib/api/utils/is-non-empty-json";
import { withWorkspace } from "@/lib/auth";
import { setRenewOption } from "@/lib/dynadot/set-renew-option";
import { storage } from "@/lib/storage";
@@ -75,7 +76,7 @@ export const PATCH = withWorkspace(
notFoundUrl ||
assetLinks ||
appleAppSiteAssociation ||
- deepviewData
+ isNonEmptyJson(deepviewData)
) {
const proFeaturesString = combineWords(
[
@@ -84,7 +85,7 @@ export const PATCH = withWorkspace(
notFoundUrl && "not found URLs",
assetLinks && "Asset Links",
appleAppSiteAssociation && "Apple App Site Association",
- deepviewData && "Deep View",
+ isNonEmptyJson(deepviewData) && "Deep View",
].filter(Boolean) as string[],
);
diff --git a/apps/web/app/api/domains/route.ts b/apps/web/app/api/domains/route.ts
index 672f820686..4374160882 100644
--- a/apps/web/app/api/domains/route.ts
+++ b/apps/web/app/api/domains/route.ts
@@ -5,6 +5,7 @@ import { validateDomain } from "@/lib/api/domains/utils";
import { DubApiError } from "@/lib/api/errors";
import { createLink, transformLink } from "@/lib/api/links";
import { parseRequestBody } from "@/lib/api/utils";
+import { isNonEmptyJson } from "@/lib/api/utils/is-non-empty-json";
import { withWorkspace } from "@/lib/auth";
import { exceededLimitError } from "@/lib/exceeded-limit-error";
import { storage } from "@/lib/storage";
@@ -108,7 +109,7 @@ export const POST = withWorkspace(
notFoundUrl ||
assetLinks ||
appleAppSiteAssociation ||
- deepviewData
+ isNonEmptyJson(deepviewData)
) {
const proFeaturesString = combineWords(
[
@@ -117,7 +118,7 @@ export const POST = withWorkspace(
notFoundUrl && "not found URLs",
assetLinks && "Asset Links",
appleAppSiteAssociation && "Apple App Site Association",
- deepviewData && "Deep View",
+ isNonEmptyJson(deepviewData) && "Deep View",
].filter(Boolean) as string[],
);
diff --git a/apps/web/lib/api/utils/is-non-empty-json.ts b/apps/web/lib/api/utils/is-non-empty-json.ts
new file mode 100644
index 0000000000..c059c07f0d
--- /dev/null
+++ b/apps/web/lib/api/utils/is-non-empty-json.ts
@@ -0,0 +1,17 @@
+export function isNonEmptyJson(jsonString?: string | null): boolean {
+ if (!jsonString) {
+ return false;
+ }
+
+ try {
+ const parsed = JSON.parse(jsonString);
+
+ return (
+ parsed !== null &&
+ typeof parsed === "object" &&
+ Object.keys(parsed).length > 0
+ );
+ } catch {
+ return false;
+ }
+}