Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Ban from the network before confirming fraud alerts

Rafi30ac8542e371
diff --git a/apps/web/app/(ee)/api/admin/fraud-alerts/[fraudAlertId]/route.ts b/apps/web/app/(ee)/api/admin/fraud-alerts/[fraudAlertId]/route.ts
index 119eb7ddc1..ed375a0273 100644
--- a/apps/web/app/(ee)/api/admin/fraud-alerts/[fraudAlertId]/route.ts
+++ b/apps/web/app/(ee)/api/admin/fraud-alerts/[fraudAlertId]/route.ts
@@ -70,6 +70,11 @@ export const PATCH = withAdmin(
return NextResponse.json({ success: true });
}
+ // Ban first, so that a failed ban can be retried before the alert is confirmed
+ if (banFromNetwork) {
+ await banPartnerFromNetwork(fraudAlert.partnerId);
+ }
+
const { confirmedCount } = await confirmPartnerFraudAlerts({
partnerId: fraudAlert.partnerId,
reviewedById: session.user.id,
@@ -82,10 +87,6 @@ export const PATCH = withAdmin(
});
}
- if (banFromNetwork) {
- await banPartnerFromNetwork(fraudAlert.partnerId);
- }
-
return NextResponse.json({ success: true });
},
{
diff --git a/apps/web/app/(ee)/api/admin/partners/[partnerId]/flag-fraud/route.ts b/apps/web/app/(ee)/api/admin/partners/[partnerId]/flag-fraud/route.ts
index 2be103e95b..55d63ca9b2 100644
--- a/apps/web/app/(ee)/api/admin/partners/[partnerId]/flag-fraud/route.ts
+++ b/apps/web/app/(ee)/api/admin/partners/[partnerId]/flag-fraud/route.ts
@@ -83,6 +83,11 @@ export const POST = withAdmin(
);
}
+ // Ban before the alert is created, so that a failed ban can be retried
+ if (banFromNetwork) {
+ await banPartnerFromNetwork(partnerId);
+ }
+
await prisma.fraudAlert.create({
data: {
partnerId,
@@ -96,10 +101,6 @@ export const POST = withAdmin(
},
});
- if (banFromNetwork) {
- await banPartnerFromNetwork(partnerId);
- }
-
return NextResponse.json({
success: true,
alertedProgramsCount,