Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Rearrange partners cron workflows (#3361)

Steven Tey3167cda0a096
diff --git a/apps/web/app/(ee)/api/cron/auto-approve-partner/route.ts b/apps/web/app/(ee)/api/cron/auto-approve-partner/route.ts
index e4b2d736a1..8adb196799 100644
--- a/apps/web/app/(ee)/api/cron/auto-approve-partner/route.ts
+++ b/apps/web/app/(ee)/api/cron/auto-approve-partner/route.ts
@@ -1,109 +1,4 @@
-import { getPartnerApplicationRisks } from "@/lib/api/fraud/get-partner-application-risks";
-import { withCron } from "@/lib/cron/with-cron";
-import { approvePartnerEnrollment } from "@/lib/partners/approve-partner-enrollment";
-import { getPlanCapabilities } from "@/lib/plan-capabilities";
-import { prisma } from "@dub/prisma";
-import * as z from "zod/v4";
-import { logAndRespond } from "../utils";
-
export const dynamic = "force-dynamic";
-const schema = z.object({
- programId: z.string(),
- partnerId: z.string(),
-});
-
-// POST /api/cron/auto-approve-partner
-// This route is used to auto-approve a partner enrolled in a program
-export const POST = withCron(async ({ rawBody }) => {
- const { programId, partnerId } = schema.parse(JSON.parse(rawBody));
-
- const programEnrollment = await prisma.programEnrollment.findUnique({
- where: {
- partnerId_programId: {
- partnerId,
- programId,
- },
- },
- include: {
- partnerGroup: true,
- partner: {
- include: {
- platforms: true,
- },
- },
- },
- });
-
- if (!programEnrollment) {
- return logAndRespond(
- `Partner ${partnerId} not found in program ${programId}. Skipping auto-approval.`,
- );
- }
-
- const group = programEnrollment.partnerGroup;
-
- if (!group) {
- return logAndRespond(
- `Group not found for partner ${partnerId} in program ${programId}. Skipping auto-approval.`,
- );
- }
-
- if (!group.autoApprovePartnersEnabledAt) {
- return logAndRespond(
- `Group ${group.id} does not have auto-approval enabled. Skipping auto-approval.`,
- );
- }
-
- if (programEnrollment.status !== "pending") {
- return logAndRespond(
- `${partnerId} is in ${programEnrollment.status} status. Skipping auto-approval.`,
- );
- }
-
- // Check if the workspace plan has fraud event management capabilities
- // If enabled, we'll evaluate risk signals before auto-approving
- const program = await prisma.program.findUniqueOrThrow({
- where: {
- id: programId,
- },
- include: {
- workspace: {
- include: {
- users: {
- where: {
- role: "owner",
- },
- take: 1,
- },
- },
- },
- },
- });
-
- const { canManageFraudEvents } = getPlanCapabilities(program.workspace.plan);
-
- if (canManageFraudEvents) {
- const { riskSeverity } = await getPartnerApplicationRisks({
- program,
- partner: programEnrollment.partner,
- });
-
- if (riskSeverity === "high") {
- return logAndRespond(
- `Partner ${partnerId} has high risk. Skipping auto-approval.`,
- );
- }
- }
-
- await approvePartnerEnrollment({
- programId,
- partnerId,
- userId: program.workspace.users[0].userId,
- groupId: programEnrollment.groupId,
- });
-
- return logAndRespond(
- `Successfully auto-approved partner ${partnerId} in program ${programId}.`,
- );
-});
+// TODO: Remove in 5 mins
+export { POST } from "../partners/auto-approve/route";
diff --git a/apps/web/app/(ee)/api/cron/partners/auto-approve/route.ts b/apps/web/app/(ee)/api/cron/partners/auto-approve/route.ts
new file mode 100644
index 0000000000..a2f1d672b3
--- /dev/null
+++ b/apps/web/app/(ee)/api/cron/partners/auto-approve/route.ts
@@ -0,0 +1,109 @@
+import { getPartnerApplicationRisks } from "@/lib/api/fraud/get-partner-application-risks";
+import { withCron } from "@/lib/cron/with-cron";
+import { approvePartnerEnrollment } from "@/lib/partners/approve-partner-enrollment";
+import { getPlanCapabilities } from "@/lib/plan-capabilities";
+import { prisma } from "@dub/prisma";
+import * as z from "zod/v4";
+import { logAndRespond } from "../../utils";
+
+export const dynamic = "force-dynamic";
+
+const schema = z.object({
+ programId: z.string(),
+ partnerId: z.string(),
+});
+
+// POST /api/cron/partners/auto-approve
+// This route is used to auto-approve a partner enrolled in a program
+export const POST = withCron(async ({ rawBody }) => {
+ const { programId, partnerId } = schema.parse(JSON.parse(rawBody));
+
+ const programEnrollment = await prisma.programEnrollment.findUnique({
+ where: {
+ partnerId_programId: {
+ partnerId,
+ programId,
+ },
+ },
+ include: {
+ partnerGroup: true,
+ partner: {
+ include: {
+ platforms: true,
+ },
+ },
+ },
+ });
+
+ if (!programEnrollment) {
+ return logAndRespond(
+ `Partner ${partnerId} not found in program ${programId}. Skipping auto-approval.`,
+ );
+ }
+
+ const group = programEnrollment.partnerGroup;
+
+ if (!group) {
+ return logAndRespond(
+ `Group not found for partner ${partnerId} in program ${programId}. Skipping auto-approval.`,
+ );
+ }
+
+ if (!group.autoApprovePartnersEnabledAt) {
+ return logAndRespond(
+ `Group ${group.id} does not have auto-approval enabled. Skipping auto-approval.`,
+ );
+ }
+
+ if (programEnrollment.status !== "pending") {
+ return logAndRespond(
+ `${partnerId} is in ${programEnrollment.status} status. Skipping auto-approval.`,
+ );
+ }
+
+ // Check if the workspace plan has fraud event management capabilities
+ // If enabled, we'll evaluate risk signals before auto-approving
+ const program = await prisma.program.findUniqueOrThrow({
+ where: {
+ id: programId,
+ },
+ include: {
+ workspace: {
+ include: {
+ users: {
+ where: {
+ role: "owner",
+ },
+ take: 1,
+ },
+ },
+ },
+ },
+ });
+
+ const { canManageFraudEvents } = getPlanCapabilities(program.workspace.plan);
+
+ if (canManageFraudEvents) {
+ const { riskSeverity } = await getPartnerApplicationRisks({
+ program,
+ partner: programEnrollment.partner,
+ });
+
+ if (riskSeverity === "high") {
+ return logAndRespond(
+ `Partner ${partnerId} has high risk. Skipping auto-approval.`,
+ );
+ }
+ }
+
+ await approvePartnerEnrollment({
+ programId,
+ partnerId,
+ userId: program.workspace.users[0].userId,
+ groupId: programEnrollment.groupId,
+ });
+
+ return logAndRespond(
+ `Successfully auto-approved partner ${partnerId} in program ${programId}.`,
+ );
+});
diff --git a/apps/web/app/(ee)/api/cron/partners/ban/process/cancel-commissions.ts b/apps/web/app/(ee)/api/cron/partners/ban/cancel-commissions.ts
similarity index 100%
rename from apps/web/app/(ee)/api/cron/partners/ban/process/cancel-commissions.ts
rename to apps/web/app/(ee)/api/cron/partners/ban/cancel-commissions.ts
diff --git a/apps/web/app/(ee)/api/cron/partners/ban/process/route.ts b/apps/web/app/(ee)/api/cron/partners/ban/route.ts
similarity index 95%
rename from apps/web/app/(ee)/api/cron/partners/ban/process/route.ts
rename to apps/web/app/(ee)/api/cron/partners/ban/route.ts
index ec4a21ad71..5d18da0e5f 100644
--- a/apps/web/app/(ee)/api/cron/partners/ban/process/route.ts
+++ b/apps/web/app/(ee)/api/cron/partners/ban/route.ts
@@ -15,7 +15,7 @@ import PartnerBanned from "@dub/email/templates/partner-banned";
import { prisma } from "@dub/prisma";
import { FraudRuleType } from "@dub/prisma/client";
import * as z from "zod/v4";
-import { logAndRespond } from "../../../utils";
+import { logAndRespond } from "../../utils";
import { cancelCommissions } from "./cancel-commissions";
const schema = z.object({
@@ -23,7 +23,7 @@ const schema = z.object({
partnerId: z.string(),
});
-// POST /api/cron/partners/ban/process - do the post-ban processing
+// POST /api/cron/partners/ban - handle all side effects of banning a partner
export const POST = withCron(async ({ rawBody }) => {
const { programId, partnerId } = schema.parse(JSON.parse(rawBody));
@@ -78,6 +78,9 @@ export const POST = withCron(async ({ rawBody }) => {
},
data: {
status: "rejected",
+ rejectionReason: "other",
+ rejectionNote:
+ "Rejected automatically because the partner was banned.",
},
}),
diff --git a/apps/web/app/(ee)/api/cron/merge-partner-accounts/route.ts b/apps/web/app/(ee)/api/cron/partners/merge-accounts/route.ts
similarity index 99%
rename from apps/web/app/(ee)/api/cron/merge-partner-accounts/route.ts
rename to apps/web/app/(ee)/api/cron/partners/merge-accounts/route.ts
index 6858c371b6..c8eef8114a 100644
--- a/apps/web/app/(ee)/api/cron/merge-partner-accounts/route.ts
+++ b/apps/web/app/(ee)/api/cron/partners/merge-accounts/route.ts
@@ -24,7 +24,7 @@ const schema = z.object({
const CACHE_KEY_PREFIX = "merge-partner-accounts";
-// POST /api/cron/merge-partner-accounts
+// POST /api/cron/partners/merge-accounts
// This route is used to merge a partner account into another account
export async function POST(req: Request) {
let userId: string | null = null;
diff --git a/apps/web/lib/actions/partners/ban-partner.ts b/apps/web/lib/actions/partners/ban-partner.ts
index 0197495c45..0dc336c9ff 100644
--- a/apps/web/lib/actions/partners/ban-partner.ts
+++ b/apps/web/lib/actions/partners/ban-partner.ts
@@ -122,7 +122,7 @@ export const banPartner = async ({
}),
queue.enqueueJSON({
- url: `${APP_DOMAIN_WITH_NGROK}/api/cron/partners/ban/process`,
+ url: `${APP_DOMAIN_WITH_NGROK}/api/cron/partners/ban`,
deduplicationId: `ban-${programId}-${partnerId}`,
method: "POST",
body: {
diff --git a/apps/web/lib/actions/partners/bulk-ban-partners.ts b/apps/web/lib/actions/partners/bulk-ban-partners.ts
index 4ebb967ed0..0ee0d972d3 100644
--- a/apps/web/lib/actions/partners/bulk-ban-partners.ts
+++ b/apps/web/lib/actions/partners/bulk-ban-partners.ts
@@ -106,7 +106,7 @@ export const bulkBanPartnersAction = authActionClient
enqueueBatchJobs(
programEnrollments.map(({ programId, partnerId }) => ({
queueName: "ban-partner",
- url: `${APP_DOMAIN_WITH_NGROK}/api/cron/partners/ban/process`,
+ url: `${APP_DOMAIN_WITH_NGROK}/api/cron/partners/ban`,
deduplicationId: `ban-${programId}-${partnerId}`,
body: {
programId,
diff --git a/apps/web/lib/actions/partners/create-program-application.ts b/apps/web/lib/actions/partners/create-program-application.ts
index 49225e71a2..07fbbd4d87 100644
--- a/apps/web/lib/actions/partners/create-program-application.ts
+++ b/apps/web/lib/actions/partners/create-program-application.ts
@@ -262,7 +262,7 @@ async function createApplicationAndEnrollment({
// Auto-approve the partner if the group has auto-approval enabled
group.autoApprovePartnersEnabledAt
? qstash.publishJSON({
- url: `${APP_DOMAIN_WITH_NGROK}/api/cron/auto-approve-partner`,
+ url: `${APP_DOMAIN_WITH_NGROK}/api/cron/partners/auto-approve`,
delay: 5 * 60,
body: {
programId: program.id,
diff --git a/apps/web/lib/actions/partners/merge-partner-accounts.ts b/apps/web/lib/actions/partners/merge-partner-accounts.ts
index 61d545fb1a..5217f0e618 100644
--- a/apps/web/lib/actions/partners/merge-partner-accounts.ts
+++ b/apps/web/lib/actions/partners/merge-partner-accounts.ts
@@ -348,7 +348,7 @@ const mergeAccounts = async ({ userId }: { userId: string }) => {
const { sourceEmail, targetEmail } = accounts;
await qstash.publishJSON({
- url: `${APP_DOMAIN_WITH_NGROK}/api/cron/merge-partner-accounts`,
+ url: `${APP_DOMAIN_WITH_NGROK}/api/cron/partners/merge-accounts`,
body: {
userId,
sourceEmail,
diff --git a/apps/web/lib/partners/complete-program-applications.ts b/apps/web/lib/partners/complete-program-applications.ts
index 0737668105..7d77cfce82 100644
--- a/apps/web/lib/partners/complete-program-applications.ts
+++ b/apps/web/lib/partners/complete-program-applications.ts
@@ -197,7 +197,7 @@ export async function completeProgramApplications(userEmail: string) {
// Auto-approve the partner if the group has auto-approval enabled
group?.autoApprovePartnersEnabledAt
? qstash.publishJSON({
- url: `${APP_DOMAIN_WITH_NGROK}/api/cron/auto-approve-partner`,
+ url: `${APP_DOMAIN_WITH_NGROK}/api/cron/partners/auto-approve`,
delay: 5 * 60,
body: {
programId: program.id,