The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Improve delete default links (#3938)
Steven Tey32e247bfa520
diff --git a/apps/web/app/(ee)/api/cron/groups/delete-default-links/route.ts b/apps/web/app/(ee)/api/cron/groups/delete-default-links/route.tsnew file mode 100644index 0000000000..d0ce8451ae--- /dev/null+++ b/apps/web/app/(ee)/api/cron/groups/delete-default-links/route.ts@@ -0,0 +1,126 @@+import { handleAndReturnErrorResponse } from "@/lib/api/errors";+import { bulkDeleteLinks } from "@/lib/api/links/bulk-delete-links";+import { includeProgramEnrollment } from "@/lib/api/links/include-program-enrollment";+import { includeTags } from "@/lib/api/links/include-tags";+import { qstash } from "@/lib/cron";+import { verifyQstashSignature } from "@/lib/cron/verify-qstash";+import { prisma } from "@dub/prisma";+import { APP_DOMAIN_WITH_NGROK, log, prettyPrint } from "@dub/utils";+import * as z from "zod/v4";+import { logAndRespond } from "../../utils";+export const dynamic = "force-dynamic";++const MAX_LINKS_PER_BATCH = 100;++const schema = z.object({+ partnerGroupDefaultLinkId: z.string(),+});++// POST /api/cron/groups/delete-default-links – delete a default link for a group+export async function POST(req: Request) {+ try {+ const rawBody = await req.text();+ await verifyQstashSignature({ req, rawBody });++ const { partnerGroupDefaultLinkId } = schema.parse(JSON.parse(rawBody));++ const linksToDelete = await prisma.link.findMany({+ where: {+ partnerGroupDefaultLinkId,+ clicks: 0, // only delete links that have no clicks / activity+ },+ take: MAX_LINKS_PER_BATCH,+ include: {+ ...includeTags,+ ...includeProgramEnrollment,+ },+ });++ if (linksToDelete.length > 0) {+ const deletedLinks = await prisma.link.deleteMany({+ where: {+ id: {+ in: linksToDelete.map(({ id }) => id),+ },+ },+ });++ console.log(+ `Deleted ${deletedLinks.count} links for partner group default link ${partnerGroupDefaultLinkId}.`,+ );++ await bulkDeleteLinks(linksToDelete);++ // if linksToDelete is less than MAX_LINKS_PER_BATCH, we've deleted all the links+ if (linksToDelete.length < MAX_LINKS_PER_BATCH) {+ return logAndRespond(+ `Finished deleting all default links for partner group default link ${partnerGroupDefaultLinkId}.`,+ );+ }++ const deleteDefaultLinksJob = await qstash.publishJSON({+ url: `${APP_DOMAIN_WITH_NGROK}/api/cron/groups/delete-default-links`,+ body: {+ partnerGroupDefaultLinkId,+ },+ });++ return logAndRespond(+ `Scheduled delete-default-links job for partner group default link ${partnerGroupDefaultLinkId}: ${prettyPrint(deleteDefaultLinksJob)}`,+ );+ }++ // no more links left, remove the partner group default link id from any remaining links (with activity)+ let batch = 0;+ const BATCH_LIMIT = 20;+ while (batch < BATCH_LIMIT) {+ const updatedLinks = await prisma.link.updateMany({+ where: {+ partnerGroupDefaultLinkId,+ },+ data: {+ partnerGroupDefaultLinkId: null,+ },+ limit: MAX_LINKS_PER_BATCH,+ });++ if (updatedLinks.count === 0) {+ break;+ }++ batch++;+ }++ if (batch === BATCH_LIMIT) {+ // if batch limit reached, there might be more links to update, so schedule another job to delete the remaining links+ const deleteDefaultLinksJob = await qstash.publishJSON({+ url: `${APP_DOMAIN_WITH_NGROK}/api/cron/groups/delete-default-links`,+ body: {+ partnerGroupDefaultLinkId,+ },+ });++ return logAndRespond(+ `Scheduled delete-default-links job for partner group default link ${partnerGroupDefaultLinkId}: ${prettyPrint(deleteDefaultLinksJob)}`,+ );+ }++ // finally, delete the partner group default link+ await prisma.partnerGroupDefaultLink.delete({+ where: {+ id: partnerGroupDefaultLinkId,+ },+ });++ return logAndRespond(+ `Finished deleting all default links for partner group default link ${partnerGroupDefaultLinkId}.`,+ );+ } catch (error) {+ await log({+ message: `Error deleting default links: ${error.message}.`,+ type: "errors",+ });++ return handleAndReturnErrorResponse(error);+ }+}diff --git a/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/default-links/[defaultLinkId]/route.ts b/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/default-links/[defaultLinkId]/route.tsindex 46a80404ab..9c7717d5f3 100644--- a/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/default-links/[defaultLinkId]/route.ts+++ b/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/default-links/[defaultLinkId]/route.ts@@ -10,7 +10,11 @@ import {PartnerGroupDefaultLinkSchema,} from "@/lib/zod/schemas/groups";import { prisma } from "@dub/prisma";-import { APP_DOMAIN_WITH_NGROK, constructURLFromUTMParams } from "@dub/utils";+import {+ APP_DOMAIN_WITH_NGROK,+ constructURLFromUTMParams,+ prettyPrint,+} from "@dub/utils";import { waitUntil } from "@vercel/functions";import { NextResponse } from "next/server";@@ -192,14 +196,32 @@ export const DELETE = withWorkspace(});}- await prisma.partnerGroupDefaultLink.delete({+ const defaultLinkId = group.partnerGroupDefaultLinks[0].id;++ const deleteDefaultLinksJob = await qstash.publishJSON({+ url: `${APP_DOMAIN_WITH_NGROK}/api/cron/groups/delete-default-links`,+ body: {+ partnerGroupDefaultLinkId: defaultLinkId,+ },+ });++ console.log(+ `Scheduled delete-default-links job for partner group default link ${defaultLinkId}: ${prettyPrint(deleteDefaultLinksJob)}`,+ );++ // soft delete the default link by setting the groupId to null+ await prisma.partnerGroupDefaultLink.update({where: {- id: group.partnerGroupDefaultLinks[0].id,+ id: defaultLinkId,+ },+ data: {+ groupId: null,},});+ console.log(`Soft deleted default link ${defaultLinkId}`);return NextResponse.json({- id: group.partnerGroupDefaultLinks[0].id,+ id: defaultLinkId,});},{diff --git a/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/default-links/route.ts b/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/default-links/route.tsindex aa8723f8ed..dfbc9b017e 100644--- a/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/default-links/route.ts+++ b/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/default-links/route.ts@@ -32,7 +32,7 @@ export const GET = withWorkspace(groupId: group.id,},orderBy: {- createdAt: "desc",+ createdAt: "asc",},});diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/links/group-default-links.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/links/group-default-links.tsxindex d796a24e0f..232c5423de 100644--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/links/group-default-links.tsx+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/links/group-default-links.tsx@@ -8,9 +8,15 @@ import { PartnerGroupDefaultLink } from "@/lib/types";import { MAX_DEFAULT_LINKS_PER_GROUP } from "@/lib/zod/schemas/groups";import { useConfirmModal } from "@/ui/modals/confirm-modal";import { ThreeDots } from "@/ui/shared/icons";-import { Button, Hyperlink, InfoTooltip, Popover } from "@dub/ui";+import {+ Button,+ Hyperlink,+ InfoTooltip,+ Popover,+ TimestampTooltip,+} from "@dub/ui";import { PenWriting, Trash } from "@dub/ui/icons";-import { cn, getPrettyUrl, getUrlWithoutUTMParams } from "@dub/utils";+import { cn, getPrettyUrl, getUrlWithoutUTMParams, timeAgo } from "@dub/utils";import { useState } from "react";import { toast } from "sonner";import { mutate } from "swr";@@ -132,8 +138,9 @@ function DefaultLinkPreview({ link }: { link: PartnerGroupDefaultLink }) {<strong>{getPrettyUrl(getUrlWithoutUTMParams(link.url))}</strong>?<br /><br />- This won't affect any existing partner links, but if you recreate the- link, it could result in duplicate links for partners in this group.+ This won't affect any existing partner links that have traffic on them,+ but if you recreate the link, it could result in duplicate links for+ partners in this group.<br /><br />If you want to change the default link, try editing it instead.@@ -156,7 +163,16 @@ function DefaultLinkPreview({ link }: { link: PartnerGroupDefaultLink }) {/></div>- <div className="absolute right-4 top-1/2 -translate-y-1/2">+ <div className="absolute right-4 top-1/2 flex -translate-y-1/2 items-center gap-2">+ <TimestampTooltip+ timestamp={link.createdAt}+ rows={["local", "utc", "unix"]}+ delayDuration={150}+ >+ <span className="text-xs text-neutral-400">+ Created {timeAgo(link.createdAt, { withAgo: true })}+ </span>+ </TimestampTooltip><Popovercontent={<div className="grid w-48 grid-cols-1 gap-px p-2">diff --git a/apps/web/lib/zod/schemas/groups.ts b/apps/web/lib/zod/schemas/groups.tsindex dfa2a5142f..07c1d4483f 100644--- a/apps/web/lib/zod/schemas/groups.ts+++ b/apps/web/lib/zod/schemas/groups.ts@@ -159,6 +159,7 @@ export const PartnerGroupDefaultLinkSchema = z.object({id: z.string(),domain: z.string(),url: parseUrlSchema,+ createdAt: z.coerce.date(),});export const getGroupsQuerySchema = zdiff --git a/packages/prisma/schema/group.prisma b/packages/prisma/schema/group.prismaindex e9e4c7c255..a2658c159b 100644--- a/packages/prisma/schema/group.prisma+++ b/packages/prisma/schema/group.prisma@@ -52,14 +52,14 @@ model PartnerGroup {model PartnerGroupDefaultLink {id String @id @default(cuid())programId String- groupId String+ groupId String? // can be null for soft-deleted default linksdomain Stringurl StringcreatedAt DateTime @default(now())updatedAt DateTime @updatedAt- program Program @relation(fields: [programId], references: [id], onDelete: Cascade)- partnerGroup PartnerGroup @relation(fields: [groupId], references: [id], onDelete: Cascade)+ program Program @relation(fields: [programId], references: [id], onDelete: Cascade)+ partnerGroup PartnerGroup? @relation(fields: [groupId], references: [id], onDelete: Cascade)links Link[]@@unique([groupId, url])