Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Inline rarely used null-amount helpers in hide-partner-revenue.

Kiran K35abbf2c5374
diff --git a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/[customerId]/route.ts b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/[customerId]/route.ts
index 37d19c0db1..f15a60bd5c 100644
--- a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/[customerId]/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/[customerId]/route.ts
@@ -10,10 +10,7 @@ import {
LARGE_PROGRAM_MIN_TOTAL_COMMISSIONS_CENTS,
} from "@/lib/constants/partner-profile";
import { generateRandomName } from "@/lib/names";
-import {
- nullPartnerEventRevenue,
- nullSaleAmount,
-} from "@/lib/partners/hide-partner-revenue";
+import { nullPartnerEventRevenue } from "@/lib/partners/hide-partner-revenue";
import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import { prisma } from "@/lib/prisma";
import { PartnerProfileCustomerSchema } from "@/lib/zod/schemas/partner-profile";
@@ -141,7 +138,8 @@ export const GET = withPartnerProfile(async ({ partner, params }) => {
PartnerProfileCustomerSchema.extend({
...(customerDataSharingEnabledAt && { name: z.string().nullish() }),
}).parse({
- ...(ltvExcluded ? nullSaleAmount(transformed) : transformed),
+ ...transformed,
+ ...(ltvExcluded && { saleAmount: null }),
activity: {
...customer,
events: hidePartnerRevenue
diff --git a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/route.ts b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/route.ts
index 8885704a78..cbb8753de8 100644
--- a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/route.ts
@@ -9,7 +9,6 @@ import {
LARGE_PROGRAM_MIN_TOTAL_COMMISSIONS_CENTS,
} from "@/lib/constants/partner-profile";
import { generateRandomName } from "@/lib/names";
-import { nullSaleAmount } from "@/lib/partners/hide-partner-revenue";
import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import { prisma, sanitizeFullTextSearch } from "@/lib/prisma";
import {
@@ -133,7 +132,8 @@ export const GET = withPartnerProfile(
return PartnerProfileCustomerSchema.extend({
...(customerDataSharingEnabledAt && { name: z.string().nullish() }),
}).parse({
- ...(ltvExcluded ? nullSaleAmount(transformed) : transformed),
+ ...transformed,
+ ...(ltvExcluded && { saleAmount: null }),
activity: {
...customer,
events: [],
diff --git a/apps/web/lib/api/partner-profile/get-earnings-for-partner.ts b/apps/web/lib/api/partner-profile/get-earnings-for-partner.ts
index baf66ef321..44b03efbed 100644
--- a/apps/web/lib/api/partner-profile/get-earnings-for-partner.ts
+++ b/apps/web/lib/api/partner-profile/get-earnings-for-partner.ts
@@ -2,7 +2,6 @@ import { getStartEndDates } from "@/lib/analytics/utils/get-start-end-dates";
import { DubApiError } from "@/lib/api/errors";
import { buildPaginationQuery } from "@/lib/api/pagination";
import { generateRandomName } from "@/lib/names";
-import { nullAmount } from "@/lib/partners/hide-partner-revenue";
import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import { prisma } from "@/lib/prisma";
import {
@@ -199,7 +198,7 @@ export async function getEarningsForPartner(
};
return isPartnerRevenueHidden(programEnrollment.partnerGroup)
- ? nullAmount(earning)
+ ? { ...earning, amount: null }
: earning;
}),
);
diff --git a/apps/web/lib/partners/hide-partner-revenue.ts b/apps/web/lib/partners/hide-partner-revenue.ts
index 8653ceb9ca..cddc6e9c78 100644
--- a/apps/web/lib/partners/hide-partner-revenue.ts
+++ b/apps/web/lib/partners/hide-partner-revenue.ts
@@ -3,22 +3,12 @@ import {
type PartnerRevenueVisibilityGroup,
} from "./is-partner-revenue-hidden";
-/** Set `saleAmount` to null without mutating the original. */
-export function nullSaleAmount<T extends object>(data: T): T {
- return { ...data, saleAmount: null };
-}
-
-/** Set `amount` to null without mutating the original. */
-export function nullAmount<T extends object>(data: T): T {
- return { ...data, amount: null };
-}
-
/** Null `saleAmount` when revenue data sharing is disabled. */
export function hidePartnerSaleAmount<T extends object>(
data: T,
group: PartnerRevenueVisibilityGroup,
): T {
- return isPartnerRevenueHidden(group) ? nullSaleAmount(data) : data;
+ return isPartnerRevenueHidden(group) ? { ...data, saleAmount: null } : data;
}
/** Null `totalSaleAmount` when revenue data sharing is disabled. */
@@ -52,7 +42,7 @@ export function nullPartnerEventRevenue<T extends object>(event: T): T {
}
if (next.link && typeof next.link === "object") {
- next.link = nullSaleAmount(next.link);
+ next.link = { ...next.link, saleAmount: null };
}
return next;
@@ -63,13 +53,13 @@ export function nullAnalyticsSaleAmounts<T>(data: T): T {
if (Array.isArray(data)) {
return data.map((row) =>
row && typeof row === "object" && "saleAmount" in row
- ? nullSaleAmount(row)
+ ? { ...row, saleAmount: null }
: row,
) as T;
}
if (data && typeof data === "object" && "saleAmount" in data) {
- return nullSaleAmount(data);
+ return { ...data, saleAmount: null };
}
return data;