The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Delete discount code and link atomically, defer provider cleanup
Kiran K39ea716f745d
diff --git a/apps/web/lib/api/links/delete-link.ts b/apps/web/lib/api/links/delete-link.tsindex 80a7ad8633..460645fcaf 100644--- a/apps/web/lib/api/links/delete-link.ts+++ b/apps/web/lib/api/links/delete-link.ts@@ -1,9 +1,9 @@+import { enqueueDeleteDiscountCode } from "@/lib/discounts/delete-discount-code";import { prisma } from "@/lib/prisma";import { storage } from "@/lib/storage";import { recordLink } from "@/lib/tinybird";import { R2_URL } from "@dub/utils";import { waitUntil } from "@vercel/functions";-import { deleteDiscountCodes } from "../../discounts/delete-discount-code";import { linkCache } from "./cache";import { includeProgramEnrollment } from "./include-program-enrollment";import { includeTags } from "./include-tags";@@ -29,17 +29,23 @@ export async function deleteLink(linkId: string) {},});- // DiscountCode.linkId is a required relation (onDelete: Restrict),- // so the discount code must be deleted before the link- if (link.discountCode) {- await deleteDiscountCodes([link.discountCode]);- }+ await prisma.$transaction([+ ...(link.discountCode+ ? [+ prisma.discountCode.delete({+ where: {+ id: link.discountCode.id,+ },+ }),+ ]+ : []),- await prisma.link.delete({- where: {- id: linkId,- },- });+ prisma.link.delete({+ where: {+ id: linkId,+ },+ }),+ ]);waitUntil(Promise.allSettled([@@ -65,6 +71,9 @@ export async function deleteLink(linkId: string) {},},}),++ link.discountCode?.discount &&+ enqueueDeleteDiscountCode([link.discountCode]),]),);diff --git a/apps/web/lib/discounts/delete-discount-code.ts b/apps/web/lib/discounts/delete-discount-code.tsindex 33c0232b36..d001c8d57f 100644--- a/apps/web/lib/discounts/delete-discount-code.ts+++ b/apps/web/lib/discounts/delete-discount-code.ts@@ -10,6 +10,13 @@ type DeleteDiscountCodesParams = Pick<discount: Pick<Discount, "provider"> | null;};+type EnqueueDeleteDiscountCodeParams = Pick<+ DiscountCode,+ "code" | "programId"+> & {+ discount: Pick<Discount, "provider"> | null;+};+// Triggered in the following cases:// 1. When a discount is deleted// 2. When a link is deleted that has a discount code associated with it@@ -61,19 +68,22 @@ export async function deleteDiscountCodes();}- // Only enqueue external-provider cleanup for codes whose provider is known.- // Orphaned codes (discount relation is null) still get deleted locally above- // but we can't tell which external provider to clean up, so we skip them.+ await enqueueDeleteDiscountCode(discountCodes);+}++// Only enqueue external-provider cleanup for codes whose provider is known.+// Orphaned codes (discount relation is null) still get deleted locally above+// but we can't tell which external provider to clean up, so we skip them.+export async function enqueueDeleteDiscountCode(+ discountCodes: EnqueueDeleteDiscountCodeParams[],+) {const codesWithProvider = discountCodes.filter((dc): dc is typeof dc & { discount: Pick<Discount, "provider"> } =>dc.discount != null,);- const orphanedCount = discountCodes.length - codesWithProvider.length;- if (orphanedCount > 0) {- console.warn(- `[deleteDiscountCodes] Skipping external provider cleanup for ${orphanedCount} orphaned discount code(s) with no discount relation.`,- );+ if (codesWithProvider.length === 0) {+ return;}// Queue the job to remove the discount codes from provider@@ -81,14 +91,14 @@ export async function deleteDiscountCodes(for (const chunkOfCodes of chunks) {await enqueueBatchJobs(- chunkOfCodes.map((discountCode) => ({+ chunkOfCodes.map(({ code, programId, discount }) => ({url: `${APP_DOMAIN_WITH_NGROK}/api/cron/discount-codes/disable`,method: "POST",queueName: "delete-discount-code",body: {- code: discountCode.code,- programId: discountCode.programId,- provider: discountCode.discount.provider,+ code,+ programId,+ provider: discount.provider,},})),);