Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Remove duplicate timeout checks from partner analytics routes

Rafi3b0f1e2b0c36
diff --git a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/route.ts b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/route.ts
index bd4945c79e..442fe0c2ba 100644
--- a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/route.ts
@@ -9,7 +9,7 @@ import {
MAX_PARTNER_LINKS_FOR_LOCAL_FILTERING,
} from "@/lib/constants/partner-profile";
import { partnerProfileAnalyticsQuerySchema } from "@/lib/zod/schemas/partner-profile";
-import { parseFilterValue, serializeError, toCentsNumber } from "@dub/utils";
+import { parseFilterValue, toCentsNumber } from "@dub/utils";
import { NextResponse } from "next/server";
// GET /api/partner-profile/programs/[programId]/analytics – get analytics for a program enrollment link
@@ -81,34 +81,21 @@ export const GET = withPartnerProfile(
};
}
- try {
- const response = await getAnalytics({
- ...(LARGE_PROGRAM_IDS.includes(program.id) &&
- toCentsNumber(totalCommissions) <
- LARGE_PROGRAM_MIN_TOTAL_COMMISSIONS_CENTS
- ? { event: parsedParams.event, groupBy: "count", interval: "all" }
- : parsedParams),
- workspaceId: program.workspaceId,
- ...(parsedParams.linkId
- ? { linkId: parsedParams.linkId }
- : links.length > MAX_PARTNER_LINKS_FOR_LOCAL_FILTERING
- ? { partnerId: partner.id }
- : { linkId: parseFilterValue(links.map((link) => link.id)) }),
- dataAvailableFrom: program.startedAt ?? program.createdAt,
- });
-
- return NextResponse.json(response);
- } catch (error) {
- // Tinybird times out after 30s on heavy partner queries; return a 400
- // instead of 500 so the UI can show a retry hint.
- if (serializeError(error).includes("Timeout exceeded")) {
- throw new DubApiError({
- code: "bad_request",
- message: "Failed to fetch analytics. Refresh the page and try again.",
- });
- }
+ const response = await getAnalytics({
+ ...(LARGE_PROGRAM_IDS.includes(program.id) &&
+ toCentsNumber(totalCommissions) <
+ LARGE_PROGRAM_MIN_TOTAL_COMMISSIONS_CENTS
+ ? { event: parsedParams.event, groupBy: "count", interval: "all" }
+ : parsedParams),
+ workspaceId: program.workspaceId,
+ ...(parsedParams.linkId
+ ? { linkId: parsedParams.linkId }
+ : links.length > MAX_PARTNER_LINKS_FOR_LOCAL_FILTERING
+ ? { partnerId: partner.id }
+ : { linkId: parseFilterValue(links.map((link) => link.id)) }),
+ dataAvailableFrom: program.startedAt ?? program.createdAt,
+ });
- throw error;
- }
+ return NextResponse.json(response);
},
);
diff --git a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/route.ts b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/route.ts
index d19ec2cdad..af6281286f 100644
--- a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/route.ts
@@ -14,7 +14,7 @@ import {
PartnerProfileLinkSchema,
partnerProfileEventsQuerySchema,
} from "@/lib/zod/schemas/partner-profile";
-import { parseFilterValue, serializeError, toCentsNumber } from "@dub/utils";
+import { parseFilterValue, toCentsNumber } from "@dub/utils";
import { NextResponse } from "next/server";
import * as z from "zod/v4";
@@ -97,32 +97,17 @@ export const GET = withPartnerProfile(
};
}
- let events: Awaited<ReturnType<typeof getEvents>> = [];
-
- try {
- events = await getEvents({
- ...parsedParams,
- workspaceId: program.workspaceId,
- includeMetadata: false,
- ...(parsedParams.linkId
- ? { linkId: parsedParams.linkId }
- : links.length > MAX_PARTNER_LINKS_FOR_LOCAL_FILTERING
- ? { partnerId: partner.id }
- : { linkId: parseFilterValue(links.map((link) => link.id)) }),
- dataAvailableFrom: program.startedAt ?? program.createdAt,
- });
- } catch (error) {
- // Tinybird times out after 30s on heavy partner queries; return a 400
- // instead of 500 so the UI can show a retry hint.
- if (serializeError(error).includes("Timeout exceeded")) {
- throw new DubApiError({
- code: "bad_request",
- message: "Failed to fetch events. Refresh the page and try again.",
- });
- }
-
- throw error;
- }
+ const events = await getEvents({
+ ...parsedParams,
+ workspaceId: program.workspaceId,
+ includeMetadata: false,
+ ...(parsedParams.linkId
+ ? { linkId: parsedParams.linkId }
+ : links.length > MAX_PARTNER_LINKS_FOR_LOCAL_FILTERING
+ ? { partnerId: partner.id }
+ : { linkId: parseFilterValue(links.map((link) => link.id)) }),
+ dataAvailableFrom: program.startedAt ?? program.createdAt,
+ });
const response = events.map((event) => {
// don't return ip address for partner profile