The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Improve group delete API (preserve rewards if commissions exist) (#3692)
Steven Tey406db446526d
diff --git a/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/route.ts b/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/route.tsindex 18dbe2e02e..42cd05ada8 100644--- a/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/route.ts+++ b/apps/web/app/(ee)/api/groups/[groupIdOrSlug]/route.ts@@ -328,17 +328,36 @@ export const DELETE = withWorkspace(console.log(`Moved ${count} partners to the default group`);}+ let shouldDeleteGroupRewards = false;++ const groupRewardIds = [+ group.clickRewardId,+ group.leadRewardId,+ group.saleRewardId,+ ].filter(Boolean) as string[];++ if (groupRewardIds.length > 0) {+ const groupRewardCommissions = await prisma.commission.count({+ where: {+ programId,+ rewardId: {+ in: groupRewardIds,+ },+ },+ take: 100,+ });+ if (groupRewardCommissions === 0) {+ shouldDeleteGroupRewards = true;+ }+ }+const deletedGroup = await prisma.$transaction(async (tx) => {- // 1. Delete the group's rewards- if (group.clickRewardId || group.leadRewardId || group.saleRewardId) {+ // 1. Delete the group's rewards (if no commissions are associated with the rewards)+ if (shouldDeleteGroupRewards) {await tx.reward.deleteMany({where: {id: {- in: [- group.clickRewardId,- group.leadRewardId,- group.saleRewardId,- ].filter(Boolean) as string[],+ in: groupRewardIds,},},});