Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

add rate limiting to password-protected link verification

Pedro Ladeira44e3f5804e33
diff --git a/apps/web/app/password/[linkId]/action.ts b/apps/web/app/password/[linkId]/action.ts
index b4a51a1b84..5e5e79cb41 100644
--- a/apps/web/app/password/[linkId]/action.ts
+++ b/apps/web/app/password/[linkId]/action.ts
@@ -1,8 +1,15 @@
"use server";
+import { shouldApplyRateLimit } from "@/lib/api/environment";
+import { getIP } from "@/lib/api/utils/get-ip";
import { prismaEdge } from "@/lib/prisma/edge";
+import { ratelimit } from "@/lib/upstash";
import { cookies } from "next/headers";
+const IP_ATTEMPTS = 10;
+const LINK_ATTEMPTS = 100;
+const ATTEMPTS_WINDOW = "10 m";
+
export async function verifyPassword(_prevState: any, data: FormData) {
const linkId = data.get("linkId") as string;
const password = data.get("password") as string;
@@ -15,19 +22,38 @@ export async function verifyPassword(_prevState: any, data: FormData) {
if (!link) {
return { error: "Link not found" };
}
+
const { password: realPassword } = link;
const validPassword = password === realPassword;
if (validPassword) {
- // if the password is valid, set the cookie
(await cookies()).set(`dub_password_${link.id}`, password, {
path: `/${link.key}`,
httpOnly: true,
secure: true,
});
return true;
- } else {
- return { error: "Invalid password" };
}
+
+ if (shouldApplyRateLimit) {
+ const ipKey = `verify-password:${linkId}:${await getIP()}`;
+ const linkKey = `verify-password:${linkId}`;
+
+ const [ipLimit, linkLimit] = await Promise.all([
+ ratelimit(IP_ATTEMPTS, ATTEMPTS_WINDOW).getRemaining(ipKey),
+ ratelimit(LINK_ATTEMPTS, ATTEMPTS_WINDOW).getRemaining(linkKey),
+ ]);
+
+ if (ipLimit.remaining <= 0 || linkLimit.remaining <= 0) {
+ return { error: "Don't DDoS me pls 🥺" };
+ }
+
+ await Promise.all([
+ ratelimit(IP_ATTEMPTS, ATTEMPTS_WINDOW).limit(ipKey),
+ ratelimit(LINK_ATTEMPTS, ATTEMPTS_WINDOW).limit(linkKey),
+ ]);
+ }
+
+ return { error: "Invalid password" };
}
diff --git a/apps/web/app/password/[linkId]/form.tsx b/apps/web/app/password/[linkId]/form.tsx
index 6e20aa4350..76f1d71985 100644
--- a/apps/web/app/password/[linkId]/form.tsx
+++ b/apps/web/app/password/[linkId]/form.tsx
@@ -54,7 +54,9 @@ export default function PasswordForm() {
</div>
{state.error && (
<p className="mt-2 text-sm text-red-600" id="slug-error">
- Incorrect password
+ {state.error === "Invalid password"
+ ? "Incorrect password"
+ : state.error}
</p>
)}
</div>