Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

fix useMetatags

Steven Tey46aea4abe260
diff --git a/apps/web/app/(ee)/api/partners/analytics/route.ts b/apps/web/app/(ee)/api/partners/analytics/route.ts
index 819e03d5af..f3e0c79d8d 100644
--- a/apps/web/app/(ee)/api/partners/analytics/route.ts
+++ b/apps/web/app/(ee)/api/partners/analytics/route.ts
@@ -31,7 +31,7 @@ export const GET = withWorkspace(
throwIfNoPartnerIdOrTenantId({ partnerId, tenantId });
- const programEnrollment = await prisma.programEnrollment.findUniqueOrThrow({
+ const programEnrollment = await prisma.programEnrollment.findUnique({
where: partnerId
? {
partnerId_programId: {
@@ -55,6 +55,13 @@ export const GET = withWorkspace(
},
});
+ if (!programEnrollment) {
+ throw new DubApiError({
+ code: "not_found",
+ message: `The partner with ${partnerId ? "partnerId" : "tenantId"} ${partnerId ?? tenantId} is not enrolled in your program.`,
+ });
+ }
+
if (programEnrollment.program.workspaceId !== workspace.id) {
throw new DubApiError({
code: "not_found",
diff --git a/apps/web/ui/links/link-builder/use-metatags.ts b/apps/web/ui/links/link-builder/use-metatags.ts
index 675086839f..c10fc89de5 100644
--- a/apps/web/ui/links/link-builder/use-metatags.ts
+++ b/apps/web/ui/links/link-builder/use-metatags.ts
@@ -18,7 +18,7 @@ export function useMetatags({ enabled = true }: { enabled?: boolean } = {}) {
const { generatingMetatags, setGeneratingMetatags } = useLinkBuilderContext();
useEffect(() => {
- // no need to generate metatags if proxy is enabled, or if any of the metatags are set
+ // no need to generate metatags if proxy is enabled
if (proxy) {
setGeneratingMetatags(false);
return;
@@ -47,11 +47,12 @@ export function useMetatags({ enabled = true }: { enabled?: boolean } = {}) {
const results = await res.json();
const truncatedTitle = truncate(results.title, 120);
const truncatedDescription = truncate(results.description, 240);
- if (!title) {
+ if (truncatedTitle) {
setValue("title", truncatedTitle);
}
- if (!description) setValue("description", truncatedDescription);
- if (!image) setValue("image", results.image);
+ if (truncatedDescription)
+ setValue("description", truncatedDescription);
+ if (results.image) setValue("image", results.image);
}
// set timeout to prevent flickering
setTimeout(() => setGeneratingMetatags(false), 200);