Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Add permission checks for referral server actions (#3396)

Kiran K4858f9780d09
diff --git a/apps/web/lib/actions/referrals/mark-referral-closed-lost.ts b/apps/web/lib/actions/referrals/mark-referral-closed-lost.ts
index 975ffa8a17..ae48fdd9f4 100644
--- a/apps/web/lib/actions/referrals/mark-referral-closed-lost.ts
+++ b/apps/web/lib/actions/referrals/mark-referral-closed-lost.ts
@@ -9,6 +9,7 @@ import { prisma } from "@dub/prisma";
import { ReferralStatus } from "@dub/prisma/client";
import { waitUntil } from "@vercel/functions";
import { authActionClient } from "../safe-action";
+import { throwIfNoPermission } from "../throw-if-no-permission";
// Mark a partner referral as closed lost
export const markReferralClosedLostAction = authActionClient
@@ -17,6 +18,11 @@ export const markReferralClosedLostAction = authActionClient
const { workspace } = ctx;
const { referralId, notes } = parsedInput;
+ throwIfNoPermission({
+ role: workspace.role,
+ requiredRoles: ["owner", "member"],
+ });
+
const programId = getDefaultProgramIdOrThrow(workspace);
const partnerReferral = await getReferralOrThrow({
diff --git a/apps/web/lib/actions/referrals/mark-referral-closed-won.ts b/apps/web/lib/actions/referrals/mark-referral-closed-won.ts
index b811b99da3..b257a0fd9c 100644
--- a/apps/web/lib/actions/referrals/mark-referral-closed-won.ts
+++ b/apps/web/lib/actions/referrals/mark-referral-closed-won.ts
@@ -10,6 +10,7 @@ import { prisma } from "@dub/prisma";
import { ReferralStatus } from "@dub/prisma/client";
import { waitUntil } from "@vercel/functions";
import { authActionClient } from "../safe-action";
+import { throwIfNoPermission } from "../throw-if-no-permission";
// Mark a partner referral as closed won
export const markReferralClosedWonAction = authActionClient
@@ -18,6 +19,11 @@ export const markReferralClosedWonAction = authActionClient
const { workspace } = ctx;
const { referralId, saleAmount, stripeCustomerId, notes } = parsedInput;
+ throwIfNoPermission({
+ role: workspace.role,
+ requiredRoles: ["owner", "member"],
+ });
+
const programId = getDefaultProgramIdOrThrow(workspace);
const referral = await getReferralOrThrow({
diff --git a/apps/web/lib/actions/referrals/mark-referral-qualified.ts b/apps/web/lib/actions/referrals/mark-referral-qualified.ts
index 69f274e5cf..fddffbdd2e 100644
--- a/apps/web/lib/actions/referrals/mark-referral-qualified.ts
+++ b/apps/web/lib/actions/referrals/mark-referral-qualified.ts
@@ -13,6 +13,7 @@ import { ReferralStatus } from "@dub/prisma/client";
import { pick } from "@dub/utils";
import { waitUntil } from "@vercel/functions";
import { authActionClient } from "../safe-action";
+import { throwIfNoPermission } from "../throw-if-no-permission";
// Mark a partner referral as qualified
export const markReferralQualifiedAction = authActionClient
@@ -21,6 +22,11 @@ export const markReferralQualifiedAction = authActionClient
const { workspace } = ctx;
const { referralId, externalId, notes } = parsedInput;
+ throwIfNoPermission({
+ role: workspace.role,
+ requiredRoles: ["owner", "member"],
+ });
+
const programId = getDefaultProgramIdOrThrow(workspace);
const referral = await getReferralOrThrow({
diff --git a/apps/web/lib/actions/referrals/mark-referral-unqualified.ts b/apps/web/lib/actions/referrals/mark-referral-unqualified.ts
index 174ed30ae8..a63a73cad0 100644
--- a/apps/web/lib/actions/referrals/mark-referral-unqualified.ts
+++ b/apps/web/lib/actions/referrals/mark-referral-unqualified.ts
@@ -9,6 +9,7 @@ import { prisma } from "@dub/prisma";
import { ReferralStatus } from "@dub/prisma/client";
import { waitUntil } from "@vercel/functions";
import { authActionClient } from "../safe-action";
+import { throwIfNoPermission } from "../throw-if-no-permission";
// Mark a partner referral as unqualified
export const markReferralUnqualifiedAction = authActionClient
@@ -17,6 +18,11 @@ export const markReferralUnqualifiedAction = authActionClient
const { workspace } = ctx;
const { referralId, notes } = parsedInput;
+ throwIfNoPermission({
+ role: workspace.role,
+ requiredRoles: ["owner", "member"],
+ });
+
const programId = getDefaultProgramIdOrThrow(workspace);
const partnerReferral = await getReferralOrThrow({
diff --git a/apps/web/lib/actions/referrals/submit-referral.ts b/apps/web/lib/actions/referrals/submit-referral.ts
index 48e31f5eae..e1072034cf 100644
--- a/apps/web/lib/actions/referrals/submit-referral.ts
+++ b/apps/web/lib/actions/referrals/submit-referral.ts
@@ -3,6 +3,7 @@
import { createId } from "@/lib/api/create-id";
import { DubApiError } from "@/lib/api/errors";
import { getProgramEnrollmentOrThrow } from "@/lib/api/programs/get-program-enrollment-or-throw";
+import { notifyPartnerReferralSubmitted } from "@/lib/api/referrals/notify-partner-referral-submitted";
import { REFERRAL_FORM_REQUIRED_FIELD_KEYS } from "@/lib/referrals/constants";
import {
formFieldSchema,
@@ -10,7 +11,6 @@ import {
referralRequiredFieldsSchema,
} from "@/lib/zod/schemas/referral-form";
import { createPartnerReferralSchema } from "@/lib/zod/schemas/referrals";
-import { notifyPartnerReferralSubmitted } from "@/lib/api/referrals/notify-partner-referral-submitted";
import { prisma } from "@dub/prisma";
import { Prisma } from "@dub/prisma/client";
import { COUNTRIES } from "@dub/utils";