Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Block e and + in the lead form number inputs

Rafi486b822b40c1
diff --git a/apps/web/ui/submitted-leads/form-builder/lead-form-field-card.tsx b/apps/web/ui/submitted-leads/form-builder/lead-form-field-card.tsx
index 32bb578187..f20cc387d1 100644
--- a/apps/web/ui/submitted-leads/form-builder/lead-form-field-card.tsx
+++ b/apps/web/ui/submitted-leads/form-builder/lead-form-field-card.tsx
@@ -1,5 +1,6 @@
"use client";
+import { blockNonNumericKeys } from "@/ui/submitted-leads/form-fields/form-control";
import { Button, Combobox, Switch } from "@dub/ui";
import { GripDotsVertical, Plus, Trash } from "@dub/ui/icons";
import { cn } from "@dub/utils";
@@ -367,6 +368,7 @@ function OptionalNumberSetting({
{value !== null && (
<input
type="number"
+ onKeyDown={blockNonNumericKeys}
value={Number.isNaN(value) ? "" : value}
min={min}
onChange={(e) => onChange(e.target.valueAsNumber)}
diff --git a/apps/web/ui/submitted-leads/form-fields/form-control.tsx b/apps/web/ui/submitted-leads/form-fields/form-control.tsx
index 604f50a7dc..b890c8fd71 100644
--- a/apps/web/ui/submitted-leads/form-fields/form-control.tsx
+++ b/apps/web/ui/submitted-leads/form-fields/form-control.tsx
@@ -1,5 +1,12 @@
import { cn } from "@dub/utils";
-import { HTMLAttributes } from "react";
+import { HTMLAttributes, KeyboardEvent } from "react";
+
+// Number inputs accept "e" and "+" for scientific notation, which a lead form never needs
+export const blockNonNumericKeys = (e: KeyboardEvent<HTMLInputElement>) => {
+ if (["e", "E", "+"].includes(e.key)) {
+ e.preventDefault();
+ }
+};
export const requiredFieldRule = (required: boolean) =>
required ? "Please fill in this field" : false;
diff --git a/apps/web/ui/submitted-leads/form-fields/number-field.tsx b/apps/web/ui/submitted-leads/form-fields/number-field.tsx
index 0b9a2b311d..fbb7eb5704 100644
--- a/apps/web/ui/submitted-leads/form-fields/number-field.tsx
+++ b/apps/web/ui/submitted-leads/form-fields/number-field.tsx
@@ -2,7 +2,11 @@ import { numberFieldSchema } from "@/lib/zod/schemas/submitted-lead-form";
import { cn } from "@dub/utils";
import { useFormContext } from "react-hook-form";
import * as z from "zod/v4";
-import { FormControl, requiredFieldRule } from "./form-control";
+import {
+ blockNonNumericKeys,
+ FormControl,
+ requiredFieldRule,
+} from "./form-control";
type NumberFieldData = z.infer<typeof numberFieldSchema>;
@@ -29,6 +33,7 @@ export function NumberField({
>
<input
type="number"
+ onKeyDown={blockNonNumericKeys}
min={min}
max={max}
className={cn(