Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

code improvements

Pedro Ladeira53949be78835
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page.tsx
index 63c05ca03f..320a596a66 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/customers/(index)/page.tsx
@@ -135,37 +135,31 @@ export default function PartnerProgramCustomersPage() {
id: "link",
header: "Link",
accessorKey: "activity.link",
- cell: ({ row }) =>
- row.original.activity.link ? (
+ cell: ({ row }) => {
+ const link = row.original.activity.link;
+ if (!link) return "-";
+
+ const label =
+ displayProperties.includes("title") && link.partnerLinkTitle
+ ? link.partnerLinkTitle
+ : getPrettyUrl(link.shortLink);
+
+ return (
<a
- href={`/programs/${programSlug}/analytics?linkId=${row.original.activity.link.id}`}
+ href={`/programs/${programSlug}/analytics?linkId=${link.id}`}
target="_blank"
className="flex cursor-alias items-center gap-3 decoration-dotted underline-offset-2 hover:underline"
>
<LinkLogo
- apexDomain={getApexDomain(
- row.original.activity.link.shortLink,
- )}
+ apexDomain={getApexDomain(link.shortLink)}
className="size-4 shrink-0 sm:size-4"
/>
- <span
- className="truncate"
- title={
- displayProperties.includes("title") &&
- row.original.activity.link.partnerLinkTitle
- ? row.original.activity.link.partnerLinkTitle
- : row.original.activity.link.shortLink
- }
- >
- {displayProperties.includes("title") &&
- row.original.activity.link.partnerLinkTitle
- ? row.original.activity.link.partnerLinkTitle
- : getPrettyUrl(row.original.activity.link.shortLink)}
+ <span className="truncate" title={label}>
+ {label}
</span>
</a>
- ) : (
- "-"
- ),
+ );
+ },
size: 250,
},
{
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/page-client.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/page-client.tsx
index 6121c65836..ca31627ec1 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/page-client.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/page-client.tsx
@@ -27,7 +27,6 @@ const PartnerLinksContext = createContext<{
interval: (typeof DATE_RANGE_INTERVAL_PRESETS)[number];
openMenuLinkId: string | null;
setOpenMenuLinkId: (id: string | null) => void;
- displayOption: "full" | "cards";
} | null>(null);
export function usePartnerLinksContext() {
@@ -151,7 +150,6 @@ function PartnerProgramLinksPageInner({
interval,
openMenuLinkId,
setOpenMenuLinkId,
- displayOption,
}}
>
<ChartTooltipSync>
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx
index 7f458fca85..dad7ef7aa1 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx
@@ -76,8 +76,9 @@ const CHARTS = [
export function PartnerLinkCard({ link }: { link: PartnerProfileLinkProps }) {
const { programEnrollment } = useProgramEnrollment();
- const { displayOption } = usePartnerLinksContext();
- const { displayProperties } = useContext(PartnerLinksDisplayContext);
+ const { displayOption, displayProperties } = useContext(
+ PartnerLinksDisplayContext,
+ );
const { showRewards, toggleRewards } = usePartnerLinkRewardsState();
const {
rewards,
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-display.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-display.tsx
index add3354e65..9891e6c307 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-display.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-display.tsx
@@ -86,10 +86,6 @@ export function PartnerLinkDisplay() {
...(active ? [property.switch] : []),
];
- if (!next.includes("link") && !next.includes("title")) {
- next = ["link"];
- }
-
setDisplayProperties(next);
}}
className={cn(
diff --git a/apps/web/lib/api/partner-profile/get-earnings-for-partner.ts b/apps/web/lib/api/partner-profile/get-earnings-for-partner.ts
index 3a5d7500cb..c66264e641 100644
--- a/apps/web/lib/api/partner-profile/get-earnings-for-partner.ts
+++ b/apps/web/lib/api/partner-profile/get-earnings-for-partner.ts
@@ -81,6 +81,7 @@ export async function getEarningsForPartner(
id: true,
shortLink: true,
url: true,
+ partnerLinkTitle: true,
},
},
program: {
diff --git a/apps/web/lib/swr/use-partner-links-display.tsx b/apps/web/lib/swr/use-partner-links-display.tsx
index 4137a506c7..f2774efc80 100644
--- a/apps/web/lib/swr/use-partner-links-display.tsx
+++ b/apps/web/lib/swr/use-partner-links-display.tsx
@@ -39,9 +39,7 @@ type PartnerLinksDisplayContextValue = {
displayOption: PartnerLinksDisplayOption;
setDisplayOption: Dispatch<SetStateAction<PartnerLinksDisplayOption>>;
displayProperties: PartnerLinksDisplayProperty[];
- setDisplayProperties: Dispatch<
- SetStateAction<PartnerLinksDisplayProperty[]>
- >;
+ setDisplayProperties: Dispatch<SetStateAction<PartnerLinksDisplayProperty[]>>;
isDirty: boolean;
persist: () => void | Promise<void>;
reset: () => void;
@@ -106,10 +104,6 @@ export function PartnerLinksDisplayProvider({
return false;
}, [displayOption, displayProperties, resolvedPersisted]);
- const effectiveDisplayOption = !showDetailedAnalytics
- ? "cards"
- : displayOption;
-
const persist = async () => {
if (!programEnrollment?.programId) return;
@@ -131,7 +125,7 @@ export function PartnerLinksDisplayProvider({
return (
<PartnerLinksDisplayContext.Provider
value={{
- displayOption: effectiveDisplayOption,
+ displayOption: !showDetailedAnalytics ? "cards" : displayOption,
setDisplayOption,
displayProperties,
setDisplayProperties,