Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

code improvements

Pedro Ladeira550b3d69b370
diff --git a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/export/route.ts b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/export/route.ts
index d86d479b99..97a3ba729d 100644
--- a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/export/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/export/route.ts
@@ -23,6 +23,18 @@ export const maxDuration = 300;
// GET /api/partner-profile/programs/[programId]/analytics/export – get export data for partner profile analytics
export const GET = withPartnerProfile(
async ({ partner, params, searchParams }) => {
+ const { success } = await ratelimit(1, "30 s").limit(
+ `analytics-export:partner:${partner.id}:${params.programId}`,
+ );
+
+ if (!success) {
+ throw new DubApiError({
+ code: "rate_limit_exceeded",
+ message:
+ "Analytics export is limited to once every 30 seconds. Please try again shortly.",
+ });
+ }
+
const { program, links, totalCommissions } =
await getProgramEnrollmentOrThrow({
partnerId: partner.id,
@@ -102,18 +114,6 @@ export const GET = withPartnerProfile(
};
}
- const { success } = await ratelimit(1, "30 s").limit(
- `analytics-export:partner:${partner.id}:${params.programId}`,
- );
-
- if (!success) {
- throw new DubApiError({
- code: "rate_limit_exceeded",
- message:
- "Analytics export is limited to once every 30 seconds. Please try again shortly.",
- });
- }
-
const dataAvailableFrom = program.startedAt ?? program.createdAt;
const zipData = await exportAnalyticsToZip({
diff --git a/apps/web/app/api/analytics/export/route.ts b/apps/web/app/api/analytics/export/route.ts
index 600de051c2..8b7daa2e02 100644
--- a/apps/web/app/api/analytics/export/route.ts
+++ b/apps/web/app/api/analytics/export/route.ts
@@ -22,6 +22,18 @@ export const maxDuration = 300;
// GET /api/analytics/export – get export data for analytics
export const GET = withWorkspace(
async ({ searchParams, workspace, session }) => {
+ const { success } = await ratelimit(1, "30 s").limit(
+ `analytics-export:${workspace.id}`,
+ );
+
+ if (!success) {
+ throw new DubApiError({
+ code: "rate_limit_exceeded",
+ message:
+ "Analytics export is limited to once every 30 seconds. Please try again shortly.",
+ });
+ }
+
throwIfClicksUsageExceeded(workspace);
const parsedParams = parseAnalyticsQuery(searchParams);
@@ -98,18 +110,6 @@ export const GET = withWorkspace(
workspace.plan,
).canTrackConversions;
- const { success } = await ratelimit(1, "30 s").limit(
- `analytics-export:${workspace.id}`,
- );
-
- if (!success) {
- throw new DubApiError({
- code: "rate_limit_exceeded",
- message:
- "Analytics export is limited to once every 30 seconds. Please try again shortly.",
- });
- }
-
const { domain: _domain, key: _key, ...filterParams } = parsedParams;
const hasLinkIdFilter = Boolean(parsedParams.linkId);
const analyticsParams = hasLinkIdFilter ? filterParams : parsedParams;
diff --git a/apps/web/ui/analytics/analytics-export-button.tsx b/apps/web/ui/analytics/analytics-export-button.tsx
index 9771716681..dd14e691a3 100644
--- a/apps/web/ui/analytics/analytics-export-button.tsx
+++ b/apps/web/ui/analytics/analytics-export-button.tsx
@@ -48,6 +48,7 @@ export function AnalyticsExportButton({
a.href = url;
a.download = `Dub Analytics Export - ${new Date().toISOString()}.zip`;
a.click();
+ window.URL.revokeObjectURL(url);
} catch (error) {
throw error instanceof Error ? error : new Error(String(error));
} finally {