Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Reward icon alignment and orphan fix

Marcus Farrell55bf2b2915ec
diff --git a/apps/web/ui/partners/lander/lander-rewards.tsx b/apps/web/ui/partners/lander/lander-rewards.tsx
index 92545e3f25..50a633d2c2 100644
--- a/apps/web/ui/partners/lander/lander-rewards.tsx
+++ b/apps/web/ui/partners/lander/lander-rewards.tsx
@@ -111,8 +111,8 @@ const Item = ({
children,
}: PropsWithChildren<{ icon: Icon }>) => {
return (
- <li className="flex items-center gap-2 leading-5">
- <IconComponent className="size-4 shrink-0 text-neutral-600" />
+ <li className="flex items-start gap-2 leading-5">
+ <IconComponent className="mt-0.5 size-4 shrink-0 text-neutral-600" />
<div>{children}</div>
</li>
);
diff --git a/apps/web/ui/partners/program-reward-description.tsx b/apps/web/ui/partners/program-reward-description.tsx
index d81c1536c4..4570e312d7 100644
--- a/apps/web/ui/partners/program-reward-description.tsx
+++ b/apps/web/ui/partners/program-reward-description.tsx
@@ -93,10 +93,12 @@ export function ProgramRewardDescription({
{showModifiersTooltip &&
(!!reward.modifiers?.length ||
Boolean(reward.tooltipDescription)) && (
- <>
- {" "}
+ // whitespace-nowrap keeps the tooltip icon attached to the last
+ // word of the description so it never wraps on its own line
+ <span className="whitespace-nowrap">
+ {" "}
<ProgramRewardModifiersTooltip reward={reward} />
- </>
+ </span>
)}
</>
) : null}
diff --git a/apps/web/ui/partners/program-reward-spend-limit.tsx b/apps/web/ui/partners/program-reward-spend-limit.tsx
index 5b82f35897..ab63f9bf75 100644
--- a/apps/web/ui/partners/program-reward-spend-limit.tsx
+++ b/apps/web/ui/partners/program-reward-spend-limit.tsx
@@ -37,7 +37,13 @@ export function ProgramRewardSpendLimit({
return null;
}
- return `, up to ${parts.amount} ${parts.interval} ${event === "sale" ? "per customer" : ""}`;
+ return [
+ `, up to ${parts.amount}`,
+ parts.interval,
+ event === "sale" ? "per customer" : "",
+ ]
+ .filter(Boolean)
+ .join(" ");
}
export function buildCommissionDescription({
diff --git a/apps/web/ui/partners/program-rewards-panel.tsx b/apps/web/ui/partners/program-rewards-panel.tsx
index a8c27bf660..5d695df216 100644
--- a/apps/web/ui/partners/program-rewards-panel.tsx
+++ b/apps/web/ui/partners/program-rewards-panel.tsx
@@ -63,10 +63,12 @@ export const ProgramRewardsPanel = memo(
</>
) : null}
{!!reward.modifiers?.length && (
- <>
+ // whitespace-nowrap keeps the tooltip icon attached to the last
+ // word of the description so it never wraps on its own line
+ <span className="whitespace-nowrap">
{" "}
<CustomRewardModifiersTooltip reward={reward} />
- </>
+ </span>
)}
</>
),