Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Updated detectDuplicatePayoutMethodFraud to streamline partner enrollment checks

Kiran K576893aa4ce4
diff --git a/apps/web/app/(ee)/api/stripe/connect/webhook/account-updated.ts b/apps/web/app/(ee)/api/stripe/connect/webhook/account-updated.ts
index cda1d85a4c..f6e04e1501 100644
--- a/apps/web/app/(ee)/api/stripe/connect/webhook/account-updated.ts
+++ b/apps/web/app/(ee)/api/stripe/connect/webhook/account-updated.ts
@@ -1,7 +1,7 @@
import { detectDuplicatePayoutMethodFraud } from "@/lib/api/fraud/detect-duplicate-payout-method-fraud";
import { qstash } from "@/lib/cron";
import { stripe } from "@/lib/stripe";
-import { sendBatchEmail, sendEmail } from "@dub/email";
+import { sendEmail } from "@dub/email";
import ConnectedPayoutMethod from "@dub/email/templates/connected-payout-method";
import DuplicatePayoutMethod from "@dub/email/templates/duplicate-payout-method";
import { prisma } from "@dub/prisma";
@@ -81,14 +81,21 @@ export async function accountUpdated(event: Stripe.Event) {
});
if (payoutMethodHash) {
- const { isPayoutMethodDuplicate, duplicatePartners } =
- await detectDuplicatePayoutMethodFraud(payoutMethodHash);
+ const [duplicatePartnersCount, _] = await Promise.all([
+ prisma.partner.count({
+ where: {
+ payoutMethodHash,
+ },
+ }),
- // Send confirmation email only if this is the first time connecting a bank account and no fraud detected
+ detectDuplicatePayoutMethodFraud(payoutMethodHash),
+ ]);
+
+ // Send confirmation email only if this is the first time connecting a bank account
if (
+ duplicatePartnersCount === 0 &&
partner.email &&
!partner.payoutsEnabledAt &&
- !isPayoutMethodDuplicate &&
defaultExternalAccount.object === "bank_account"
) {
await sendEmail({
@@ -107,28 +114,26 @@ export async function accountUpdated(event: Stripe.Event) {
});
}
- // Notify all partners using the same bank account about duplicate payout method
+ // Notify the partner about duplicate payout method
if (
- isPayoutMethodDuplicate &&
- duplicatePartners.length > 0 &&
+ duplicatePartnersCount > 0 &&
+ partner.email &&
defaultExternalAccount.object === "bank_account"
) {
- await sendBatchEmail(
- duplicatePartners.map((partner) => ({
- variant: "notifications",
- subject: "Duplicate payout method detected",
- to: partner.email!,
- react: DuplicatePayoutMethod({
- email: partner.email!,
- payoutMethod: {
- account_holder_name: defaultExternalAccount.account_holder_name,
- bank_name: defaultExternalAccount.bank_name,
- last4: defaultExternalAccount.last4,
- routing_number: defaultExternalAccount.routing_number,
- },
- }),
- })),
- );
+ await sendEmail({
+ variant: "notifications",
+ subject: "Duplicate payout method detected",
+ to: partner.email,
+ react: DuplicatePayoutMethod({
+ email: partner.email,
+ payoutMethod: {
+ account_holder_name: defaultExternalAccount.account_holder_name,
+ bank_name: defaultExternalAccount.bank_name,
+ last4: defaultExternalAccount.last4,
+ routing_number: defaultExternalAccount.routing_number,
+ },
+ }),
+ });
}
}
diff --git a/apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts b/apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts
index dddfe94e9c..eec008cea1 100644
--- a/apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts
+++ b/apps/web/lib/api/fraud/detect-duplicate-payout-method-fraud.ts
@@ -1,74 +1,71 @@
import { CreateFraudEventInput } from "@/lib/types";
+import { NON_ACTIVE_ENROLLMENT_STATUSES } from "@/lib/zod/schemas/partners";
import { prisma } from "@dub/prisma";
-import { FraudRuleType } from "@dub/prisma/client";
+import { FraudRuleType, ProgramEnrollment } from "@dub/prisma/client";
import { createFraudEvents } from "./create-fraud-events";
// Check for duplicate payout methods: if multiple partners share the same payout method hash,
// create fraud events for all their active program enrollments to flag potential fraud
export async function detectDuplicatePayoutMethodFraud(
payoutMethodHash: string,
-) {
+): Promise<void> {
if (!payoutMethodHash) {
- return {
- isPayoutMethodDuplicate: false,
- duplicatePartners: [],
- };
+ return;
}
- // Find all partners using this payout method with their program enrollments
- const duplicatePartners = await prisma.partner.findMany({
+ const programEnrollments = await prisma.programEnrollment.findMany({
where: {
- payoutMethodHash,
+ partner: {
+ payoutMethodHash,
+ },
},
select: {
- id: true,
- email: true,
- stripeConnectId: true,
- programs: {
- select: {
- programId: true,
- },
- },
+ programId: true,
+ partnerId: true,
+ status: true,
},
});
- if (duplicatePartners.length <= 1) {
- return {
- isPayoutMethodDuplicate: false,
- duplicatePartners: [],
- };
+ if (programEnrollments.length === 0) {
+ return;
}
- // Group program enrollments by programId
- const partnersByProgram = new Map<string, string[]>();
-
- for (const partner of duplicatePartners) {
- for (const { programId } of partner.programs) {
- const list = partnersByProgram.get(programId) ?? [];
- list.push(partner.id);
- partnersByProgram.set(programId, list);
+ // Group partners by program enrollment
+ let partnersByProgram = programEnrollments.reduce((map, e) => {
+ if (!map.has(e.programId)) {
+ map.set(e.programId, []);
}
+ map.get(e.programId)!.push({ partnerId: e.partnerId, status: e.status });
+ return map;
+ }, new Map<string, Pick<ProgramEnrollment, "partnerId" | "status">[]>());
+
+ // Filter out programs with only one partner
+ partnersByProgram = new Map(
+ Array.from(partnersByProgram.entries()).filter(
+ ([_, partners]) => partners.length > 1,
+ ),
+ );
+
+ if (partnersByProgram.size === 0) {
+ return;
}
- // Generate fraud events (only when both accounts are enrolled in the same program)
const fraudEvents: CreateFraudEventInput[] = [];
- for (const partner of duplicatePartners) {
- for (const { programId } of partner.programs) {
- const enrolledPartners = partnersByProgram.get(programId) ?? [];
-
- // Only create events if there are multiple partners with same payout method in this program
- if (enrolledPartners.length <= 1) continue;
+ for (const [programId, partners] of partnersByProgram.entries()) {
+ for (const sourcePartner of partners) {
+ if (NON_ACTIVE_ENROLLMENT_STATUSES.includes(sourcePartner.status)) {
+ continue;
+ }
- // Create events for each enrolled partner (including self)
- for (const enrolledPartner of enrolledPartners) {
+ for (const enrolledPartner of partners) {
fraudEvents.push({
programId,
- partnerId: partner.id,
+ partnerId: sourcePartner.partnerId,
type: FraudRuleType.partnerDuplicatePayoutMethod,
metadata: {
payoutMethodHash,
- duplicatePartnerId: enrolledPartner,
+ duplicatePartnerId: enrolledPartner.partnerId,
},
});
}
@@ -76,12 +73,4 @@ export async function detectDuplicatePayoutMethodFraud(
}
await createFraudEvents(fraudEvents);
-
- return {
- isPayoutMethodDuplicate: true,
- duplicatePartners: duplicatePartners.map(({ id, email }) => ({
- id,
- email,
- })),
- };
}