The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Consolidate duplicated unique helpers into @dub/utils (#4476)
Kiran K58c191297337
diff --git a/apps/web/lib/api/partners/queue-partner-search-sync.ts b/apps/web/lib/api/partners/queue-partner-search-sync.tsindex 9512eb208f..b76109e630 100644--- a/apps/web/lib/api/partners/queue-partner-search-sync.ts+++ b/apps/web/lib/api/partners/queue-partner-search-sync.ts@@ -1,5 +1,5 @@import { partnerSearchSyncJob } from "@/lib/jobs/handlers/partner-search-sync-job";-import { chunk } from "@dub/utils";+import { chunk, unique } from "@dub/utils";import {getPartnerSearchProvider,PARTNER_SEARCH_SYNC_BATCH_SIZE,@@ -34,10 +34,6 @@ interface QueuePartnerSearchSyncInput {delay?: number;}-function unique(values: string[] | undefined): string[] {- return Array.from(new Set((values ?? []).filter(Boolean)));-}-/*** Queues an index sync for whatever the caller just changed.*@@ -57,8 +53,8 @@ export async function queuePartnerSearchSync({return;}- const enrollments = unique(enrollmentIds);- const partners = unique(partnerIds);+ const enrollments = unique(enrollmentIds?.filter(Boolean));+ const partners = unique(partnerIds?.filter(Boolean));if (enrollments.length === 0 && partners.length === 0) {return;diff --git a/apps/web/lib/api/partners/search/serialize-document.ts b/apps/web/lib/api/partners/search/serialize-document.tsindex 4aaa9b6632..744111a2d3 100644--- a/apps/web/lib/api/partners/search/serialize-document.ts+++ b/apps/web/lib/api/partners/search/serialize-document.ts@@ -1,4 +1,5 @@import { Prisma } from "@prisma/client";+import { unique } from "@dub/utils";import { PartnerSearchDocument } from "./types";export const partnerSearchDocumentSelect = {@@ -42,10 +43,6 @@ export type PartnerSearchDocumentSource = Prisma.ProgramEnrollmentGetPayload<{select: typeof partnerSearchDocumentSelect;}>;-function unique<T>(values: T[]): T[] {- return Array.from(new Set(values));-}-export function serializePartnerSearchDocument(enrollment: PartnerSearchDocumentSource,): PartnerSearchDocument {diff --git a/apps/web/lib/api/partners/search/sync.ts b/apps/web/lib/api/partners/search/sync.tsindex a648f0eef4..2c5cda7102 100644--- a/apps/web/lib/api/partners/search/sync.ts+++ b/apps/web/lib/api/partners/search/sync.ts@@ -1,4 +1,5 @@import { prisma } from "@/lib/prisma";+import { unique } from "@dub/utils";import { getPartnerSearchProvider } from "./provider";import {partnerSearchDocumentSelect,@@ -22,10 +23,6 @@ interface SyncPartnerSearchDocumentsOptions {searchProvider?: PartnerSearchProvider | null;}-function unique(values: string[]): string[] {- return Array.from(new Set(values.filter(Boolean)));-}-/*** Brings the index in line with the database for the given enrollments.*@@ -38,7 +35,7 @@ export async function syncPartnerSearchDocuments({enrollmentIds,searchProvider = getPartnerSearchProvider(),}: SyncPartnerSearchDocumentsOptions): Promise<PartnerSearchSyncResult> {- const ids = unique(enrollmentIds);+ const ids = unique(enrollmentIds.filter(Boolean));if (!searchProvider || ids.length === 0) {return { upserted: 0, deleted: 0 };@@ -93,7 +90,7 @@ export async function findPartnerSearchSyncEnrollmentIds({after,take = PARTNER_SEARCH_SYNC_BATCH_SIZE,}: FindPartnerSearchSyncEnrollmentIdsOptions): Promise<string[]> {- const ids = unique(partnerIds);+ const ids = unique(partnerIds.filter(Boolean));if (ids.length === 0) {return [];diff --git a/packages/utils/src/functions/index.ts b/packages/utils/src/functions/index.tsindex a6661f6853..1b05c92d6f 100644--- a/packages/utils/src/functions/index.ts+++ b/packages/utils/src/functions/index.ts@@ -43,4 +43,5 @@ export * from "./time-ago";export * from "./to-cents-number";export * from "./trim";export * from "./truncate";+export * from "./unique";export * from "./urls";diff --git a/packages/utils/src/functions/unique.ts b/packages/utils/src/functions/unique.tsnew file mode 100644index 0000000000..05c00ac737--- /dev/null+++ b/packages/utils/src/functions/unique.ts@@ -0,0 +1,3 @@+export const unique = <T>(values: T[] | null | undefined): T[] => {+ return Array.from(new Set(values ?? []));+};