The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Commit 2
Marcus Farrell59d18a47f009
diff --git a/packages/ui/src/modal.tsx b/packages/ui/src/modal.tsxindex f33e193bbb..2d7c0fe3ca 100644--- a/packages/ui/src/modal.tsx+++ b/packages/ui/src/modal.tsx@@ -17,9 +17,12 @@ import { useMediaQuery } from "./hooks";// Dev-only detector for modal remount bugs: an open Modal unmounting while// another mounts open in the same commit means its element type changed// (unstable hook dep) and any user state in it was lost-let pendingOpenUnmount = false;+let pendingOpenUnmount: unknown = null;function useWarnOnRemountWhileOpen(showModal?: boolean) {+ // Per-instance token so Strict Mode's same-instance setup/cleanup/setup+ // cycle doesn't register as a remount+ const instance = useRef({});const showModalRef = useRef(showModal);useEffect(() => {@@ -29,8 +32,12 @@ function useWarnOnRemountWhileOpen(showModal?: boolean) {useEffect(() => {if (process.env.NODE_ENV !== "development") return;- if (showModalRef.current && pendingOpenUnmount) {- pendingOpenUnmount = false;+ if (+ showModalRef.current &&+ pendingOpenUnmount &&+ pendingOpenUnmount !== instance.current+ ) {+ pendingOpenUnmount = null;console.warn("[Modal] remounted while open — the modal's element type changed mid-session (unstable hook dep?) and any user state in it was lost.",);@@ -38,9 +45,9 @@ function useWarnOnRemountWhileOpen(showModal?: boolean) {return () => {if (showModalRef.current) {- pendingOpenUnmount = true;+ pendingOpenUnmount = instance.current;queueMicrotask(() => {- pendingOpenUnmount = false;+ pendingOpenUnmount = null;});}};