Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

keep banned partners banned when re-importing partners

Pedro Ladeira5bc8cda2b3b8
diff --git a/apps/web/lib/api/partners/upsert-imported-program-enrollment.ts b/apps/web/lib/api/partners/upsert-imported-program-enrollment.ts
new file mode 100644
index 0000000000..99b6e4d266
--- /dev/null
+++ b/apps/web/lib/api/partners/upsert-imported-program-enrollment.ts
@@ -0,0 +1,65 @@
+import { prisma } from "@/lib/prisma";
+import { Prisma } from "@prisma/client";
+
+// Re-imports must not reopen a banned enrollment. A banned row is read back
+// and left unchanged, including `updatedAt`.
+export async function upsertImportedProgramEnrollment<
+ T extends Prisma.ProgramEnrollmentInclude = {},
+>({
+ partnerId,
+ programId,
+ create,
+ include,
+}: {
+ partnerId: string;
+ programId: string;
+ create: Prisma.ProgramEnrollmentUncheckedCreateInput;
+ include?: T;
+}): Promise<{
+ enrollment: Prisma.ProgramEnrollmentGetPayload<{ include: T }>;
+ preservedBan: boolean;
+}> {
+ const where = {
+ partnerId_programId: {
+ partnerId,
+ programId,
+ },
+ };
+
+ const existing = await prisma.programEnrollment.findUnique({
+ where,
+ select: {
+ status: true,
+ },
+ });
+
+ if (existing?.status === "banned") {
+ const enrollment = await prisma.programEnrollment.findUniqueOrThrow({
+ where,
+ include,
+ });
+
+ return {
+ enrollment: enrollment as Prisma.ProgramEnrollmentGetPayload<{
+ include: T;
+ }>,
+ preservedBan: true,
+ };
+ }
+
+ const enrollment = await prisma.programEnrollment.upsert({
+ where,
+ create,
+ update: {
+ status: "approved",
+ },
+ include,
+ });
+
+ return {
+ enrollment: enrollment as Prisma.ProgramEnrollmentGetPayload<{
+ include: T;
+ }>,
+ preservedBan: false,
+ };
+}
diff --git a/apps/web/lib/firstpromoter/import-partners.ts b/apps/web/lib/firstpromoter/import-partners.ts
index f371bdf89e..5c43c58a6b 100644
--- a/apps/web/lib/firstpromoter/import-partners.ts
+++ b/apps/web/lib/firstpromoter/import-partners.ts
@@ -10,6 +10,7 @@ import { createId } from "../api/create-id";
import { bulkCreateLinks } from "../api/links";
import { upsertPartnerPlatform } from "../api/partner-profile/upsert-partner-platform";
import { queuePartnerSearchSync } from "../api/partners/queue-partner-search-sync";
+import { upsertImportedProgramEnrollment } from "../api/partners/upsert-imported-program-enrollment";
import { approveLinkedApplication } from "../program-applications/approve-linked-application";
import { DEFAULT_PARTNER_GROUP } from "../zod/schemas/groups";
import { FirstPromoterApi } from "./api";
@@ -180,44 +181,44 @@ async function createPartnerAndLinks({
);
}
- const programEnrollment = await prisma.programEnrollment.upsert({
- where: {
- partnerId_programId: {
- partnerId: partner.id,
+ const { enrollment: programEnrollment, preservedBan } =
+ await upsertImportedProgramEnrollment({
+ partnerId: partner.id,
+ programId: program.id,
+ create: {
+ id: createId({ prefix: "pge_" }),
programId: program.id,
+ partnerId: partner.id,
+ status: "approved",
+ groupId: group.id,
+ clickRewardId: group.clickRewardId,
+ leadRewardId: group.leadRewardId,
+ saleRewardId: group.saleRewardId,
+ referralRewardId: group.referralRewardId,
+ customRewardId: group.customRewardId,
+ discountId: group.discountId,
},
- },
- create: {
- id: createId({ prefix: "pge_" }),
- programId: program.id,
- partnerId: partner.id,
- status: "approved",
- groupId: group.id,
- clickRewardId: group.clickRewardId,
- leadRewardId: group.leadRewardId,
- saleRewardId: group.saleRewardId,
- referralRewardId: group.referralRewardId,
- customRewardId: group.customRewardId,
- discountId: group.discountId,
- },
- update: {
- status: "approved",
- },
- include: {
- links: true,
- },
- });
+ include: {
+ links: true,
+ },
+ });
- await approveLinkedApplication({
- applicationId: programEnrollment.applicationId,
- userId,
- });
+ if (!preservedBan) {
+ await approveLinkedApplication({
+ applicationId: programEnrollment.applicationId,
+ userId,
+ });
+ }
if (!program.domain || !program.url) {
console.error("Program domain or url not found", program.id);
return programEnrollment.id;
}
+ if (preservedBan) {
+ return programEnrollment.id;
+ }
+
if (programEnrollment.links.length > 0) {
console.log("Partner already has links", partner.id);
return programEnrollment.id;
diff --git a/apps/web/lib/lemonsqueezy/import-partners.ts b/apps/web/lib/lemonsqueezy/import-partners.ts
index 493d8fe06d..5f3befef31 100644
--- a/apps/web/lib/lemonsqueezy/import-partners.ts
+++ b/apps/web/lib/lemonsqueezy/import-partners.ts
@@ -1,9 +1,10 @@
import { prisma } from "@/lib/prisma";
import { PartnerGroup, Program } from "@prisma/client";
import { createId } from "../api/create-id";
-import { queuePartnerSearchSync } from "../api/partners/queue-partner-search-sync";
import { createLink } from "../api/links";
import { generatePartnerLink } from "../api/partners/generate-partner-link";
+import { queuePartnerSearchSync } from "../api/partners/queue-partner-search-sync";
+import { upsertImportedProgramEnrollment } from "../api/partners/upsert-imported-program-enrollment";
import { approveLinkedApplication } from "../program-applications/approve-linked-application";
import { logImportError } from "../tinybird/log-import-error";
import { WorkspaceProps } from "../types";
@@ -225,13 +226,9 @@ async function createPartnerAndLinks({
update: {},
});
- const { links, applicationId } = await prisma.programEnrollment.upsert({
- where: {
- partnerId_programId: {
- partnerId: partner.id,
- programId: program.id,
- },
- },
+ const { enrollment, preservedBan } = await upsertImportedProgramEnrollment({
+ partnerId: partner.id,
+ programId: program.id,
create: {
id: createId({ prefix: "pge_" }),
programId: program.id,
@@ -245,25 +242,21 @@ async function createPartnerAndLinks({
customRewardId: group.customRewardId,
discountId: group.discountId,
},
- update: {
- status: "approved",
- },
- select: {
- applicationId: true,
- links: {
- select: {
- key: true,
- },
- },
+ include: {
+ links: true,
},
});
+ if (preservedBan) {
+ return partner.id;
+ }
+
await approveLinkedApplication({
- applicationId,
+ applicationId: enrollment.applicationId,
userId,
});
- if (links.length > 0 && links.some((link) => link.key === affiliate.id)) {
+ if (enrollment.links.some((link) => link.key === affiliate.id)) {
console.log(
`Partner ${partner.id} already has a link with key ${affiliate.id}, skipping...`,
);
diff --git a/apps/web/lib/partnerstack/import-partners.ts b/apps/web/lib/partnerstack/import-partners.ts
index 352d411124..0bf90448f6 100644
--- a/apps/web/lib/partnerstack/import-partners.ts
+++ b/apps/web/lib/partnerstack/import-partners.ts
@@ -3,6 +3,7 @@ import { COUNTRIES, COUNTRY_CODES, sleep } from "@dub/utils";
import { PartnerGroup, Program } from "@prisma/client";
import { createId } from "../api/create-id";
import { queuePartnerSearchSync } from "../api/partners/queue-partner-search-sync";
+import { upsertImportedProgramEnrollment } from "../api/partners/upsert-imported-program-enrollment";
import { approveLinkedApplication } from "../program-applications/approve-linked-application";
import { logImportError } from "../tinybird/log-import-error";
import { redis } from "../upstash";
@@ -180,13 +181,9 @@ async function createPartner({
},
});
- const { applicationId } = await prisma.programEnrollment.upsert({
- where: {
- partnerId_programId: {
- partnerId,
- programId: program.id,
- },
- },
+ const { enrollment, preservedBan } = await upsertImportedProgramEnrollment({
+ partnerId,
+ programId: program.id,
create: {
id: createId({ prefix: "pge_" }),
programId: program.id,
@@ -200,17 +197,13 @@ async function createPartner({
customRewardId: group.customRewardId,
discountId: group.discountId,
},
- update: {
- status: "approved",
- },
- select: {
- applicationId: true,
- },
});
- await approveLinkedApplication({
- applicationId,
- });
+ if (!preservedBan) {
+ await approveLinkedApplication({
+ applicationId: enrollment.applicationId,
+ });
+ }
// PS doesn't return the partner email address in the customers response
// so we need to keep a map of partner_key (PS) -> partner_id (Dub)
diff --git a/apps/web/lib/rewardful/import-partners.ts b/apps/web/lib/rewardful/import-partners.ts
index 3e800adaa4..f6cf8dac3b 100644
--- a/apps/web/lib/rewardful/import-partners.ts
+++ b/apps/web/lib/rewardful/import-partners.ts
@@ -4,6 +4,7 @@ import { Program } from "@prisma/client";
import { createId } from "../api/create-id";
import { bulkCreateLinks } from "../api/links";
import { queuePartnerSearchSync } from "../api/partners/queue-partner-search-sync";
+import { upsertImportedProgramEnrollment } from "../api/partners/upsert-imported-program-enrollment";
import { approveLinkedApplication } from "../program-applications/approve-linked-application";
import { logImportError } from "../tinybird/log-import-error";
import { redis } from "../upstash";
@@ -195,39 +196,35 @@ async function createPartnerAndLinks({
update: {},
});
- const programEnrollment = await prisma.programEnrollment.upsert({
- where: {
- partnerId_programId: {
- partnerId: partner.id,
+ const { enrollment: programEnrollment, preservedBan } =
+ await upsertImportedProgramEnrollment({
+ partnerId: partner.id,
+ programId: program.id,
+ create: {
+ id: createId({ prefix: "pge_" }),
programId: program.id,
+ partnerId: partner.id,
+ status: "approved",
+ ...defaultGroupAttributes,
},
- },
- create: {
- id: createId({ prefix: "pge_" }),
- programId: program.id,
- partnerId: partner.id,
- status: "approved",
- ...defaultGroupAttributes,
- },
- update: {
- status: "approved",
- },
- include: {
- links: true,
- },
- });
+ include: {
+ links: true,
+ },
+ });
- await approveLinkedApplication({
- applicationId: programEnrollment.applicationId,
- userId,
- });
+ if (!preservedBan) {
+ await approveLinkedApplication({
+ applicationId: programEnrollment.applicationId,
+ userId,
+ });
+ }
if (!program.domain || !program.url) {
console.error("Program domain or url not found", program.id);
return;
}
- if (programEnrollment.links.length === 0) {
+ if (!preservedBan && programEnrollment.links.length === 0) {
await bulkCreateLinks({
links: affiliate.links.map((link, idx) => ({
domain: program.domain!,
diff --git a/apps/web/lib/tapfiliate/import-partners.ts b/apps/web/lib/tapfiliate/import-partners.ts
index de190052a8..3db839a47f 100644
--- a/apps/web/lib/tapfiliate/import-partners.ts
+++ b/apps/web/lib/tapfiliate/import-partners.ts
@@ -5,6 +5,7 @@ import { createId } from "../api/create-id";
import { createLink } from "../api/links";
import { generatePartnerLink } from "../api/partners/generate-partner-link";
import { queuePartnerSearchSync } from "../api/partners/queue-partner-search-sync";
+import { upsertImportedProgramEnrollment } from "../api/partners/upsert-imported-program-enrollment";
import { approveLinkedApplication } from "../program-applications/approve-linked-application";
import { logImportError } from "../tinybird/log-import-error";
import { WorkspaceProps } from "../types";
@@ -227,13 +228,9 @@ async function createPartnerAndLinks({
update: {},
});
- const { links, applicationId } = await prisma.programEnrollment.upsert({
- where: {
- partnerId_programId: {
- partnerId: partner.id,
- programId: program.id,
- },
- },
+ const { enrollment, preservedBan } = await upsertImportedProgramEnrollment({
+ partnerId: partner.id,
+ programId: program.id,
create: {
id: createId({ prefix: "pge_" }),
programId: program.id,
@@ -247,25 +244,21 @@ async function createPartnerAndLinks({
customRewardId: group.customRewardId,
discountId: group.discountId,
},
- update: {
- status: "approved",
- },
- select: {
- applicationId: true,
- links: {
- select: {
- key: true,
- },
- },
+ include: {
+ links: true,
},
});
+ if (preservedBan) {
+ return partner.id;
+ }
+
await approveLinkedApplication({
- applicationId,
+ applicationId: enrollment.applicationId,
userId,
});
- if (links.length > 0 && links.some((link) => link.key === affiliate.id)) {
+ if (enrollment.links.some((link) => link.key === affiliate.id)) {
console.log(
`Partner ${partner.email} already has a link with key ${affiliate.id}, skipping...`,
);
diff --git a/apps/web/lib/tolt/import-partners.ts b/apps/web/lib/tolt/import-partners.ts
index 04f7529a5e..698d0a079b 100644
--- a/apps/web/lib/tolt/import-partners.ts
+++ b/apps/web/lib/tolt/import-partners.ts
@@ -4,6 +4,7 @@ import { Partner, Program } from "@prisma/client";
import { createId } from "../api/create-id";
import { queuePartnerSearchSync } from "../api/partners/queue-partner-search-sync";
+import { upsertImportedProgramEnrollment } from "../api/partners/upsert-imported-program-enrollment";
import { approveLinkedApplication } from "../program-applications/approve-linked-application";
import { logImportError } from "../tinybird/log-import-error";
import { DEFAULT_PARTNER_GROUP } from "../zod/schemas/groups";
@@ -163,13 +164,9 @@ async function createPartner({
},
});
- const { applicationId } = await prisma.programEnrollment.upsert({
- where: {
- partnerId_programId: {
- partnerId: partner.id,
- programId: program.id,
- },
- },
+ const { enrollment, preservedBan } = await upsertImportedProgramEnrollment({
+ partnerId: partner.id,
+ programId: program.id,
create: {
id: createId({ prefix: "pge_" }),
programId: program.id,
@@ -177,17 +174,13 @@ async function createPartner({
status: "approved",
...defaultGroupAttributes,
},
- update: {
- status: "approved",
- },
- select: {
- applicationId: true,
- },
});
- await approveLinkedApplication({
- applicationId,
- });
+ if (!preservedBan) {
+ await approveLinkedApplication({
+ applicationId: enrollment.applicationId,
+ });
+ }
return partner;
}
diff --git a/apps/web/scripts/partners/restore-reopened-bans.ts b/apps/web/scripts/partners/restore-reopened-bans.ts
new file mode 100644
index 0000000000..368522e8c1
--- /dev/null
+++ b/apps/web/scripts/partners/restore-reopened-bans.ts
@@ -0,0 +1,178 @@
+import { linkCache } from "@/lib/api/links/cache";
+import { queuePartnerSearchSync } from "@/lib/api/partners/queue-partner-search-sync";
+import { prisma } from "@/lib/prisma";
+import { chunk } from "@dub/utils";
+import { Prisma, ProgramEnrollmentStatus } from "@prisma/client";
+import "dotenv-flow/config";
+
+// A re-import set these enrollments back to approved and left bannedAt in
+// place. A real unban clears bannedAt. Deactivated enrollments are left as-is.
+//
+// Does not re-send the ban email or re-cancel commissions and payouts.
+// Those side effects already ran when the partner was banned.
+//
+// pnpm script partners/restore-reopened-bans
+const DRY_RUN = true;
+const BATCH_SIZE = 100;
+
+async function main() {
+ const enrollments = await findReopenedBans();
+
+ console.log(`Found ${enrollments.length} reopened bans.`);
+ console.table(
+ enrollments.map((enrollment) => ({
+ enrollmentId: enrollment.id,
+ program: enrollment.program.slug,
+ partnerId: enrollment.partnerId,
+ email: enrollment.partner.email,
+ status: enrollment.status,
+ bannedAt: enrollment.bannedAt,
+ bannedReason: enrollment.bannedReason,
+ })),
+ );
+
+ if (DRY_RUN) {
+ console.log("Dry run. Set DRY_RUN to false to restore these bans.");
+ return;
+ }
+
+ let restored = 0;
+
+ for (const batch of chunk(enrollments, BATCH_SIZE)) {
+ const ids = batch.map((enrollment) => enrollment.id);
+
+ const { count } = await prisma.programEnrollment.updateMany({
+ where: {
+ id: {
+ in: ids,
+ },
+ bannedAt: {
+ not: null,
+ },
+ status: ProgramEnrollmentStatus.approved,
+ },
+ data: {
+ status: ProgramEnrollmentStatus.banned,
+ clickRewardId: null,
+ leadRewardId: null,
+ saleRewardId: null,
+ referralRewardId: null,
+ customRewardId: null,
+ discountId: null,
+ },
+ });
+
+ restored += count;
+
+ const partnerIdsByProgramId = new Map<string, string[]>();
+
+ for (const enrollment of batch) {
+ const partnerIds = partnerIdsByProgramId.get(enrollment.programId) ?? [];
+ partnerIds.push(enrollment.partnerId);
+ partnerIdsByProgramId.set(enrollment.programId, partnerIds);
+ }
+
+ for (const [programId, partnerIds] of partnerIdsByProgramId) {
+ const links = await prisma.link.findMany({
+ where: {
+ programId,
+ partnerId: {
+ in: partnerIds,
+ },
+ disabledAt: null,
+ },
+ select: {
+ domain: true,
+ key: true,
+ },
+ });
+
+ if (links.length === 0) {
+ continue;
+ }
+
+ await prisma.link.updateMany({
+ where: {
+ programId,
+ partnerId: {
+ in: partnerIds,
+ },
+ disabledAt: null,
+ },
+ data: {
+ disabledAt: new Date(),
+ expiresAt: new Date(),
+ },
+ });
+
+ await linkCache.expireMany(links);
+ console.log(`Disabled ${links.length} links in program ${programId}.`);
+ }
+
+ await queuePartnerSearchSync({
+ enrollmentIds: ids,
+ });
+ }
+
+ console.log(`Restored ${restored} bans.`);
+}
+
+const reopenedBanSelect = {
+ id: true,
+ partnerId: true,
+ programId: true,
+ status: true,
+ bannedAt: true,
+ bannedReason: true,
+ program: {
+ select: {
+ slug: true,
+ },
+ },
+ partner: {
+ select: {
+ email: true,
+ },
+ },
+} satisfies Prisma.ProgramEnrollmentSelect;
+
+type ReopenedBan = Prisma.ProgramEnrollmentGetPayload<{
+ select: typeof reopenedBanSelect;
+}>;
+
+async function findReopenedBans() {
+ const enrollments: ReopenedBan[] = [];
+ let cursor: string | undefined;
+
+ while (true) {
+ const batch = await prisma.programEnrollment.findMany({
+ where: {
+ bannedAt: {
+ not: null,
+ },
+ status: ProgramEnrollmentStatus.approved,
+ },
+ select: reopenedBanSelect,
+ orderBy: {
+ id: "asc",
+ },
+ take: BATCH_SIZE,
+ ...(cursor && {
+ skip: 1,
+ cursor: {
+ id: cursor,
+ },
+ }),
+ });
+
+ enrollments.push(...batch);
+
+ if (batch.length < BATCH_SIZE) {
+ return enrollments;
+ }
+
+ cursor = batch[batch.length - 1].id;
+ }
+}
+
+main();