The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Require messages.read to read submitted lead comments
Rafi5f50fca4eb6e
diff --git a/apps/web/app/(ee)/api/programs/[programId]/submitted-leads/[leadId]/comments/route.ts b/apps/web/app/(ee)/api/programs/[programId]/submitted-leads/[leadId]/comments/route.tsindex 2cca8e0afa..b374453cd9 100644--- a/apps/web/app/(ee)/api/programs/[programId]/submitted-leads/[leadId]/comments/route.ts+++ b/apps/web/app/(ee)/api/programs/[programId]/submitted-leads/[leadId]/comments/route.ts@@ -33,6 +33,7 @@ export const GET = withWorkspace();},{+ requiredPermissions: ["messages.read"],requiredPlan: ["business", "advanced", "enterprise"],},);diff --git a/apps/web/tests/misc/submitted-lead-comment-access.test.ts b/apps/web/tests/misc/submitted-lead-comment-access.test.tsindex eae4915d8e..c8b4cb9090 100644--- a/apps/web/tests/misc/submitted-lead-comment-access.test.ts+++ b/apps/web/tests/misc/submitted-lead-comment-access.test.ts@@ -6,10 +6,16 @@ const mocks = vi.hoisted(() => ({findLead: vi.fn(),findComments: vi.fn(),enrollment: vi.fn(),+ workspaceOptions: undefined as unknown,}));// Test the route's access rules. The middleware supplies authentication.-vi.mock("@/lib/auth", () => ({ withWorkspace: (handler: unknown) => handler }));+vi.mock("@/lib/auth", () => ({+ withWorkspace: (handler: unknown, options: unknown) => {+ mocks.workspaceOptions = options;+ return handler;+ },+}));vi.mock("@/lib/auth/partner", () => ({withPartnerProfile: (handler: unknown) => handler,}));@@ -118,6 +124,12 @@ describe("submitted lead comment access", () => {expect(mocks.findComments).not.toHaveBeenCalled();});+ it("requires the messages.read permission on the workspace route", () => {+ expect(mocks.workspaceOptions).toMatchObject({+ requiredPermissions: ["messages.read"],+ });+ });+it("returns private and visible comments to the owning workspace", async () => {const response = await readWorkspaceComments(context);