The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Fix Deep View when `deepviewData` is null (#3951)
Pedro Ladeira624ebd4337cf
diff --git a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/action-buttons.tsx b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/action-buttons.tsxindex f6078d3a9b..93ac7c28dd 100644--- a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/action-buttons.tsx+++ b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/action-buttons.tsx@@ -1,10 +1,9 @@"use client";-import { deepViewDataSchema } from "@/lib/zod/schemas/deep-links";+import { DeepViewData } from "@/lib/zod/schemas/deep-links";import { Link } from "@dub/prisma/client";import { Button, useCopyToClipboard } from "@dub/ui";import { useSearchParams } from "next/navigation";-import * as z from "zod/v4";import { getTranslations, Language } from "./translations";export function DeepLinkActionButtons({@@ -14,7 +13,7 @@ export function DeepLinkActionButtons({}: {link: Pick<Link, "shortLink">;language: Language;- buttonStyle?: z.infer<typeof deepViewDataSchema>["buttonStyle"];+ buttonStyle?: DeepViewData["buttonStyle"];}) {const t = getTranslations(language);const searchParams = useSearchParams();diff --git a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/page.tsx b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/page.tsxindex 3d0f2e315f..3b01cc8640 100644--- a/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/page.tsx+++ b/apps/web/app/app.dub.co/(deeplink)/deeplink/[domain]/[[...key]]/page.tsx@@ -2,7 +2,7 @@ import {decodeLinkIfCaseSensitive,encodeKeyIfCaseSensitive,} from "@/lib/api/links/case-sensitivity";-import { deepViewDataSchema } from "@/lib/zod/schemas/deep-links";+import { parseDeepViewData } from "@/lib/zod/schemas/deep-links";import { prisma } from "@dub/prisma";import { Grid, Wordmark } from "@dub/ui";import {@@ -73,20 +73,23 @@ export default async function DeepLinkPreviewPage(props: {redirect(`https://${domain}`);}- const deepViewData = deepViewDataSchema.parse(link.shortDomain.deepviewData);+ const { appleAppSiteAssociation, assetLinks, deepviewData } =+ link.shortDomain;// if the domain isn't set up for deep linking on the user's platform, skip// the preview and forward to the platform-specific URL (or the canonical URL)if (platform === "android") {- if (!link.shortDomain.assetLinks || !deepViewData) {+ if (!assetLinks || !deepviewData) {redirect(link.android ?? link.url);}} else {- if (!link.shortDomain.appleAppSiteAssociation || !deepViewData) {+ if (!appleAppSiteAssociation || !deepviewData) {redirect(link.ios ?? link.url);}}+ const deepViewData = parseDeepViewData(deepviewData);+// decode the link if the domain is case sensitivelink = decodeLinkIfCaseSensitive(link);@@ -100,7 +103,7 @@ export default async function DeepLinkPreviewPage(props: {appName = getApexDomain(link.url),variant,buttonStyle,- } = deepViewData ?? {};+ } = deepViewData;const description = t.description.replace("{appName}", appName);diff --git a/apps/web/lib/zod/schemas/deep-links.ts b/apps/web/lib/zod/schemas/deep-links.tsindex 706df27e07..ef8a68acbb 100644--- a/apps/web/lib/zod/schemas/deep-links.ts+++ b/apps/web/lib/zod/schemas/deep-links.ts@@ -1,18 +1,26 @@import * as z from "zod/v4";-export const deepViewDataSchema = z- .object({- hidePoweredByBadge: z.boolean().optional(),- appName: z.string().trim().min(1).optional(),- variant: z.enum(["default", "minimal"]).default("default"),- buttonStyle: z- .object({- backgroundColor: z.string().trim().min(1).optional(),- borderColor: z.string().trim().min(1).optional(),- borderRadius: z.string().trim().min(1).optional(),- })- .optional(),- })- .default({- variant: "default",- });+const deepViewDataObjectSchema = z.object({+ hidePoweredByBadge: z.boolean().optional(),+ appName: z.string().trim().min(1).optional(),+ variant: z.enum(["default", "minimal"]).default("default"),+ buttonStyle: z+ .object({+ backgroundColor: z.string().trim().min(1).optional(),+ borderColor: z.string().trim().min(1).optional(),+ borderRadius: z.string().trim().min(1).optional(),+ })+ .optional(),+});++export const deepViewDataSchema = z.preprocess(+ (val) => (val == null ? {} : val),+ deepViewDataObjectSchema,+);++export type DeepViewData = z.infer<typeof deepViewDataObjectSchema>;++export const parseDeepViewData = (data: unknown): DeepViewData => {+ const result = deepViewDataSchema.safeParse(data);+ return result.success ? result.data : { variant: "default" };+};