Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

allow turning off conversion tracking on free plans

Steven Tey66b044ecea4d
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/conversion-tracking-toggle.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/conversion-tracking-toggle.tsx
index e9b8355aa7..14b35d4aa5 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/conversion-tracking-toggle.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/settings/tracking/conversion-tracking-toggle.tsx
@@ -73,6 +73,9 @@ export function ConversionTrackingToggle() {
const { canTrackConversions } = getPlanCapabilities(plan);
+ // Allow turning conversion tracking off even if the plan no longer supports it
+ const isPlanLocked = !canTrackConversions && !conversionEnabled;
+
const { isMobile } = useMediaQuery();
if (isMobile) return null;
@@ -80,7 +83,7 @@ export function ConversionTrackingToggle() {
return (
<Tooltip
content={
- !canTrackConversions ? (
+ isPlanLocked ? (
<TooltipContent
title="You can only enable conversion tracking on Business plans and above."
cta="Upgrade to Business"
@@ -107,18 +110,18 @@ export function ConversionTrackingToggle() {
"transition-colors duration-100 ease-out",
conversionEnabled &&
"bg-bg-inverted text-content-inverted border-bg-inverted",
- (!canTrackConversions || permissionsError) &&
+ (isPlanLocked || permissionsError) &&
"cursor-not-allowed opacity-50",
)}
>
<span className="text-sm font-medium">Conversion tracking</span>
<Switch
checked={conversionEnabled}
- disabled={isSubmitting || !canTrackConversions || !!permissionsError}
+ disabled={isSubmitting || isPlanLocked || !!permissionsError}
fn={handleConversionUpdate}
trackDimensions="radix-state-checked:bg-neutral-600 focus-visible:ring-black/20"
thumbIcon={
- !canTrackConversions ? (
+ isPlanLocked ? (
<CrownSmall className="size-full text-neutral-500" />
) : undefined
}
diff --git a/apps/web/ui/links/link-builder/conversion-tracking-toggle.tsx b/apps/web/ui/links/link-builder/conversion-tracking-toggle.tsx
index 2647087cd3..a853c047f5 100644
--- a/apps/web/ui/links/link-builder/conversion-tracking-toggle.tsx
+++ b/apps/web/ui/links/link-builder/conversion-tracking-toggle.tsx
@@ -26,10 +26,13 @@ export const ConversionTrackingToggle = memo(() => {
name: ["trackConversion", "testVariants"],
});
+ // Allow turning conversion tracking off even if the plan no longer supports it
+ const isPlanLocked = !conversionsEnabled && !trackConversion;
+
useLinkBuilderKeyboardShortcut(
"c",
() => setValue("trackConversion", !trackConversion, { shouldDirty: true }),
- { enabled: conversionsEnabled },
+ { enabled: !isPlanLocked },
);
return (
@@ -59,23 +62,23 @@ export const ConversionTrackingToggle = memo(() => {
disabledTooltip={
trackConversion && testVariants ? (
<TooltipContent title="Conversion tracking must be enabled to use A/B testing." />
- ) : conversionsEnabled ? undefined : (
+ ) : isPlanLocked ? (
<TooltipContent
title="Conversion tracking is only available on Business plans and above."
cta="Upgrade to Business"
href={slug ? `/${slug}/upgrade` : "https://dub.co/pricing"}
target="_blank"
/>
- )
+ ) : undefined
}
thumbIcon={
trackConversion && testVariants ? (
<span className="flex size-full items-center justify-center">
<FlaskSmall className="size-2 text-blue-500" />
</span>
- ) : conversionsEnabled ? undefined : (
+ ) : isPlanLocked ? (
<CrownSmall className="size-full text-neutral-500" />
- )
+ ) : undefined
}
/>
</label>