Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Consolidate workspace environment checks into sandbox/workspace-guards

Kiran K6b182382aad3
diff --git a/apps/web/app/(ee)/api/stripe/integration/route.ts b/apps/web/app/(ee)/api/stripe/integration/route.ts
index c2944ecdc4..aaa3b71e28 100644
--- a/apps/web/app/(ee)/api/stripe/integration/route.ts
+++ b/apps/web/app/(ee)/api/stripe/integration/route.ts
@@ -3,8 +3,8 @@ import { parseRequestBody } from "@/lib/api/utils";
import { withWorkspace } from "@/lib/auth";
import { stripeIntegrationSettingsSchema } from "@/lib/integrations/stripe/schema";
import { prisma } from "@/lib/prisma";
+import { assertProductionWorkspace } from "@/lib/sandbox/workspace-guards";
import { capitalize, STRIPE_INTEGRATION_ID } from "@dub/utils";
-import { WorkspaceEnvironment } from "@prisma/client";
import { waitUntil } from "@vercel/functions";
import { NextResponse } from "next/server";
import * as z from "zod/v4";
@@ -33,15 +33,10 @@ export const PATCH = withWorkspace(
});
}
- if (
- stripeMode === "live" &&
- workspace.environment !== WorkspaceEnvironment.production
- ) {
- throw new DubApiError({
- code: "bad_request",
- message: `Live Stripe mode cannot be used in ${capitalize(workspace.environment)} workspaces.`,
- });
- }
+ assertProductionWorkspace(workspace, {
+ when: stripeMode === "live",
+ message: `Live Stripe mode cannot be used in ${capitalize(workspace.environment)} workspaces.`,
+ });
const installation = await prisma.installedIntegration.findUnique({
where: {
diff --git a/apps/web/app/api/user/route.ts b/apps/web/app/api/user/route.ts
index 8ac63b6ad2..37a694e8df 100644
--- a/apps/web/app/api/user/route.ts
+++ b/apps/web/app/api/user/route.ts
@@ -2,6 +2,7 @@ import { DubApiError } from "@/lib/api/errors";
import { withSession } from "@/lib/auth";
import { confirmEmailChange } from "@/lib/auth/confirm-email-change";
import { prisma } from "@/lib/prisma";
+import { assertProductionWorkspace } from "@/lib/sandbox/workspace-guards";
import { storage } from "@/lib/storage";
import { uploadedImageSchema } from "@/lib/zod/schemas/images";
import {
@@ -12,7 +13,6 @@ import {
nanoid,
trim,
} from "@dub/utils";
-import { WorkspaceEnvironment } from "@prisma/client";
import { waitUntil } from "@vercel/functions";
import { NextResponse } from "next/server";
import * as z from "zod/v4";
@@ -100,12 +100,9 @@ export const PATCH = withSession(async ({ req, session }) => {
});
}
- if (workspaceUser.project.environment !== WorkspaceEnvironment.production) {
- throw new DubApiError({
- code: "bad_request",
- message: `You can only set your default workspace to a production workspace.`,
- });
- }
+ assertProductionWorkspace(workspaceUser.project, {
+ message: `You can only set your default workspace to a production workspace.`,
+ });
}
// Verify email ownership if the email is being changed
diff --git a/apps/web/app/api/workspaces/[idOrSlug]/billing/payment-methods/route.ts b/apps/web/app/api/workspaces/[idOrSlug]/billing/payment-methods/route.ts
index 5aafc37f8a..3ee30a6b76 100644
--- a/apps/web/app/api/workspaces/[idOrSlug]/billing/payment-methods/route.ts
+++ b/apps/web/app/api/workspaces/[idOrSlug]/billing/payment-methods/route.ts
@@ -7,6 +7,7 @@ import {
PAYMENT_METHOD_TYPES,
} from "@/lib/constants/payouts";
import { SANDBOX_PAYMENT_METHOD } from "@/lib/sandbox/mock-payment-provider";
+import { assertProductionWorkspace } from "@/lib/sandbox/workspace-guards";
import { stripe } from "@/lib/stripe";
import { APP_DOMAIN } from "@dub/utils";
import { capitalize } from "@dub/utils/src";
@@ -118,12 +119,9 @@ export const POST = withWorkspace(
});
}
- if (workspace.environment !== WorkspaceEnvironment.production) {
- throw new DubApiError({
- code: "bad_request",
- message: `You can't add a payment methods to the ${capitalize(workspace.environment)} workspace.`,
- });
- }
+ assertProductionWorkspace(workspace, {
+ message: `You can't add a payment methods to the ${capitalize(workspace.environment)} workspace.`,
+ });
const { method } = addPaymentMethodSchema.parse(
await parseRequestBody(req),
diff --git a/apps/web/app/api/workspaces/[idOrSlug]/invites/reset/route.ts b/apps/web/app/api/workspaces/[idOrSlug]/invites/reset/route.ts
index a6e1881bb1..7aaf9706f5 100644
--- a/apps/web/app/api/workspaces/[idOrSlug]/invites/reset/route.ts
+++ b/apps/web/app/api/workspaces/[idOrSlug]/invites/reset/route.ts
@@ -1,12 +1,12 @@
import { withWorkspace } from "@/lib/auth";
import { prisma } from "@/lib/prisma";
-import { throwIfStagingWorkspace } from "@/lib/sandbox/throw-if-staging-workspace";
+import { assertNotStagingWorkspace } from "@/lib/sandbox/workspace-guards";
import { nanoid } from "@dub/utils";
import { NextResponse } from "next/server";
export const POST = withWorkspace(
async ({ workspace }) => {
- throwIfStagingWorkspace(workspace);
+ assertNotStagingWorkspace(workspace);
const response = await prisma.project.update({
where: {
diff --git a/apps/web/app/api/workspaces/[idOrSlug]/invites/route.ts b/apps/web/app/api/workspaces/[idOrSlug]/invites/route.ts
index 6042d25b74..2c0fc52601 100644
--- a/apps/web/app/api/workspaces/[idOrSlug]/invites/route.ts
+++ b/apps/web/app/api/workspaces/[idOrSlug]/invites/route.ts
@@ -4,7 +4,7 @@ import { assertRoleAllowedForPlan } from "@/lib/api/workspaces/assert-role-plan"
import { withWorkspace } from "@/lib/auth";
import { exceededLimitError } from "@/lib/exceeded-limit-error";
import { prisma } from "@/lib/prisma";
-import { throwIfStagingWorkspace } from "@/lib/sandbox/throw-if-staging-workspace";
+import { assertNotStagingWorkspace } from "@/lib/sandbox/workspace-guards";
import { ratelimit, redis } from "@/lib/upstash";
import { inviteTeammatesSchema } from "@/lib/zod/schemas/invites";
import {
@@ -49,7 +49,7 @@ export const GET = withWorkspace(
// POST /api/workspaces/[idOrSlug]/invites – invite a teammate
export const POST = withWorkspace(
async ({ req, workspace, session }) => {
- throwIfStagingWorkspace(workspace);
+ assertNotStagingWorkspace(workspace);
const { teammates } = inviteTeammatesSchema.parse(await req.json());
@@ -182,7 +182,7 @@ const updateInviteRoleSchema = z.object({
// PATCH /api/workspaces/[idOrSlug]/invites - update an invite's role
export const PATCH = withWorkspace(
async ({ req, workspace }) => {
- throwIfStagingWorkspace(workspace);
+ assertNotStagingWorkspace(workspace);
const { email, role } = updateInviteRoleSchema.parse(await req.json());
@@ -229,7 +229,7 @@ export const PATCH = withWorkspace(
// DELETE /api/workspaces/[idOrSlug]/invites – delete a pending invite
export const DELETE = withWorkspace(
async ({ searchParams, workspace }) => {
- throwIfStagingWorkspace(workspace);
+ assertNotStagingWorkspace(workspace);
const { email } = z
.object({
diff --git a/apps/web/app/api/workspaces/[idOrSlug]/route.ts b/apps/web/app/api/workspaces/[idOrSlug]/route.ts
index 363c0793f8..83b8a2f842 100644
--- a/apps/web/app/api/workspaces/[idOrSlug]/route.ts
+++ b/apps/web/app/api/workspaces/[idOrSlug]/route.ts
@@ -9,7 +9,7 @@ import { getFeatureFlags } from "@/lib/edge-config";
import { jackson } from "@/lib/jackson";
import { prisma } from "@/lib/prisma";
import { syncWorkspaceSettings } from "@/lib/sandbox/sync-workspace";
-import { throwIfStagingWorkspace } from "@/lib/sandbox/throw-if-staging-workspace";
+import { assertNotStagingWorkspace } from "@/lib/sandbox/workspace-guards";
import { mergeSiteVisitTrackingSettings } from "@/lib/sitemaps/site-visit-tracking";
import { storage } from "@/lib/storage";
import { redis } from "@/lib/upstash";
@@ -98,7 +98,7 @@ export const PATCH = withWorkspace(
siteVisitTrackingSettings,
} = await updateWorkspaceSchema.parseAsync(await parseRequestBody(req));
- throwIfStagingWorkspace(workspace, {
+ assertNotStagingWorkspace(workspace, {
when: !!(name || slug || logo),
});
@@ -311,7 +311,7 @@ export const DELETE = withWorkspace(
});
}
- throwIfStagingWorkspace(workspace);
+ assertNotStagingWorkspace(workspace);
await deleteWorkspace(workspace);
diff --git a/apps/web/app/api/workspaces/[idOrSlug]/users/route.ts b/apps/web/app/api/workspaces/[idOrSlug]/users/route.ts
index ced0211c13..728c840919 100644
--- a/apps/web/app/api/workspaces/[idOrSlug]/users/route.ts
+++ b/apps/web/app/api/workspaces/[idOrSlug]/users/route.ts
@@ -8,7 +8,7 @@ import {
removeMemberFromStaging,
updateMemberRoleInStaging,
} from "@/lib/sandbox/sync-workspace";
-import { throwIfStagingWorkspace } from "@/lib/sandbox/throw-if-staging-workspace";
+import { assertNotStagingWorkspace } from "@/lib/sandbox/workspace-guards";
import {
getWorkspaceUsersQuerySchema,
workspaceUserSchema,
@@ -65,7 +65,7 @@ const updateRoleSchema = z.object({
// PATCH /api/workspaces/[idOrSlug]/users – update a user's role for a specific workspace
export const PATCH = withWorkspace(
async ({ req, workspace }) => {
- throwIfStagingWorkspace(workspace);
+ assertNotStagingWorkspace(workspace);
const { userId, role } = updateRoleSchema.parse(await req.json());
@@ -158,7 +158,7 @@ export const DELETE = withWorkspace(
});
}
- throwIfStagingWorkspace(workspace, {
+ assertNotStagingWorkspace(workspace, {
when: !projectUser.user.isMachine,
});
diff --git a/apps/web/lib/sandbox/copy-discount-to-live.ts b/apps/web/lib/sandbox/copy-discount-to-live.ts
index 971016a059..f8c26ef5ae 100644
--- a/apps/web/lib/sandbox/copy-discount-to-live.ts
+++ b/apps/web/lib/sandbox/copy-discount-to-live.ts
@@ -1,6 +1,7 @@
"use server";
import { prisma } from "@/lib/prisma";
+import { assertProductionWorkspace } from "@/lib/sandbox/workspace-guards";
import { APP_DOMAIN_WITH_NGROK } from "@dub/utils";
import { WorkspaceEnvironment } from "@prisma/client";
import { waitUntil } from "@vercel/functions";
@@ -84,9 +85,9 @@ export const copyDiscountToLiveAction = authActionClient
requiredRoles: ["owner", "member"],
});
- if (targetWorkspace.environment !== WorkspaceEnvironment.production) {
- throw new Error("Discount can only be copied to a live program.");
- }
+ assertProductionWorkspace(targetWorkspace, {
+ message: "Discount can only be copied to a live program.",
+ });
const discount = await getDiscountOrThrow({
discountId,
diff --git a/apps/web/lib/sandbox/copy-reward-to-live.ts b/apps/web/lib/sandbox/copy-reward-to-live.ts
index a6c3b31df1..e1288a5a59 100644
--- a/apps/web/lib/sandbox/copy-reward-to-live.ts
+++ b/apps/web/lib/sandbox/copy-reward-to-live.ts
@@ -1,6 +1,7 @@
"use server";
import { prisma } from "@/lib/prisma";
+import { assertProductionWorkspace } from "@/lib/sandbox/workspace-guards";
import { WorkspaceEnvironment } from "@prisma/client";
import { waitUntil } from "@vercel/functions";
import { authActionClient } from "../actions/safe-action";
@@ -77,9 +78,9 @@ export const copyRewardToLiveAction = authActionClient
requiredRoles: ["owner", "member"],
});
- if (targetWorkspace.environment !== WorkspaceEnvironment.production) {
- throw new Error("Reward can only be copied to a live program.");
- }
+ assertProductionWorkspace(targetWorkspace, {
+ message: "Reward can only be copied to a live program.",
+ });
const reward = await getRewardOrThrow({
rewardId,
diff --git a/apps/web/lib/sandbox/throw-if-staging-workspace.ts b/apps/web/lib/sandbox/workspace-guards.ts
similarity index 52%
rename from apps/web/lib/sandbox/throw-if-staging-workspace.ts
rename to apps/web/lib/sandbox/workspace-guards.ts
index 52f7606a7b..aa8b94d117 100644
--- a/apps/web/lib/sandbox/throw-if-staging-workspace.ts
+++ b/apps/web/lib/sandbox/workspace-guards.ts
@@ -1,7 +1,7 @@
import { DubApiError } from "@/lib/api/errors";
import { Project, WorkspaceEnvironment } from "@prisma/client";
-export function throwIfStagingWorkspace(
+export function assertNotStagingWorkspace(
workspace: Pick<Project, "environment">,
options?: {
when?: boolean;
@@ -19,3 +19,25 @@ export function throwIfStagingWorkspace(
});
}
}
+
+export function assertProductionWorkspace(
+ workspace: Pick<Project, "environment">,
+ options?: {
+ when?: boolean;
+ message?: string;
+ },
+) {
+ const shouldCheck = options?.when ?? true;
+
+ if (
+ shouldCheck &&
+ workspace.environment !== WorkspaceEnvironment.production
+ ) {
+ throw new DubApiError({
+ code: "bad_request",
+ message:
+ options?.message ??
+ "This action is only available in production workspaces.",
+ });
+ }
+}