Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Keep sale amounts hidden when group or enrollment data is missing.

Kiran K6b66ceb85a98
diff --git a/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts b/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts
index 6a8c901dd4..a2ee41faca 100644
--- a/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts
+++ b/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts
@@ -589,6 +589,7 @@ async function stepRunSideEffects(
groups: {
select: {
holdingPeriodDays: true,
+ revenueDataSharingDisabledAt: true,
},
where: {
slug: DEFAULT_PARTNER_GROUP.slug,
diff --git a/apps/web/lib/postback/send-partner-postback.ts b/apps/web/lib/postback/send-partner-postback.ts
index cf6d16bb48..f4728d40c0 100644
--- a/apps/web/lib/postback/send-partner-postback.ts
+++ b/apps/web/lib/postback/send-partner-postback.ts
@@ -60,12 +60,32 @@ export const sendPartnerPostback = async ({
programId &&
(event === "sale.created" || event === "commission.created")
) {
- enrichedData = await applyPostbackRevenueVisibility({
- partnerId,
- programId,
- event,
- data: enrichedData,
- });
+ try {
+ const visibleData = await applyPostbackRevenueVisibility({
+ partnerId,
+ programId,
+ event,
+ data: enrichedData,
+ });
+
+ if (!visibleData) {
+ console.error(
+ "[sendPartnerPostback] No program enrollment found for revenue visibility",
+ { partnerId, programId, event },
+ );
+ return;
+ }
+
+ enrichedData = visibleData;
+ } catch (error) {
+ console.error("[sendPartnerPostback] Error applying revenue visibility", {
+ partnerId,
+ programId,
+ event,
+ error,
+ });
+ return;
+ }
}
const adapters = postbacks.map((postback) => {
@@ -102,7 +122,7 @@ async function applyPostbackRevenueVisibility({
programId: string;
event: "sale.created" | "commission.created";
data: Record<string, unknown>;
-}): Promise<Record<string, unknown>> {
+}): Promise<Record<string, unknown> | null> {
const enrollment = await prisma.programEnrollment.findUnique({
where: {
partnerId_programId: {
@@ -119,7 +139,11 @@ async function applyPostbackRevenueVisibility({
},
});
- if (!isPartnerRevenueHidden(enrollment?.partnerGroup)) {
+ if (!enrollment) {
+ return null;
+ }
+
+ if (!isPartnerRevenueHidden(enrollment.partnerGroup)) {
return data;
}