Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Null sale amounts in partner postbacks when revenue sharing is disabled.

Kiran K6c298481ab7e
diff --git a/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts b/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts
index fc7284c2d1..2c1d9e54c0 100644
--- a/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts
+++ b/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts
@@ -609,6 +609,7 @@ export async function checkoutSessionCompleted({
? [
sendPartnerPostback({
partnerId: link.partnerId,
+ programId: link.programId,
event: "sale.created",
data: {
...saleData,
diff --git a/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts b/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts
index 579d1baa09..436ef69c4e 100644
--- a/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts
+++ b/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts
@@ -418,6 +418,7 @@ export async function invoicePaid({
? [
sendPartnerPostback({
partnerId: link.partnerId,
+ programId: link.programId,
event: "sale.created",
data: {
...saleData,
diff --git a/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts b/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts
index 6631fa2d01..6a8c901dd4 100644
--- a/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts
+++ b/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts
@@ -717,6 +717,7 @@ async function stepRunSideEffects(
sendPartnerPostback({
partnerId,
+ programId,
event: "commission.created",
data: commission,
}),
diff --git a/apps/web/lib/api/conversions/track-sale.ts b/apps/web/lib/api/conversions/track-sale.ts
index aa8c857ef5..b5babd8296 100644
--- a/apps/web/lib/api/conversions/track-sale.ts
+++ b/apps/web/lib/api/conversions/track-sale.ts
@@ -670,6 +670,7 @@ const _trackSale = async ({
? [
sendPartnerPostback({
partnerId: link.partnerId,
+ programId: link.programId,
event: "sale.created",
data: {
...saleData,
diff --git a/apps/web/lib/integrations/shopify/create-sale.ts b/apps/web/lib/integrations/shopify/create-sale.ts
index 3add12c479..4c031e8eee 100644
--- a/apps/web/lib/integrations/shopify/create-sale.ts
+++ b/apps/web/lib/integrations/shopify/create-sale.ts
@@ -212,6 +212,7 @@ export async function createShopifySale({
? [
sendPartnerPostback({
partnerId: link.partnerId,
+ programId: link.programId,
event: "sale.created",
data: {
...saleData,
diff --git a/apps/web/lib/partner-referrals/create-referral-commission.ts b/apps/web/lib/partner-referrals/create-referral-commission.ts
index 95be38becc..72c11d2cfa 100644
--- a/apps/web/lib/partner-referrals/create-referral-commission.ts
+++ b/apps/web/lib/partner-referrals/create-referral-commission.ts
@@ -292,6 +292,7 @@ export const createReferralCommission = async (
sendPartnerPostback({
partnerId: referredByPartnerId,
+ programId,
event: "commission.created",
data: commission,
}),
diff --git a/apps/web/lib/partners/hide-partner-revenue.ts b/apps/web/lib/partners/hide-partner-revenue.ts
index cddc6e9c78..30293ddc3c 100644
--- a/apps/web/lib/partners/hide-partner-revenue.ts
+++ b/apps/web/lib/partners/hide-partner-revenue.ts
@@ -64,3 +64,29 @@ export function nullAnalyticsSaleAmounts<T>(data: T): T {
return data;
}
+
+/**
+ * Null sale dollar amounts on partner postback payloads.
+ * - sale.created: nested `sale.amount`
+ * - commission.created: top-level `amount`
+ */
+export function nullPostbackRevenue(
+ event: "sale.created" | "commission.created",
+ data: Record<string, unknown>,
+): Record<string, unknown> {
+ if (event === "commission.created") {
+ return { ...data, amount: null };
+ }
+
+ if (!data.sale || typeof data.sale !== "object") {
+ return data;
+ }
+
+ return {
+ ...data,
+ sale: {
+ ...(data.sale as Record<string, unknown>),
+ amount: null,
+ },
+ };
+}
diff --git a/apps/web/lib/postback/send-partner-postback.ts b/apps/web/lib/postback/send-partner-postback.ts
index fe3c56b70a..7fbdcedcef 100644
--- a/apps/web/lib/postback/send-partner-postback.ts
+++ b/apps/web/lib/postback/send-partner-postback.ts
@@ -1,3 +1,5 @@
+import { nullPostbackRevenue } from "@/lib/partners/hide-partner-revenue";
+import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import { POSTBACK_EVENT_ID_PREFIX } from "@/lib/postback/constants";
import { prisma } from "@/lib/prisma";
import { PostbackTrigger } from "@/lib/types";
@@ -12,6 +14,7 @@ interface SendPartnerPostbackParams {
data: Record<string, unknown>;
skipEnrichment?: boolean; // Skip enrichment if the data is already enriched when sending a test event
isTest?: boolean;
+ programId?: string | null;
}
export const sendPartnerPostback = async ({
@@ -20,6 +23,7 @@ export const sendPartnerPostback = async ({
data,
skipEnrichment = false,
isTest = false,
+ programId,
}: SendPartnerPostbackParams) => {
const postbacks = await prisma.postback.findMany({
where: {
@@ -40,7 +44,7 @@ export const sendPartnerPostback = async ({
return;
}
- let enrichedData: Record<string, unknown> | undefined;
+ let enrichedData: Record<string, unknown>;
try {
enrichedData =
@@ -52,6 +56,18 @@ export const sendPartnerPostback = async ({
return;
}
+ if (
+ programId &&
+ (event === "sale.created" || event === "commission.created")
+ ) {
+ enrichedData = await applyPostbackRevenueVisibility({
+ partnerId,
+ programId,
+ event,
+ data: enrichedData,
+ });
+ }
+
const adapters = postbacks.map((postback) => {
switch (postback.receiver) {
case "custom":
@@ -74,3 +90,38 @@ export const sendPartnerPostback = async ({
),
);
};
+
+/** Null sale dollar amounts on postback payloads when the partner group hides revenue. */
+async function applyPostbackRevenueVisibility({
+ partnerId,
+ programId,
+ event,
+ data,
+}: {
+ partnerId: string;
+ programId: string;
+ event: "sale.created" | "commission.created";
+ data: Record<string, unknown>;
+}): Promise<Record<string, unknown>> {
+ const enrollment = await prisma.programEnrollment.findUnique({
+ where: {
+ partnerId_programId: {
+ partnerId,
+ programId,
+ },
+ },
+ select: {
+ partnerGroup: {
+ select: {
+ revenueDataSharingDisabledAt: true,
+ },
+ },
+ },
+ });
+
+ if (!isPartnerRevenueHidden(enrollment?.partnerGroup)) {
+ return data;
+ }
+
+ return nullPostbackRevenue(event, data);
+}
diff --git a/apps/web/tests/partner-groups/index.test.ts b/apps/web/tests/partner-groups/index.test.ts
index 76303d47b2..4525675bb1 100644
--- a/apps/web/tests/partner-groups/index.test.ts
+++ b/apps/web/tests/partner-groups/index.test.ts
@@ -25,6 +25,7 @@ const expectedGroup: Partial<GroupProps> = {
holdingPeriodDays: expect.any(Number),
brandColor: null,
autoApprovePartnersEnabledAt: null,
+ revenueDataSharingDisabledAt: null,
submittedLeadsEnabledAt: null,
clickReward: null,
leadReward: null,
@@ -77,6 +78,7 @@ describe.sequential("/groups/**", async () => {
linkStructure: defaultGroup.linkStructure,
holdingPeriodDays: defaultGroup.holdingPeriodDays,
autoApprovePartnersEnabledAt: defaultGroup.autoApprovePartnersEnabledAt,
+ revenueDataSharingDisabledAt: defaultGroup.revenueDataSharingDisabledAt,
submittedLeadsEnabledAt: defaultGroup.submittedLeadsEnabledAt,
});
@@ -145,6 +147,31 @@ describe.sequential("/groups/**", async () => {
group = updatedGroup;
});
+ test("PATCH /groups/[groupId] - hide revenue from partners", async () => {
+ const { status, data: updatedGroup } = await http.patch<GroupProps>({
+ path: `/groups/${group.id}`,
+ body: {
+ revenueDataSharingDisabled: true,
+ },
+ });
+
+ expect(status).toEqual(200);
+ expect(updatedGroup.revenueDataSharingDisabledAt).toEqual(expect.any(String));
+
+ const { status: clearStatus, data: clearedGroup } =
+ await http.patch<GroupProps>({
+ path: `/groups/${group.id}`,
+ body: {
+ revenueDataSharingDisabled: false,
+ },
+ });
+
+ expect(clearStatus).toEqual(200);
+ expect(clearedGroup.revenueDataSharingDisabledAt).toBeNull();
+
+ group = clearedGroup;
+ });
+
test("PATCH /groups/[groupId] - update group with group move rule", async () => {
const moveRules = [
{