Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Flaky partners onboarding logo upload assertion (#4345)

Pedro Ladeira6d57d49df4c1
diff --git a/apps/web/playwright/workspaces/onboarding-dub-partners.spec.ts b/apps/web/playwright/workspaces/onboarding-dub-partners.spec.ts
index f879253c8c..e2c0580b1c 100644
--- a/apps/web/playwright/workspaces/onboarding-dub-partners.spec.ts
+++ b/apps/web/playwright/workspaces/onboarding-dub-partners.spec.ts
@@ -1,5 +1,5 @@
import { nanoid } from "@dub/utils";
-import { expect, test } from "@playwright/test";
+import { expect, test, type Page } from "@playwright/test";
import {
finishOnboardingCheckoutWithoutStripeRedirect,
installBillingCheckoutMocks,
@@ -10,6 +10,41 @@ const MINIMAL_PNG = Buffer.from(
"base64",
);
+/** Host Playwright intercepts for the R2 PUT. CI has no STORAGE_*. */
+const MOCK_SIGNED_URL = "https://storage.example.test/e2e-program-logo";
+const MOCK_DESTINATION_URL =
+ "https://assets.example.test/program-logos/e2e.png";
+
+/** Stubs POST /upload-url and the follow-up PUT so onboarding does not need R2. */
+async function installProgramLogoUploadMocks(page: Page) {
+ await page.route(
+ (url) => url.pathname.endsWith("/upload-url"),
+ async (route) => {
+ if (route.request().method() !== "POST") {
+ await route.continue();
+ return;
+ }
+ await route.fulfill({
+ status: 200,
+ contentType: "application/json",
+ body: JSON.stringify({
+ key: "program-logos/e2e",
+ signedUrl: MOCK_SIGNED_URL,
+ destinationUrl: MOCK_DESTINATION_URL,
+ }),
+ });
+ },
+ );
+
+ await page.route(MOCK_SIGNED_URL, async (route) => {
+ if (route.request().method() !== "PUT") {
+ await route.continue();
+ return;
+ }
+ await route.fulfill({ status: 200, body: "" });
+ });
+}
+
function randomOnboardingDomain() {
const id = nanoid(10).replace(/_/g, "-").toLowerCase();
return `e2e-${id}.invalid`;
@@ -124,17 +159,29 @@ test.describe("Dub Partners onboarding", () => {
await page
.getByTestId("onboarding-program-company-name")
.fill(`Test Program ${nanoid(4)}`);
+
+ await installProgramLogoUploadMocks(page);
+
+ const uploadUrlPost = page.waitForResponse(
+ (r) =>
+ r.request().method() === "POST" &&
+ new URL(r.url()).pathname.endsWith("/upload-url"),
+ { timeout: STEP_NAV_TIMEOUT },
+ );
await page.getByTestId("onboarding-program-logo").setInputFiles({
name: "logo.png",
mimeType: "image/png",
buffer: MINIMAL_PNG,
});
- // skipping this for now since it's a bit flaky
- // await expect
- // .poll(async () => page.locator('img[alt="Preview"]').count(), {
- // timeout: 30_000,
- // })
- // .toBeGreaterThan(0);
+ const uploadUrlRes = await uploadUrlPost;
+ if (!uploadUrlRes.ok()) {
+ throw new Error(
+ `Logo upload-url failed: HTTP ${uploadUrlRes.status()} ${await uploadUrlRes.text()}`,
+ );
+ }
+ await expect(page.getByText("logo.png uploaded!")).toBeVisible({
+ timeout: 30_000,
+ });
await page
.getByTestId("onboarding-program-destination-url")