Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Show historical context in the Fraud review sheet (#3286)

Kiran K6e2f5b5a540a
diff --git a/apps/web/ui/partners/fraud-risks/commissions-on-hold-table.tsx b/apps/web/ui/partners/fraud-risks/commissions-on-hold-table.tsx
index 3d1cda3077..a3bba34f29 100644
--- a/apps/web/ui/partners/fraud-risks/commissions-on-hold-table.tsx
+++ b/apps/web/ui/partners/fraud-risks/commissions-on-hold-table.tsx
@@ -1,6 +1,5 @@
import useWorkspace from "@/lib/swr/use-workspace";
import { CommissionResponse, FraudGroupProps } from "@/lib/types";
-import { COMMISSIONS_MAX_PAGE_SIZE } from "@/lib/zod/schemas/commissions";
import { CustomerRowItem } from "@/ui/customers/customer-row-item";
import {
LoadingSpinner,
@@ -20,18 +19,18 @@ import { useState } from "react";
import useSWR from "swr";
import { CommissionTypeBadge } from "../commission-type-badge";
+const COMMISSIONS_ON_HOLD_PAGE_SIZE = 10;
+
export function CommissionsOnHoldTable({
fraudGroup,
}: {
fraudGroup: FraudGroupProps;
}) {
- const workspace = useWorkspace();
- const { id: workspaceId, slug } = workspace;
-
+ const { id: workspaceId, slug } = useWorkspace();
const [page, setPage] = useState(1);
const { pagination, setPagination } = useTablePagination({
- pageSize: COMMISSIONS_MAX_PAGE_SIZE,
+ pageSize: COMMISSIONS_ON_HOLD_PAGE_SIZE,
page,
onPageChange: setPage,
});
@@ -40,7 +39,6 @@ export function CommissionsOnHoldTable({
workspaceId: workspaceId!,
status: "pending",
partnerId: fraudGroup.partner.id,
- page: page.toString(),
};
const {
@@ -48,7 +46,11 @@ export function CommissionsOnHoldTable({
error,
isLoading,
} = useSWR<CommissionResponse[]>(
- `/api/commissions?${new URLSearchParams(query).toString()}`,
+ `/api/commissions?${new URLSearchParams({
+ ...query,
+ page: page.toString(),
+ pageSize: COMMISSIONS_ON_HOLD_PAGE_SIZE.toString(),
+ }).toString()}`,
fetcher,
{
keepPreviousData: true,
@@ -129,7 +131,7 @@ export function CommissionsOnHoldTable({
),
},
],
- ...((commissionsCount?.all.count || 0) > COMMISSIONS_MAX_PAGE_SIZE
+ ...((commissionsCount?.all.count || 0) > COMMISSIONS_ON_HOLD_PAGE_SIZE
? {
pagination,
onPaginationChange: setPagination,
diff --git a/apps/web/ui/partners/fraud-risks/fraud-review-sheet.tsx b/apps/web/ui/partners/fraud-risks/fraud-review-sheet.tsx
index 5909459d5f..dc326d98dc 100644
--- a/apps/web/ui/partners/fraud-risks/fraud-review-sheet.tsx
+++ b/apps/web/ui/partners/fraud-risks/fraud-review-sheet.tsx
@@ -26,6 +26,7 @@ import { Dispatch, SetStateAction } from "react";
import { CommissionsOnHoldTable } from "./commissions-on-hold-table";
import { FraudDisclaimerBanner } from "./fraud-disclaimer-banner";
import { FraudEventsTableWrapper } from "./fraud-events-tables";
+import { ResolvedFraudGroupTable } from "./resolved-fraud-group-table";
interface FraudReviewSheetProps {
fraudGroup: FraudGroupProps;
@@ -209,6 +210,10 @@ function FraudReviewSheetContent({
</div>
)}
+ {fraudGroup.status === "pending" && (
+ <ResolvedFraudGroupTable partnerId={partner.id} />
+ )}
+
{fraudGroup.status === "resolved" && (
<div>
<h3 className="text-content-emphasis mb-4 font-semibold">
diff --git a/apps/web/ui/partners/fraud-risks/resolved-fraud-group-table.tsx b/apps/web/ui/partners/fraud-risks/resolved-fraud-group-table.tsx
new file mode 100644
index 0000000000..918fa729cc
--- /dev/null
+++ b/apps/web/ui/partners/fraud-risks/resolved-fraud-group-table.tsx
@@ -0,0 +1,158 @@
+import { FRAUD_RULES_BY_TYPE } from "@/lib/api/fraud/constants";
+import { useFraudGroups } from "@/lib/swr/use-fraud-groups";
+import { FraudGroupProps } from "@/lib/types";
+import { UserRowItem } from "@/ui/users/user-row-item";
+import {
+ Badge,
+ buttonVariants,
+ LoadingSpinner,
+ Table,
+ Tooltip,
+ useTable,
+} from "@dub/ui";
+import { cn, formatDate } from "@dub/utils";
+import { Row } from "@tanstack/react-table";
+import Link from "next/link";
+
+const RESOLVED_FRAUD_GROUP_PAGE_SIZE = 10;
+
+export function ResolvedFraudGroupTable({ partnerId }: { partnerId: string }) {
+ const {
+ fraudGroups,
+ loading: fraudGroupsLoading,
+ error: fraudGroupsError,
+ } = useFraudGroups({
+ query: {
+ status: "resolved",
+ partnerId,
+ page: 1,
+ pageSize: RESOLVED_FRAUD_GROUP_PAGE_SIZE,
+ sortBy: "resolvedAt",
+ },
+ exclude: ["groupId"],
+ });
+
+ const table = useTable<FraudGroupProps>({
+ data: fraudGroups || [],
+ columns: [
+ {
+ id: "type",
+ header: "Event",
+ cell: ({ row }: { row: Row<FraudGroupProps> }) => {
+ const reason = FRAUD_RULES_BY_TYPE[row.original.type];
+ const count = row.original.eventCount ?? 1;
+
+ if (reason) {
+ return (
+ <div className="flex items-center gap-2">
+ <Tooltip content={reason.description}>
+ <span
+ className={cn(
+ "cursor-help truncate underline decoration-dotted underline-offset-2",
+ )}
+ >
+ {reason.name}
+ </span>
+ </Tooltip>
+
+ {count > 1 && (
+ <Badge
+ variant="gray"
+ className="shrink-0 rounded-md border-none px-1.5 py-1 text-xs font-semibold text-neutral-700"
+ >
+ +{Number(count) - 1}
+ </Badge>
+ )}
+ </div>
+ );
+ }
+ },
+ },
+ {
+ id: "resolvedAt",
+ header: "Resolved on",
+ cell: ({ row }: { row: Row<FraudGroupProps> }) => {
+ const user = row.original.user;
+ const resolvedAt = row.original.resolvedAt;
+
+ if (!resolvedAt) return "-";
+
+ if (!user)
+ return formatDate(resolvedAt, {
+ month: "short",
+ year: undefined,
+ });
+
+ return (
+ <UserRowItem user={user} date={resolvedAt} label="Resolved at" />
+ );
+ },
+ },
+ {
+ id: "resolutionReason",
+ header: "Note",
+ cell: ({ row }: { row: Row<FraudGroupProps> }) => {
+ const resolutionReason = row.original.resolutionReason;
+
+ if (!resolutionReason) return "-";
+
+ return (
+ <Tooltip content={resolutionReason}>
+ <span className="line-clamp-1 cursor-help truncate">
+ {resolutionReason}
+ </span>
+ </Tooltip>
+ );
+ },
+ },
+ ],
+ loading: fraudGroupsLoading,
+ thClassName: "border-l-0",
+ tdClassName: "border-l-0",
+ className: "[&_tr:last-child>td]:border-b-transparent",
+ scrollWrapperClassName: "min-h-0",
+ error: fraudGroupsError
+ ? "Failed to load resolved fraud events"
+ : undefined,
+ });
+
+ const displayViewAll =
+ fraudGroups?.length &&
+ fraudGroups.length === RESOLVED_FRAUD_GROUP_PAGE_SIZE;
+
+ return (
+ <div className="flex flex-col gap-4">
+ <div className="flex items-end justify-between gap-4">
+ <h3 className="text-content-emphasis font-semibold">Resolved events</h3>
+ {displayViewAll ? (
+ <Link
+ href={`/${"workspaceSlug"}/program/fraud/resolved?partnerId=${partnerId}`}
+ target="_blank"
+ className={cn(
+ buttonVariants({ variant: "secondary" }),
+ "flex h-7 items-center rounded-lg border px-2 text-sm",
+ )}
+ >
+ View all
+ </Link>
+ ) : null}
+ </div>
+
+ <div className="flex flex-col gap-3">
+ {fraudGroups?.length ? (
+ <Table {...table} />
+ ) : (
+ <div className="border-border-subtle flex h-24 flex-col items-center justify-center gap-2 rounded-lg border">
+ {fraudGroupsLoading ? (
+ <LoadingSpinner />
+ ) : (
+ <p className="text-content-subtle text-sm">
+ No past resolved fraud events found for this partner
+ </p>
+ )}
+ </div>
+ )}
+ </div>
+ </div>
+ );
+}