Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Fix division by zero producing Infinity in partner stats update (#3544)

Kiran K70a9f034af93
diff --git a/apps/web/app/(ee)/api/cron/streams/update-partner-stats/route.ts b/apps/web/app/(ee)/api/cron/streams/update-partner-stats/route.ts
index 8d7b227605..b68463feb4 100644
--- a/apps/web/app/(ee)/api/cron/streams/update-partner-stats/route.ts
+++ b/apps/web/app/(ee)/api/cron/streams/update-partner-stats/route.ts
@@ -154,10 +154,15 @@ const processPartnerActivityStreamBatch = () =>
const totalSaleAmountNum =
totalSaleAmount != null ? toCentsNumber(totalSaleAmount) : undefined;
const totalCommissionsNum =
- totalCommissions != null ? toCentsNumber(totalCommissions) : undefined;
+ totalCommissions != null
+ ? toCentsNumber(totalCommissions)
+ : undefined;
// Calculate netRevenue
- if (totalSaleAmountNum !== undefined && totalCommissionsNum !== undefined) {
+ if (
+ totalSaleAmountNum !== undefined &&
+ totalCommissionsNum !== undefined
+ ) {
enrollment.netRevenue = BigInt(
Math.round(totalSaleAmountNum - totalCommissionsNum),
);
@@ -190,7 +195,7 @@ const processPartnerActivityStreamBatch = () =>
}
// Calculate return on AdSpend (totalSaleAmount / totalCommissions)
- if (totalSaleAmountNum !== undefined && totalCommissionsNum !== undefined) {
+ if (totalSaleAmountNum !== undefined && totalCommissionsNum) {
enrollment.returnOnAdSpend = totalSaleAmountNum / totalCommissionsNum;
}
@@ -272,7 +277,9 @@ const processPartnerActivityStreamBatch = () =>
batch.map(async (programEnrollment) => {
const { programId, partnerId, ...stats } = programEnrollment;
const finalStatsToUpdate = Object.entries(stats).filter(
- ([_, value]) => value !== undefined,
+ ([_, value]) =>
+ value !== undefined &&
+ (typeof value !== "number" || Number.isFinite(value)),
);
try {