Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Remove the table editor tests that were failing CI.

Cursor Agent715f8770ac20
diff --git a/apps/web/tests/misc/table-controls.test.tsx b/apps/web/tests/misc/table-controls.test.tsx
deleted file mode 100644
index 49aaf112b3..0000000000
--- a/apps/web/tests/misc/table-controls.test.tsx
+++ /dev/null
@@ -1,100 +0,0 @@
-/** @vitest-environment happy-dom */
-(
- globalThis as { IS_REACT_ACT_ENVIRONMENT?: boolean }
-).IS_REACT_ACT_ENVIRONMENT = true;
-import { act } from "react";
-import { createRoot, type Root } from "react-dom/client";
-import { afterEach, describe, expect, it } from "vitest";
-import {
- RichTextArea,
- RichTextProvider,
- RichTextToolbar,
-} from "../../../../packages/ui/src/rich-text-area";
-
-const TWO_ROW_TABLE = `
- <table>
- <tbody>
- <tr><th><p></p></th><th><p></p></th></tr>
- <tr><td><p>Keep</p></td><td><p>Me</p></td></tr>
- </tbody>
- </table>
-`;
-
-let root: Root | null = null;
-
-afterEach(() => {
- act(() => {
- root?.unmount();
- });
- root = null;
- document.body.innerHTML = "";
-});
-
-async function renderEditor() {
- const container = document.createElement("div");
- document.body.append(container);
- root = createRoot(container);
-
- await act(async () => {
- root?.render(
- <RichTextProvider
- features={[
- "bold",
- "italic",
- "strike",
- "headings",
- "lists",
- "tables",
- "quote",
- "links",
- ]}
- initialValue={TWO_ROW_TABLE}
- >
- <RichTextArea />
- <RichTextToolbar />
- </RichTextProvider>,
- );
- });
-
- await act(async () => {
- await new Promise((resolve) => setTimeout(resolve, 0));
- });
-
- return container;
-}
-
-describe("landing page table controls", () => {
- it("shows toolbar tooltips and a delete button for the active row", async () => {
- const container = await renderEditor();
-
- for (const label of ["Bold", "Italic", "Table", "Link"]) {
- const button = container.querySelector(`button[aria-label="${label}"]`);
- expect(button, label).toBeTruthy();
- expect(button?.getAttribute("title")).toBeNull();
- }
-
- const editorDom = container.querySelector(".ProseMirror");
- expect(editorDom).toBeTruthy();
-
- await act(async () => {
- (editorDom as HTMLElement).focus();
- });
-
- const deleteRow = document.body.querySelector(
- 'button[aria-label="Delete row"]',
- );
- const deleteColumn = document.body.querySelector(
- 'button[aria-label="Delete column"]',
- );
- expect(deleteRow).toBeTruthy();
- expect(deleteColumn).toBeTruthy();
-
- await act(async () => {
- deleteRow?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
- });
-
- expect(container.textContent).toContain("Keep");
- expect(container.textContent).toContain("Me");
- expect(container.querySelectorAll("tr")).toHaveLength(1);
- });
-});
diff --git a/apps/web/tests/misc/table-keyboard.test.ts b/apps/web/tests/misc/table-keyboard.test.ts
deleted file mode 100644
index 8a654a6121..0000000000
--- a/apps/web/tests/misc/table-keyboard.test.ts
+++ /dev/null
@@ -1,162 +0,0 @@
-/** @vitest-environment happy-dom */
-import { afterEach, describe, expect, it } from "vitest";
-import {
- deleteEditorColumn,
- deleteEditorRow,
- deleteTableStructureOnKey,
- textPosInCell,
-} from "../../../../packages/ui/src/rich-text-area/table-keyboard";
-import {
- columnCount,
- createTableEditor,
- rowCount,
- selectCellRange,
- setCaretAtText,
- setCaretInParagraph,
-} from "../../../../packages/ui/src/rich-text-area/table-keyboard.harness";
-
-const editors: ReturnType<typeof createTableEditor>[] = [];
-
-function createEditor(html: string) {
- const editor = createTableEditor(html);
- editors.push(editor);
- return editor;
-}
-
-afterEach(() => {
- editors.splice(0).forEach((editor) => editor.destroy());
- document.body.innerHTML = "";
-});
-
-function key(name: string, modifiers: Partial<KeyboardEventInit> = {}) {
- return new KeyboardEvent("keydown", { key: name, ...modifiers });
-}
-
-const TWO_ROW_TABLE = `
- <table>
- <tbody>
- <tr><th><p></p></th><th><p></p></th></tr>
- <tr><td><p>Keep</p></td><td><p>Me</p></td></tr>
- </tbody>
- </table>
-`;
-
-describe("table keyboard deletion", () => {
- it("removes an empty row with Backspace or Delete and leaves the other row", () => {
- const editor = createEditor(TWO_ROW_TABLE);
- setCaretInParagraph(editor, 0);
-
- expect(deleteTableStructureOnKey(editor, key("Backspace"))).toBe(true);
- expect(rowCount(editor)).toBe(1);
- expect(editor.getText()).toContain("Keep");
- expect(editor.getText()).toContain("Me");
-
- const remaining = createEditor(TWO_ROW_TABLE);
- setCaretInParagraph(remaining, 0);
- expect(deleteTableStructureOnKey(remaining, key("Delete"))).toBe(true);
- expect(rowCount(remaining)).toBe(1);
- });
-
- it("does not remove a row that still has text", () => {
- const editor = createEditor(TWO_ROW_TABLE);
- setCaretAtText(editor, "Keep", 0);
-
- expect(deleteTableStructureOnKey(editor, key("Backspace"))).toBe(false);
- expect(rowCount(editor)).toBe(2);
- expect(editor.getText()).toContain("Keep");
-
- setCaretAtText(editor, "Keep", 2);
- expect(deleteTableStructureOnKey(editor, key("Backspace"))).toBe(false);
- expect(editor.getText()).toContain("Keep");
- });
-
- it("ignores Backspace outside a table and modified Backspace inside one", () => {
- const editor = createEditor("<p>Hello</p>");
- editor.commands.focus("start");
- expect(deleteTableStructureOnKey(editor, key("Backspace"))).toBe(false);
- expect(editor.getText()).toBe("Hello");
-
- const table = createEditor(TWO_ROW_TABLE);
- setCaretInParagraph(table, 0);
- expect(
- deleteTableStructureOnKey(table, key("Backspace", { metaKey: true })),
- ).toBe(false);
- expect(rowCount(table)).toBe(2);
- });
-
- it("treats a whitespace-only row as empty", () => {
- const editor = createEditor(`
- <table>
- <tbody>
- <tr><td><p> &nbsp; </p></td></tr>
- <tr><td><p>Stay</p></td></tr>
- </tbody>
- </table>
- `);
- setCaretInParagraph(editor, 0);
-
- expect(deleteTableStructureOnKey(editor, key("Backspace"))).toBe(true);
- expect(editor.getText()).toContain("Stay");
- expect(rowCount(editor)).toBe(1);
- });
-
- it("replaces a table with a paragraph when its last row is removed", () => {
- const editor = createEditor(`
- <table>
- <tbody>
- <tr><td><p></p></td><td><p></p></td></tr>
- </tbody>
- </table>
- `);
- setCaretInParagraph(editor, 0);
-
- expect(deleteTableStructureOnKey(editor, key("Backspace"))).toBe(true);
- expect(rowCount(editor)).toBe(0);
- expect(editor.getHTML()).toContain("<p>");
- expect(editor.getText()).toBe("");
- });
-
- it("deletes the hovered cell's row after resolving that cell in the editor", () => {
- const editor = createEditor(TWO_ROW_TABLE);
- const cell = editor.view.dom.querySelector("td");
- if (!(cell instanceof HTMLTableCellElement)) {
- throw new Error("Missing table cell");
- }
-
- const pos = textPosInCell(editor, editor.view.posAtDOM(cell, 0));
- editor.chain().focus().setTextSelection(pos).run();
- expect(editor.state.selection.$from.parent.textContent).toBe("Keep");
- expect(deleteEditorRow(editor)).toBe(true);
- expect(editor.getText()).not.toContain("Keep");
- expect(editor.getText()).not.toContain("Me");
- expect(rowCount(editor)).toBe(1);
- });
-
- it("deletes a row or column that still has text from the row and column actions", () => {
- const editor = createEditor(TWO_ROW_TABLE);
- setCaretAtText(editor, "Me", 1);
-
- expect(deleteEditorColumn(editor)).toBe(true);
- expect(columnCount(editor)).toBe(1);
- expect(editor.getText()).toContain("Keep");
- expect(editor.getText()).not.toContain("Me");
-
- setCaretAtText(editor, "Keep", 1);
- expect(deleteEditorRow(editor)).toBe(true);
- expect(rowCount(editor)).toBe(1);
- expect(editor.getText()).not.toContain("Keep");
- });
-
- it("removes a fully selected row and leaves the table alone when every cell is selected", () => {
- const editor = createEditor(TWO_ROW_TABLE);
- selectCellRange(editor, 0, 1);
-
- expect(deleteTableStructureOnKey(editor, key("Backspace"))).toBe(true);
- expect(rowCount(editor)).toBe(1);
- expect(editor.getText()).toContain("Keep");
-
- selectCellRange(editor, 0, 1);
- expect(deleteTableStructureOnKey(editor, key("Delete"))).toBe(false);
- expect(rowCount(editor)).toBe(1);
- });
-});
diff --git a/packages/ui/src/rich-text-area/table-keyboard.harness.ts b/packages/ui/src/rich-text-area/table-keyboard.harness.ts
deleted file mode 100644
index e0dcdb9cdb..0000000000
--- a/packages/ui/src/rich-text-area/table-keyboard.harness.ts
+++ /dev/null
@@ -1,77 +0,0 @@
-// Test-only helpers. The UI package does not export this file.
-import { TableKit } from "@tiptap/extension-table";
-import { CellSelection } from "@tiptap/pm/tables";
-import { Editor } from "@tiptap/react";
-import StarterKit from "@tiptap/starter-kit";
-
-export function createTableEditor(html: string) {
- const element = document.createElement("div");
- document.body.append(element);
-
- return new Editor({
- element,
- extensions: [StarterKit, TableKit],
- content: html,
- });
-}
-
-export function rowCount(editor: Editor) {
- let count = 0;
- editor.state.doc.descendants((node) => {
- if (node.type.name === "tableRow") count += 1;
- });
- return count;
-}
-
-export function columnCount(editor: Editor) {
- let count = 0;
- editor.state.doc.descendants((node) => {
- if (node.type.name !== "tableRow" || count > 0) return;
- count = node.childCount;
- });
- return count;
-}
-
-export function setCaretAtText(editor: Editor, text: string, offset = 0) {
- let found = -1;
- editor.state.doc.descendants((node, pos) => {
- if (found !== -1) return false;
- if (!node.isText || !node.text?.includes(text)) return;
- found = pos + node.text.indexOf(text) + offset;
- return false;
- });
- if (found < 0) throw new Error(`Couldn't find "${text}"`);
- editor.commands.setTextSelection(found);
-}
-
-export function setCaretInParagraph(editor: Editor, index: number) {
- let seen = 0;
- let found = -1;
- editor.state.doc.descendants((node, pos) => {
- if (found !== -1) return false;
- if (node.type.name !== "paragraph") return;
- if (seen === index) {
- found = pos + 1;
- return false;
- }
- seen += 1;
- });
- if (found < 0) throw new Error(`Couldn't find paragraph ${index}`);
- editor.commands.setTextSelection(found);
-}
-
-export function selectCellRange(editor: Editor, start: number, end: number) {
- const positions: number[] = [];
- editor.state.doc.descendants((node, pos) => {
- if (node.type.name === "tableCell" || node.type.name === "tableHeader") {
- positions.push(pos);
- }
- });
-
- const selection = CellSelection.create(
- editor.state.doc,
- positions[start],
- positions[end],
- );
- editor.view.dispatch(editor.state.tr.setSelection(selection));
-}