Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

REWARD_EVENT_DESCRIPTIONS, remove layout shift

Steven Tey76e03ca26f2b
diff --git a/apps/web/app/(ee)/partners.dub.co/(dashboard)/referrals/page-client.tsx b/apps/web/app/(ee)/partners.dub.co/(dashboard)/referrals/page-client.tsx
index 2eb3d7729b..378959051b 100644
--- a/apps/web/app/(ee)/partners.dub.co/(dashboard)/referrals/page-client.tsx
+++ b/apps/web/app/(ee)/partners.dub.co/(dashboard)/referrals/page-client.tsx
@@ -162,7 +162,7 @@ function ReferralsStatItem({
{isLoading ? (
<span
aria-hidden="true"
- className="mt-0.5 block h-8 w-[4.75rem] animate-pulse rounded-md bg-neutral-200"
+ className="mt-2 block h-8 w-[4.75rem] animate-pulse rounded-md bg-neutral-200"
/>
) : (
children
diff --git a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/rewards/group-rewards.tsx b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/rewards/group-rewards.tsx
index 6e21a31a05..5eac17aec0 100644
--- a/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/rewards/group-rewards.tsx
+++ b/apps/web/app/app.dub.co/(dashboard)/[slug]/(ee)/program/groups/[groupSlug]/rewards/group-rewards.tsx
@@ -12,6 +12,7 @@ import {
RewardSheet,
useRewardSheet,
} from "@/ui/partners/rewards/add-edit-reward-sheet";
+import { REWARD_EVENT_DESCRIPTIONS } from "@/ui/partners/rewards/reward-event-descriptions";
import { REWARD_EVENT_ICON } from "@/ui/partners/rewards/reward-event-icon";
import { EventType } from "@dub/prisma/client";
import {
@@ -25,28 +26,6 @@ import Link from "next/link";
import { useParams } from "next/navigation";
import { useEffect, useState } from "react";
-const REWARD_EVENT_DESCRIPTIONS: Record<
- EventType,
- { title: string; description: string }
-> = {
- sale: {
- title: "Sale reward",
- description: "Reward when revenue is generated",
- },
- lead: {
- title: "Lead reward",
- description: "Reward for sign ups or demos",
- },
- click: {
- title: "Click reward",
- description: "Reward for traffic and reach",
- },
- referral: {
- title: "Partner referral reward",
- description: "Reward when partners refer more partners",
- },
-};
-
export function GroupRewards() {
const { group, loading } = useGroup();
const { searchParams } = useRouterStuff();
@@ -262,7 +241,15 @@ const RewardItem = ({
{REWARD_EVENT_DESCRIPTIONS[event].title}
</span>
<span className="text-sm font-normal text-neutral-500">
- {REWARD_EVENT_DESCRIPTIONS[event].description}
+ {REWARD_EVENT_DESCRIPTIONS[event].description}.{" "}
+ <Link
+ href={REWARD_EVENT_DESCRIPTIONS[event].learnMoreHref}
+ target="_blank"
+ rel="noopener noreferrer"
+ className="underline decoration-neutral-400 decoration-dotted underline-offset-2 hover:text-neutral-600"
+ >
+ Learn more ↗
+ </Link>
</span>
</div>
)}
diff --git a/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx b/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
index 04f4224bab..91d48bce45 100644
--- a/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
+++ b/apps/web/ui/partners/rewards/add-edit-reward-sheet.tsx
@@ -25,6 +25,7 @@ import {
import { X } from "@/ui/shared/icons";
import { EventType, RewardStructure } from "@dub/prisma/client";
import {
+ BookOpen,
Button,
Gift,
Grid,
@@ -36,7 +37,6 @@ import {
useLocalStorage,
useRouterStuff,
} from "@dub/ui";
-import { CursorRays, InvoiceDollar, UserPlus } from "@dub/ui/icons";
import { capitalize, cn, pluralize } from "@dub/utils";
import { motion } from "motion/react";
import { useAction } from "next-safe-action/hooks";
@@ -64,6 +64,7 @@ import {
} from "../../shared/inline-badge-popover";
import { RewardDiscountPartnersCard } from "../groups/reward-discount-partners-card";
import { PartnerReferralRewardBuilder } from "./partner-referral-reward-builder";
+import { REWARD_EVENT_DESCRIPTIONS } from "./reward-event-descriptions";
import { RewardIconSquare } from "./reward-icon-square";
import { RewardPreviewCard } from "./reward-preview-card";
import { REWARD_TYPES, RewardsLogic } from "./rewards-logic";
@@ -685,48 +686,19 @@ function RewardSheetContent({
);
}
-const REWARD_HELPER_CONTENT: Record<
- EventType,
- {
- icon: typeof InvoiceDollar;
- title: string;
- description: string;
- }
-> = {
- sale: {
- icon: InvoiceDollar,
- title: "Sale rewards",
- description:
- "Reward when revenue is generated. Best for partners, creators, and long term partnerships.",
- },
- lead: {
- icon: UserPlus,
- title: "Lead rewards",
- description:
- "Reward for sign ups or demos. Best for B2B, demos, waitlists, or products with longer sales cycles.",
- },
- click: {
- icon: CursorRays,
- title: "Click rewards",
- description:
- "Reward for traffic and reach. Best for publishers with high DR sites and trusted partners only.",
- },
- referral: {
- icon: UserPlus,
- title: "Referral rewards",
- description:
- "Reward partners for referring other partners. Best for driving partner growth to your program.",
- },
-};
-
function RewardHelperBlock({ event }: { event: EventType }) {
const [dismissed, setDismissed] = useLocalStorage<boolean>(
`reward-helper-${event}-dismissed`,
false,
);
- const content = REWARD_HELPER_CONTENT[event];
- const Icon = content.icon;
+ const {
+ icon: Icon,
+ title,
+ description,
+ bestFor,
+ learnMoreHref,
+ } = REWARD_EVENT_DESCRIPTIONS[event];
return (
<motion.div
@@ -753,19 +725,30 @@ function RewardHelperBlock({ event }: { event: EventType }) {
<Icon className="size-5 text-neutral-600" />
<div className="flex flex-col pt-2">
<span className="text-sm font-medium text-neutral-900">
- {content.title}
+ {title}
</span>
<span className="text-sm text-neutral-500">
- {content.description}
+ {description}. Best for {bestFor}.
</span>
</div>
- <Button
- type="button"
- variant="secondary"
- text="Dismiss"
- className="mt-1 h-8 w-fit px-3"
- onClick={() => setDismissed(true)}
- />
+ <div className="mt-1 flex items-center gap-2">
+ <a href={learnMoreHref} target="_blank" rel="noopener noreferrer">
+ <Button
+ type="button"
+ variant="secondary"
+ text="Learn more"
+ icon={<BookOpen className="size-3.5" />}
+ className="h-8 w-fit px-3"
+ />
+ </a>
+ <Button
+ type="button"
+ variant="outline"
+ text="Dismiss"
+ className="h-8 w-fit px-3"
+ onClick={() => setDismissed(true)}
+ />
+ </div>
</div>
</div>
</motion.div>
diff --git a/apps/web/ui/partners/rewards/reward-event-descriptions.tsx b/apps/web/ui/partners/rewards/reward-event-descriptions.tsx
new file mode 100644
index 0000000000..fab2374741
--- /dev/null
+++ b/apps/web/ui/partners/rewards/reward-event-descriptions.tsx
@@ -0,0 +1,45 @@
+import { EventType } from "@dub/prisma/client";
+import { CursorRays, Icon, InvoiceDollar, Nodes4, UserPlus } from "@dub/ui";
+
+export const REWARD_EVENT_DESCRIPTIONS: Record<
+ EventType,
+ {
+ icon: Icon;
+ title: string;
+ description: string;
+ bestFor: string;
+ learnMoreHref: string;
+ }
+> = {
+ sale: {
+ icon: InvoiceDollar,
+ title: "Sale reward",
+ description: "Reward when revenue is generated",
+ bestFor: "partners, creators, and long term partnerships",
+ learnMoreHref:
+ "https://dub.co/help/article/partner-rewards#configuring-reward-types",
+ },
+ lead: {
+ icon: UserPlus,
+ title: "Lead reward",
+ description: "Reward for sign ups or demos",
+ bestFor: "B2B, demos, waitlists, or products with longer sales cycles",
+ learnMoreHref:
+ "https://dub.co/help/article/partner-rewards#configuring-reward-types",
+ },
+ click: {
+ icon: CursorRays,
+ title: "Click reward",
+ description: "Reward for traffic and reach",
+ bestFor: "publishers with high DR sites and trusted partners only",
+ learnMoreHref:
+ "https://dub.co/help/article/partner-rewards#configuring-reward-types",
+ },
+ referral: {
+ icon: Nodes4,
+ title: "Partner referral reward",
+ description: "Reward when partners refer more partners",
+ bestFor: "driving partner growth to your program",
+ learnMoreHref: "https://dub.co/help/article/partner-referrals",
+ },
+};