Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

remove date-fns dep, address CR feedback

Steven Tey7ac706f20734
diff --git a/apps/web/app/(ee)/api/cron/streams/update-click-stats/route.ts b/apps/web/app/(ee)/api/cron/streams/update-click-stats/route.ts
index 545909a8a9..c3413adda4 100644
--- a/apps/web/app/(ee)/api/cron/streams/update-click-stats/route.ts
+++ b/apps/web/app/(ee)/api/cron/streams/update-click-stats/route.ts
@@ -8,7 +8,6 @@ import {
linkClickEventStream,
} from "@/lib/upstash/redis-streams/link-click-events";
import { APP_DOMAIN_WITH_NGROK, log } from "@dub/utils";
-import { format } from "date-fns";
import { NextResponse } from "next/server";
import { logAndRespond } from "../../utils";
@@ -195,13 +194,14 @@ const processClickStatsStreamBatch = () =>
linkUpdates,
async (update) => {
try {
+ const lastClickedAt = new Date(update.lastClicked)
+ .toISOString()
+ .slice(0, 19)
+ .replace("T", " ");
+
await conn.execute(
- "UPDATE Link SET clicks = clicks + ?, lastClicked = ? WHERE id = ?",
- [
- update.clicks,
- format(new Date(update.lastClicked), "yyyy-MM-dd HH:mm:ss"),
- update.linkId,
- ],
+ "UPDATE Link SET clicks = clicks + ?, lastClicked = GREATEST(COALESCE(lastClicked, ?), ?) WHERE id = ?",
+ [update.clicks, lastClickedAt, lastClickedAt, update.linkId],
);
processedEntryIds.push(...update.entryIds);
return { success: true };