Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Walk referrer ancestors to block referral attribution loops.

Kiran K7b9b64440bbc
diff --git a/apps/web/lib/partner-referrals/attribute-referring-partner.ts b/apps/web/lib/partner-referrals/attribute-referring-partner.ts
index 234190be01..a1ba2bc9fb 100644
--- a/apps/web/lib/partner-referrals/attribute-referring-partner.ts
+++ b/apps/web/lib/partner-referrals/attribute-referring-partner.ts
@@ -94,16 +94,12 @@ export const attributeReferringPartnerAction = authActionClient
});
}
- if (
- referringProgramEnrollment.applicationEvent?.referredByPartnerId ===
- partnerId
- ) {
- throw new DubApiError({
- code: "bad_request",
- message:
- "This referral relationship is not allowed because it would create a referral loop.",
- });
- }
+ await throwIfReferralLoop({
+ programId,
+ partnerId,
+ initialReferrerId:
+ referringProgramEnrollment.applicationEvent?.referredByPartnerId,
+ });
// Attribute the referring partner to the application
const baseDate =
@@ -165,3 +161,49 @@ export const attributeReferringPartnerAction = authActionClient
}
}
});
+
+async function throwIfReferralLoop({
+ programId,
+ partnerId,
+ initialReferrerId,
+}: {
+ programId: string;
+ partnerId: string;
+ initialReferrerId: string | null | undefined;
+}) {
+ const visited = new Set<string>();
+ let currentReferrerId = initialReferrerId;
+
+ while (currentReferrerId) {
+ if (currentReferrerId === partnerId) {
+ throw new DubApiError({
+ code: "bad_request",
+ message:
+ "This referral relationship is not allowed because it would create a referral loop.",
+ });
+ }
+
+ // Malformed data: ancestor chain already cycles (e.g. A→B→A) without
+ // including partnerId — stop walking instead of looping forever.
+ // Should never happen in practice
+ if (visited.has(currentReferrerId)) {
+ break;
+ }
+
+ visited.add(currentReferrerId);
+
+ const applicationEvent = await prisma.programApplicationEvent.findUnique({
+ where: {
+ programId_partnerId: {
+ programId,
+ partnerId: currentReferrerId,
+ },
+ },
+ select: {
+ referredByPartnerId: true,
+ },
+ });
+
+ currentReferrerId = applicationEvent?.referredByPartnerId ?? null;
+ }
+}