The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Confirm fraud alerts before the network ban, and retry only the ban
Rafi7c477427a3c0
diff --git a/apps/web/app/(ee)/api/admin/fraud-alerts/[fraudAlertId]/route.ts b/apps/web/app/(ee)/api/admin/fraud-alerts/[fraudAlertId]/route.tsindex ed375a0273..eeafc06160 100644--- a/apps/web/app/(ee)/api/admin/fraud-alerts/[fraudAlertId]/route.ts+++ b/apps/web/app/(ee)/api/admin/fraud-alerts/[fraudAlertId]/route.ts@@ -37,6 +37,16 @@ export const PATCH = withAdmin(return new Response("Fraud alert not found.", { status: 404 });}+ // A retry after a failed ban runs only the ban, since the alert is already confirmed+ if (+ newStatus === "confirmed" &&+ fraudAlert.status === "confirmed" &&+ banFromNetwork+ ) {+ await banPartnerFromNetwork(fraudAlert.partnerId);+ return NextResponse.json({ success: true });+ }+if (newStatus === "confirmed" && fraudAlert.status !== "pending") {return new Response("Fraud alert has already been reviewed.", {status: 409,@@ -70,11 +80,6 @@ export const PATCH = withAdmin(return NextResponse.json({ success: true });}- // Ban first, so that a failed ban can be retried before the alert is confirmed- if (banFromNetwork) {- await banPartnerFromNetwork(fraudAlert.partnerId);- }-const { confirmedCount } = await confirmPartnerFraudAlerts({partnerId: fraudAlert.partnerId,reviewedById: session.user.id,@@ -87,6 +92,11 @@ export const PATCH = withAdmin(});}+ // Ban only after the confirmation, so a dismissal that wins the race leaves no ban+ if (banFromNetwork) {+ await banPartnerFromNetwork(fraudAlert.partnerId);+ }+return NextResponse.json({ success: true });},{