Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

fix(advanced-filters): newParam could be undefined when parsed is undefined

Pedro Ladeira82b247328e5c
diff --git a/apps/web/ui/analytics/use-analytics-filters.tsx b/apps/web/ui/analytics/use-analytics-filters.tsx
index 5774b7aa43..407548da19 100644
--- a/apps/web/ui/analytics/use-analytics-filters.tsx
+++ b/apps/web/ui/analytics/use-analytics-filters.tsx
@@ -928,17 +928,22 @@ export function useAnalyticsFilters({
if (!currentParam) return;
const parsed = parseFilterParam(currentParam);
- const newValues = parsed?.values?.filter((v) => v !== value);
+ if (!parsed) {
+ queryParams({ del: key, scroll: false });
+ return;
+ }
- if (newValues?.length === 0) {
+ const newValues = parsed.values.filter((v) => v !== value);
+
+ if (newValues.length === 0) {
queryParams({ del: key, scroll: false });
} else {
- const newParam = parsed?.operator?.includes("NOT")
- ? `-${newValues?.join(",")}`
- : newValues?.join(",");
+ const newParam = parsed.operator.includes("NOT")
+ ? `-${newValues.join(",")}`
+ : newValues.join(",");
queryParams({
- set: { [key]: newParam as string },
+ set: { [key]: newParam },
scroll: false,
});
}