Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Skip Fraud detection for inactive program enrollments

Kiran K846694059869
diff --git a/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts b/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts
index b188d80c88..cec57daee6 100644
--- a/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts
+++ b/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts
@@ -431,7 +431,10 @@ export async function checkoutSessionCompleted(
]);
// for program links
- let webhookPartner: WebhookPartner | undefined;
+ let createdCommission:
+ | Awaited<ReturnType<typeof createPartnerCommission>>
+ | undefined = undefined;
+
if (link && link.programId && link.partnerId) {
const productId = await getSubscriptionProductId({
stripeSubscriptionId: charge.subscription as string,
@@ -439,7 +442,7 @@ export async function checkoutSessionCompleted(
mode,
});
- const createdCommission = await createPartnerCommission({
+ createdCommission = await createPartnerCommission({
event: "sale",
programId: link.programId,
partnerId: link.partnerId,
@@ -461,7 +464,7 @@ export async function checkoutSessionCompleted(
},
});
- webhookPartner = createdCommission?.webhookPartner;
+ const { webhookPartner, programEnrollment } = createdCommission;
waitUntil(
Promise.allSettled([
@@ -487,8 +490,8 @@ export async function checkoutSessionCompleted(
detectAndRecordFraudEvent({
program: { id: link.programId },
partner: pick(webhookPartner, ["id", "email", "name"]),
+ programEnrollment: pick(programEnrollment, ["status"]),
customer: pick(customer, ["id", "email", "name"]),
- commission: { id: createdCommission.commission?.id },
link: pick(link, ["id"]),
click: pick(saleData, ["url", "referer"]),
event: { id: saleData.event_id },
@@ -497,22 +500,20 @@ export async function checkoutSessionCompleted(
);
}
+ // send workspace webhook
waitUntil(
- (async () => {
- // send workspace webhook
- await sendWorkspaceWebhook({
- trigger: "sale.created",
- workspace,
- data: transformSaleEventData({
- ...saleData,
- clickedAt: customer.clickedAt || customer.createdAt,
- link: linkUpdated,
- customer,
- partner: webhookPartner,
- metadata: null,
- }),
- });
- })(),
+ sendWorkspaceWebhook({
+ trigger: "sale.created",
+ workspace,
+ data: transformSaleEventData({
+ ...saleData,
+ clickedAt: customer.clickedAt || customer.createdAt,
+ link: linkUpdated,
+ customer,
+ partner: createdCommission?.webhookPartner,
+ metadata: null,
+ }),
+ }),
);
return `Checkout session completed for customer with external ID ${dubCustomerExternalId} and invoice ID ${invoiceId}`;
diff --git a/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts b/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts
index 6ecaf2bdbc..fa6742b941 100644
--- a/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts
+++ b/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts
@@ -6,7 +6,7 @@ import { syncPartnerLinksStats } from "@/lib/api/partners/sync-partner-links-sta
import { executeWorkflows } from "@/lib/api/workflows/execute-workflows";
import { createPartnerCommission } from "@/lib/partners/create-partner-commission";
import { getLeadEvent, recordSale } from "@/lib/tinybird";
-import { StripeMode, WebhookPartner } from "@/lib/types";
+import { StripeMode } from "@/lib/types";
import { redis } from "@/lib/upstash";
import { sendWorkspaceWebhook } from "@/lib/webhook/publish";
import { transformSaleEventData } from "@/lib/webhook/transform";
@@ -213,9 +213,12 @@ export async function invoicePaid(event: Stripe.Event, mode: StripeMode) {
]);
// for program links
- let webhookPartner: WebhookPartner | undefined;
+ let createdCommission:
+ | Awaited<ReturnType<typeof createPartnerCommission>>
+ | undefined = undefined;
+
if (link.programId && link.partnerId) {
- const createdCommission = await createPartnerCommission({
+ createdCommission = await createPartnerCommission({
event: "sale",
programId: link.programId,
partnerId: link.partnerId,
@@ -236,7 +239,8 @@ export async function invoicePaid(event: Stripe.Event, mode: StripeMode) {
},
},
});
- webhookPartner = createdCommission?.webhookPartner;
+
+ const { webhookPartner, programEnrollment } = createdCommission;
waitUntil(
Promise.allSettled([
@@ -262,8 +266,8 @@ export async function invoicePaid(event: Stripe.Event, mode: StripeMode) {
detectAndRecordFraudEvent({
program: { id: link.programId },
partner: pick(webhookPartner, ["id", "email", "name"]),
+ programEnrollment: pick(programEnrollment, ["status"]),
customer: pick(customer, ["id", "email", "name"]),
- commission: { id: createdCommission.commission?.id },
link: pick(link, ["id"]),
click: pick(saleData, ["url", "referer"]),
event: { id: saleData.event_id },
@@ -282,7 +286,7 @@ export async function invoicePaid(event: Stripe.Event, mode: StripeMode) {
clickedAt: customer.clickedAt || customer.createdAt,
link: linkUpdated,
customer,
- partner: webhookPartner,
+ partner: createdCommission?.webhookPartner,
metadata: null,
}),
}),
diff --git a/apps/web/app/(ee)/api/stripe/integration/webhook/utils/create-new-customer.ts b/apps/web/app/(ee)/api/stripe/integration/webhook/utils/create-new-customer.ts
index 5230ed3447..21ab3938aa 100644
--- a/apps/web/app/(ee)/api/stripe/integration/webhook/utils/create-new-customer.ts
+++ b/apps/web/app/(ee)/api/stripe/integration/webhook/utils/create-new-customer.ts
@@ -6,11 +6,10 @@ import { executeWorkflows } from "@/lib/api/workflows/execute-workflows";
import { generateRandomName } from "@/lib/names";
import { createPartnerCommission } from "@/lib/partners/create-partner-commission";
import { getClickEvent, recordLead } from "@/lib/tinybird";
-import { WebhookPartner } from "@/lib/types";
import { sendWorkspaceWebhook } from "@/lib/webhook/publish";
import { transformLeadEventData } from "@/lib/webhook/transform";
import { prisma } from "@dub/prisma";
-import { Commission, WorkflowTrigger } from "@dub/prisma/client";
+import { WorkflowTrigger } from "@dub/prisma/client";
import { nanoid, pick } from "@dub/utils";
import { waitUntil } from "@vercel/functions";
import type Stripe from "stripe";
@@ -104,11 +103,12 @@ export async function createNewCustomer(event: Stripe.Event) {
}),
]);
- let webhookPartner: WebhookPartner | undefined;
- let commission: Commission | undefined;
+ let createdCommission:
+ | Awaited<ReturnType<typeof createPartnerCommission>>
+ | undefined = undefined;
if (link.programId && link.partnerId) {
- const createdCommission = await createPartnerCommission({
+ createdCommission = await createPartnerCommission({
event: "lead",
programId: link.programId,
partnerId: link.partnerId,
@@ -123,57 +123,55 @@ export async function createNewCustomer(event: Stripe.Event) {
},
});
- webhookPartner = createdCommission?.webhookPartner;
- commission = createdCommission?.commission ?? undefined;
+ const { webhookPartner, programEnrollment } = createdCommission;
+
+ waitUntil(
+ Promise.allSettled([
+ executeWorkflows({
+ trigger: WorkflowTrigger.leadRecorded,
+ context: {
+ programId: link.programId,
+ partnerId: link.partnerId,
+ current: {
+ leads: 1,
+ },
+ },
+ }),
+
+ syncPartnerLinksStats({
+ partnerId: link.partnerId,
+ programId: link.programId,
+ eventType: "lead",
+ }),
+
+ webhookPartner &&
+ detectAndRecordFraudEvent({
+ program: { id: link.programId },
+ partner: pick(webhookPartner, ["id", "email", "name"]),
+ programEnrollment: pick(programEnrollment, ["status"]),
+ customer: pick(customer, ["id", "email", "name"]),
+ link: pick(link, ["id"]),
+ click: pick(leadData, ["url", "referer"]),
+ event: { id: leadData.event_id },
+ }),
+ ]),
+ );
}
+ // send workspace webhook
waitUntil(
- Promise.allSettled([
- sendWorkspaceWebhook({
- trigger: "lead.created",
- workspace,
- data: transformLeadEventData({
- ...clickData,
- eventName,
- link: linkUpdated,
- customer,
- partner: webhookPartner,
- metadata: null,
- }),
+ sendWorkspaceWebhook({
+ trigger: "lead.created",
+ workspace,
+ data: transformLeadEventData({
+ ...clickData,
+ eventName,
+ link: linkUpdated,
+ customer,
+ partner: createdCommission?.webhookPartner,
+ metadata: null,
}),
-
- ...(link.programId && link.partnerId
- ? [
- executeWorkflows({
- trigger: WorkflowTrigger.leadRecorded,
- context: {
- programId: link.programId,
- partnerId: link.partnerId,
- current: {
- leads: 1,
- },
- },
- }),
-
- syncPartnerLinksStats({
- partnerId: link.partnerId,
- programId: link.programId,
- eventType: "lead",
- }),
-
- webhookPartner &&
- detectAndRecordFraudEvent({
- program: { id: link.programId },
- partner: pick(webhookPartner, ["id", "email", "name"]),
- customer: pick(customer, ["id", "email", "name"]),
- commission: { id: commission?.id },
- link: pick(link, ["id"]),
- click: pick(leadData, ["url", "referer"]),
- event: { id: leadData.event_id },
- }),
- ]
- : []),
- ]),
+ }),
);
return `New Dub customer created: ${customer.id}. Lead event recorded: ${leadData.event_id}`;
diff --git a/apps/web/lib/api/conversions/track-lead.ts b/apps/web/lib/api/conversions/track-lead.ts
index 1a6f2ad430..5872324a2e 100644
--- a/apps/web/lib/api/conversions/track-lead.ts
+++ b/apps/web/lib/api/conversions/track-lead.ts
@@ -7,7 +7,7 @@ import { createPartnerCommission } from "@/lib/partners/create-partner-commissio
import { isStored, storage } from "@/lib/storage";
import { getClickEvent, recordLead } from "@/lib/tinybird";
import { logConversionEvent } from "@/lib/tinybird/log-conversion-events";
-import { WebhookPartner, WorkspaceProps } from "@/lib/types";
+import { WorkspaceProps } from "@/lib/types";
import { redis } from "@/lib/upstash";
import { sendWorkspaceWebhook } from "@/lib/webhook/publish";
import { transformLeadEventData } from "@/lib/webhook/transform";
@@ -294,10 +294,12 @@ export const trackLead = async ({
]);
link = updatedLink; // update the link variable to the latest version
- let webhookPartner: WebhookPartner | undefined;
+ let createdCommission:
+ | Awaited<ReturnType<typeof createPartnerCommission>>
+ | undefined = undefined;
if (link.programId && link.partnerId && customer) {
- const createdCommission = await createPartnerCommission({
+ createdCommission = await createPartnerCommission({
event: "lead",
programId: link.programId,
partnerId: link.partnerId,
@@ -312,7 +314,7 @@ export const trackLead = async ({
},
});
- webhookPartner = createdCommission?.webhookPartner;
+ const { webhookPartner, programEnrollment } = createdCommission;
await Promise.allSettled([
executeWorkflows({
@@ -336,8 +338,8 @@ export const trackLead = async ({
detectAndRecordFraudEvent({
program: { id: link.programId },
partner: pick(webhookPartner, ["id", "email", "name"]),
+ programEnrollment: pick(programEnrollment, ["status"]),
customer: pick(customer, ["id", "email", "name"]),
- commission: { id: createdCommission.commission?.id },
link: pick(link, ["id"]),
click: pick(clickData, ["url", "referer"]),
event: { id: leadEventId },
@@ -352,7 +354,7 @@ export const trackLead = async ({
eventName,
link,
customer,
- partner: webhookPartner,
+ partner: createdCommission?.webhookPartner,
metadata,
}),
workspace,
diff --git a/apps/web/lib/api/conversions/track-sale.ts b/apps/web/lib/api/conversions/track-sale.ts
index dabf756065..d053845532 100644
--- a/apps/web/lib/api/conversions/track-sale.ts
+++ b/apps/web/lib/api/conversions/track-sale.ts
@@ -13,7 +13,7 @@ import {
recordSale,
} from "@/lib/tinybird";
import { logConversionEvent } from "@/lib/tinybird/log-conversion-events";
-import { LeadEventTB, WebhookPartner, WorkspaceProps } from "@/lib/types";
+import { LeadEventTB, WorkspaceProps } from "@/lib/types";
import { redis } from "@/lib/upstash";
import { sendWorkspaceWebhook } from "@/lib/webhook/publish";
import {
@@ -345,20 +345,21 @@ const _trackLead = async ({
// Create partner commission and execute workflows
if (link.programId && link.partnerId && customer) {
- const { commission, webhookPartner } = await createPartnerCommission({
- event: "lead",
- programId: link.programId,
- partnerId: link.partnerId,
- linkId: link.id,
- eventId: leadEventData.event_id,
- customerId: customer.id,
- quantity: 1,
- context: {
- customer: {
- country: customer.country,
+ const { webhookPartner, programEnrollment } =
+ await createPartnerCommission({
+ event: "lead",
+ programId: link.programId,
+ partnerId: link.partnerId,
+ linkId: link.id,
+ eventId: leadEventData.event_id,
+ customerId: customer.id,
+ quantity: 1,
+ context: {
+ customer: {
+ country: customer.country,
+ },
},
- },
- });
+ });
await Promise.allSettled([
executeWorkflows({
@@ -382,8 +383,8 @@ const _trackLead = async ({
detectAndRecordFraudEvent({
program: { id: link.programId },
partner: pick(webhookPartner, ["id", "email", "name"]),
+ programEnrollment: pick(programEnrollment, ["status"]),
customer: pick(customer, ["id", "email", "name"]),
- commission: { id: commission?.id },
link: pick(link, ["id"]),
click: pick(leadEventData, ["url", "referer"]),
event: { id: leadEventData.event_id },
@@ -544,10 +545,13 @@ const _trackSale = async ({
}),
]);
- let webhookPartner: WebhookPartner | undefined;
+ let createdCommission:
+ | Awaited<ReturnType<typeof createPartnerCommission>>
+ | undefined = undefined;
+
// Create partner commission and execute workflows
if (link.programId && link.partnerId) {
- const createdCommission = await createPartnerCommission({
+ createdCommission = await createPartnerCommission({
event: "sale",
programId: link.programId,
partnerId: link.partnerId,
@@ -569,7 +573,7 @@ const _trackSale = async ({
},
});
- webhookPartner = createdCommission?.webhookPartner;
+ const { webhookPartner, programEnrollment } = createdCommission;
await Promise.allSettled([
executeWorkflows({
@@ -594,8 +598,8 @@ const _trackSale = async ({
detectAndRecordFraudEvent({
program: { id: link.programId },
partner: pick(webhookPartner, ["id", "email", "name"]),
+ programEnrollment: pick(programEnrollment, ["status"]),
customer: pick(customer, ["id", "email", "name"]),
- commission: { id: createdCommission.commission?.id },
link: pick(link, ["id"]),
click: pick(saleData, ["url", "referer"]),
event: { id: saleData.event_id },
@@ -609,7 +613,7 @@ const _trackSale = async ({
clickedAt: customer.clickedAt || customer.createdAt,
link,
customer,
- partner: webhookPartner,
+ partner: createdCommission?.webhookPartner,
metadata,
});
diff --git a/apps/web/lib/api/fraud/detect-record-fraud-event.ts b/apps/web/lib/api/fraud/detect-record-fraud-event.ts
index 6aec8c8234..2292018db3 100644
--- a/apps/web/lib/api/fraud/detect-record-fraud-event.ts
+++ b/apps/web/lib/api/fraud/detect-record-fraud-event.ts
@@ -1,4 +1,5 @@
import { CreateFraudEventInput, FraudEventContext } from "@/lib/types";
+import { INACTIVE_ENROLLMENT_STATUSES } from "@/lib/zod/schemas/partners";
import { prisma } from "@dub/prisma";
import { Prisma } from "@dub/prisma/client";
import { prettyPrint } from "@dub/utils";
@@ -18,6 +19,15 @@ export async function detectAndRecordFraudEvent(context: FraudEventContext) {
}
const validatedContext = result.data;
+ const { programEnrollment } = validatedContext;
+
+ // Skip if program enrollment is inactive
+ if (INACTIVE_ENROLLMENT_STATUSES.includes(programEnrollment.status)) {
+ console.info(
+ `[detectAndRecordFraudEvent] Program enrollment is ${programEnrollment.status}, skipping...`,
+ );
+ return;
+ }
// Get program-specific rule overrides
const programRules = await prisma.fraudRule.findMany({
diff --git a/apps/web/lib/integrations/shopify/create-sale.ts b/apps/web/lib/integrations/shopify/create-sale.ts
index f27bf469cd..732ea25692 100644
--- a/apps/web/lib/integrations/shopify/create-sale.ts
+++ b/apps/web/lib/integrations/shopify/create-sale.ts
@@ -5,7 +5,7 @@ import { syncPartnerLinksStats } from "@/lib/api/partners/sync-partner-links-sta
import { executeWorkflows } from "@/lib/api/workflows/execute-workflows";
import { createPartnerCommission } from "@/lib/partners/create-partner-commission";
import { recordSale } from "@/lib/tinybird";
-import { LeadEventTB, WebhookPartner } from "@/lib/types";
+import { LeadEventTB } from "@/lib/types";
import { redis } from "@/lib/upstash";
import { sendWorkspaceWebhook } from "@/lib/webhook/publish";
import { transformSaleEventData } from "@/lib/webhook/transform";
@@ -131,9 +131,12 @@ export async function createShopifySale({
]);
// for program links
- let webhookPartner: WebhookPartner | undefined;
+ let createdCommission:
+ | Awaited<ReturnType<typeof createPartnerCommission>>
+ | undefined = undefined;
+
if (link.programId && link.partnerId) {
- const createdCommission = await createPartnerCommission({
+ createdCommission = await createPartnerCommission({
event: "sale",
programId: link.programId,
partnerId: link.partnerId,
@@ -154,7 +157,7 @@ export async function createShopifySale({
},
});
- webhookPartner = createdCommission?.webhookPartner;
+ const { webhookPartner, programEnrollment } = createdCommission;
waitUntil(
Promise.allSettled([
@@ -180,8 +183,8 @@ export async function createShopifySale({
detectAndRecordFraudEvent({
program: { id: link.programId },
partner: pick(webhookPartner, ["id", "email", "name"]),
+ programEnrollment: pick(programEnrollment, ["status"]),
customer: pick(customer, ["id", "email", "name"]),
- commission: { id: createdCommission.commission?.id },
link: pick(link, ["id"]),
click: pick(saleData, ["url", "referer"]),
event: { id: saleData.event_id },
@@ -199,7 +202,7 @@ export async function createShopifySale({
link,
clickedAt: customer.clickedAt || customer.createdAt,
customer,
- partner: webhookPartner,
+ partner: createdCommission?.webhookPartner,
metadata: null,
}),
}),
diff --git a/apps/web/lib/partners/create-partner-commission.ts b/apps/web/lib/partners/create-partner-commission.ts
index fd11b1bfe5..bc41098f93 100644
--- a/apps/web/lib/partners/create-partner-commission.ts
+++ b/apps/web/lib/partners/create-partner-commission.ts
@@ -108,6 +108,7 @@ export const createPartnerCommission = async ({
);
return {
commission: null,
+ programEnrollment,
webhookPartner: constructWebhookPartner(programEnrollment),
};
}
@@ -145,6 +146,7 @@ export const createPartnerCommission = async ({
);
return {
commission: null,
+ programEnrollment,
webhookPartner: constructWebhookPartner(programEnrollment),
};
}
@@ -157,6 +159,7 @@ export const createPartnerCommission = async ({
return {
commission: null,
+ programEnrollment,
webhookPartner: constructWebhookPartner(programEnrollment),
};
@@ -186,6 +189,7 @@ export const createPartnerCommission = async ({
);
return {
commission: null,
+ programEnrollment,
webhookPartner: constructWebhookPartner(programEnrollment),
};
}
@@ -201,6 +205,7 @@ export const createPartnerCommission = async ({
);
return {
commission: null,
+ programEnrollment,
webhookPartner: constructWebhookPartner(programEnrollment),
};
}
@@ -218,6 +223,7 @@ export const createPartnerCommission = async ({
);
return {
commission: null,
+ programEnrollment,
webhookPartner: constructWebhookPartner(programEnrollment),
};
}
@@ -374,6 +380,7 @@ export const createPartnerCommission = async ({
return {
commission,
+ programEnrollment,
webhookPartner,
};
} catch (error) {
@@ -387,6 +394,7 @@ export const createPartnerCommission = async ({
return {
commission: null,
+ programEnrollment,
webhookPartner: constructWebhookPartner(programEnrollment),
};
}
diff --git a/apps/web/lib/zod/schemas/schemas.ts b/apps/web/lib/zod/schemas/schemas.ts
index 17febdeb8a..fca3676cf2 100644
--- a/apps/web/lib/zod/schemas/schemas.ts
+++ b/apps/web/lib/zod/schemas/schemas.ts
@@ -1,4 +1,5 @@
import { z } from "zod";
+import { ProgramEnrollmentSchema } from "./programs";
export const fraudEventContext = z.object({
program: z.object({
@@ -9,14 +10,14 @@ export const fraudEventContext = z.object({
email: z.string().nullable(),
name: z.string().nullable(),
}),
+ programEnrollment: ProgramEnrollmentSchema.pick({
+ status: true,
+ }),
customer: z.object({
id: z.string(),
email: z.string().nullable(),
name: z.string().nullable(),
}),
- commission: z.object({
- id: z.string().nullable().optional(),
- }),
link: z.object({
id: z.string().nullable().optional(),
}),