The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Fix hold commission activity label and use explicit partner fraud rules.
Kiran K862e0f3ba69d
diff --git a/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts b/apps/web/app/(ee)/api/workflows/create-partner-commission/route.tsindex 9f4602fab0..ff61e3796d 100644--- a/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts+++ b/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts@@ -1,6 +1,6 @@import { triggerAggregateDueCommissionsCronJob } from "@/lib/actions/partners/trigger-aggregate-due-commissions";import { createId } from "@/lib/api/create-id";-import { FRAUD_RULES_BY_SCOPE } from "@/lib/api/fraud/constants";+import { PARTNER_LEVEL_FRAUD_RULES } from "@/lib/api/fraud/constants";import { detectAndRecordFraudEvent } from "@/lib/api/fraud/detect-record-fraud-event";import { notifyPartnerCommission } from "@/lib/api/partners/notify-partner-commission";import { syncTotalCommissions } from "@/lib/api/partners/sync-total-commissions";@@ -30,7 +30,6 @@ import {Commission,CommissionStatus,FraudEventStatus,- FraudRuleType,Link,Partner,PartnerGroup,@@ -441,17 +440,13 @@ async function stepCreateCommission(// 2. Conversion-event: run fraud detection before create; if rules trigger → hold (customer-scoped).// An explicit `status` input (e.g. imports) wins; clawbacks (earnings <= 0) are never held.if (!status && earnings > 0 && canManageFraudEvents) {- const partnerLevelFraudRuleTypes = FRAUD_RULES_BY_SCOPE["partner"].map(- (rule) => rule.type,- ) as FraudRuleType[];-const hasPendingRiskGroups = await prisma.fraudEventGroup.findFirst({where: {programId,partnerId,status: FraudEventStatus.pending,type: {- in: partnerLevelFraudRuleTypes,+ in: PARTNER_LEVEL_FRAUD_RULES,},},select: {diff --git a/apps/web/lib/api/fraud/constants.ts b/apps/web/lib/api/fraud/constants.tsindex 1c2265b527..603c417c90 100644--- a/apps/web/lib/api/fraud/constants.ts+++ b/apps/web/lib/api/fraud/constants.ts@@ -1,4 +1,5 @@import { FraudRuleInfo, FraudSeverity, PaidTrafficPlatform } from "@/lib/types";+import { FraudRuleType } from "@prisma/client";export const FRAUD_RULES: FraudRuleInfo[] = [// Conversion event rules@@ -100,14 +101,6 @@ export const FRAUD_RULES_BY_TYPE = Object.fromEntries(export const FRAUD_GROUP_EXPIRY_DAYS = 30;-export const FRAUD_RULES_BY_SCOPE = FRAUD_RULES.reduce(- (acc, rule) => {- (acc[rule.scope] ||= []).push(rule);- return acc;- },- {} as Record<FraudRuleInfo["scope"], FraudRuleInfo[]>,-);-export const CONFIGURABLE_FRAUD_RULES = FRAUD_RULES.filter((rule) => rule.configurable,);@@ -116,6 +109,18 @@ export const CONFIGURABLE_RULE_TYPES = CONFIGURABLE_FRAUD_RULES.map((rule) => rule.type,);+export const PARTNER_LEVEL_FRAUD_RULES = [+ FraudRuleType.partnerCrossProgramBan,+ FraudRuleType.partnerDuplicateAccount,+];++// export const CUSTOMER_LEVEL_FRAUD_RULES = [+// FraudRuleType.customerEmailMatch,+// FraudRuleType.customerEmailSuspiciousDomain,+// FraudRuleType.referralSourceBanned,+// FraudRuleType.paidTrafficDetected,+// ];+export const FRAUD_SEVERITY_CONFIG: Record<FraudSeverity,{diff --git a/apps/web/ui/activity-logs/commission-activity.tsx b/apps/web/ui/activity-logs/commission-activity.tsxindex 12d2b8d88a..865a6885e5 100644--- a/apps/web/ui/activity-logs/commission-activity.tsx+++ b/apps/web/ui/activity-logs/commission-activity.tsx@@ -106,7 +106,8 @@ export function CommissionActivity({children: (<><span className="text-sm text-neutral-700">- Commission imported as+ Commission{" "}+ {commission.status === "hold" ? "created" : "imported"} as</span><StatusBadgeicon={null}