Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Rename revenue-nulling helpers from null* to nullify*.

Kiran K8975d3f78eb6
diff --git a/apps/web/app/(ee)/api/embed/referrals/analytics/route.ts b/apps/web/app/(ee)/api/embed/referrals/analytics/route.ts
index cc37386511..607b9adf24 100644
--- a/apps/web/app/(ee)/api/embed/referrals/analytics/route.ts
+++ b/apps/web/app/(ee)/api/embed/referrals/analytics/route.ts
@@ -1,6 +1,6 @@
import { getAnalytics } from "@/lib/analytics/get-analytics";
import { withReferralsEmbedToken } from "@/lib/embed/referrals/auth";
-import { nullAnalyticsSaleAmounts } from "@/lib/partners/hide-partner-revenue";
+import { nullifyAnalyticsSaleAmounts } from "@/lib/partners/hide-partner-revenue";
import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import { partnerProfileAnalyticsQuerySchema } from "@/lib/zod/schemas/partner-profile";
import { parseFilterValue } from "@dub/utils";
@@ -33,7 +33,7 @@ export const GET = withReferralsEmbedToken(
return NextResponse.json(
isPartnerRevenueHidden(group)
- ? nullAnalyticsSaleAmounts(analytics)
+ ? nullifyAnalyticsSaleAmounts(analytics)
: analytics,
);
},
diff --git a/apps/web/app/(ee)/api/embed/referrals/events/route.ts b/apps/web/app/(ee)/api/embed/referrals/events/route.ts
index 66609a3485..9e4f99eebe 100644
--- a/apps/web/app/(ee)/api/embed/referrals/events/route.ts
+++ b/apps/web/app/(ee)/api/embed/referrals/events/route.ts
@@ -2,7 +2,7 @@ import { getEvents } from "@/lib/analytics/get-events";
import { obfuscateCustomerEmail } from "@/lib/api/partner-profile/obfuscate-customer-email";
import { withReferralsEmbedToken } from "@/lib/embed/referrals/auth";
import { generateRandomName } from "@/lib/names";
-import { nullPartnerEventRevenue } from "@/lib/partners/hide-partner-revenue";
+import { nullifyPartnerEventRevenue } from "@/lib/partners/hide-partner-revenue";
import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import {
partnerProfileEventsQuerySchema,
@@ -72,7 +72,7 @@ export const GET = withReferralsEmbedToken(
}),
};
- return hidePartnerRevenue ? nullPartnerEventRevenue(mapped) : mapped;
+ return hidePartnerRevenue ? nullifyPartnerEventRevenue(mapped) : mapped;
});
return NextResponse.json(response);
diff --git a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/export/route.ts b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/export/route.ts
index 286ea07c74..88cc1e64a9 100644
--- a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/export/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/export/route.ts
@@ -15,7 +15,7 @@ import {
LARGE_PROGRAM_MIN_TOTAL_COMMISSIONS_CENTS,
MAX_PARTNER_LINKS_FOR_LOCAL_FILTERING,
} from "@/lib/constants/partner-profile";
-import { nullAnalyticsSaleAmounts } from "@/lib/partners/hide-partner-revenue";
+import { nullifyAnalyticsSaleAmounts } from "@/lib/partners/hide-partner-revenue";
import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import { assertRateLimit } from "@/lib/upstash/assert-rate-limit";
import { RATELIMIT_POLICIES } from "@/lib/upstash/ratelimit-policies";
@@ -141,7 +141,7 @@ export const GET = withPartnerProfile(
const formatted = formatPartnerAnalyticsForExport(rows);
return isPartnerRevenueHidden(partnerGroup)
- ? nullAnalyticsSaleAmounts(formatted)
+ ? nullifyAnalyticsSaleAmounts(formatted)
: formatted;
},
getAnalyticsParams: () =>
diff --git a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/route.ts b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/route.ts
index 505cb5836a..77aed169b1 100644
--- a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/analytics/route.ts
@@ -8,7 +8,7 @@ import {
LARGE_PROGRAM_MIN_TOTAL_COMMISSIONS_CENTS,
MAX_PARTNER_LINKS_FOR_LOCAL_FILTERING,
} from "@/lib/constants/partner-profile";
-import { nullAnalyticsSaleAmounts } from "@/lib/partners/hide-partner-revenue";
+import { nullifyAnalyticsSaleAmounts } from "@/lib/partners/hide-partner-revenue";
import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import { partnerProfileAnalyticsQuerySchema } from "@/lib/zod/schemas/partner-profile";
import { parseFilterValue, toCentsNumber } from "@dub/utils";
@@ -118,7 +118,7 @@ export const GET = withPartnerProfile(
return NextResponse.json(
isPartnerRevenueHidden(partnerGroup)
- ? nullAnalyticsSaleAmounts(response)
+ ? nullifyAnalyticsSaleAmounts(response)
: response,
);
},
diff --git a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/[customerId]/route.ts b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/[customerId]/route.ts
index f15a60bd5c..6834068ace 100644
--- a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/[customerId]/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/customers/[customerId]/route.ts
@@ -10,7 +10,7 @@ import {
LARGE_PROGRAM_MIN_TOTAL_COMMISSIONS_CENTS,
} from "@/lib/constants/partner-profile";
import { generateRandomName } from "@/lib/names";
-import { nullPartnerEventRevenue } from "@/lib/partners/hide-partner-revenue";
+import { nullifyPartnerEventRevenue } from "@/lib/partners/hide-partner-revenue";
import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import { prisma } from "@/lib/prisma";
import { PartnerProfileCustomerSchema } from "@/lib/zod/schemas/partner-profile";
@@ -143,7 +143,7 @@ export const GET = withPartnerProfile(async ({ partner, params }) => {
activity: {
...customer,
events: hidePartnerRevenue
- ? events.map(nullPartnerEventRevenue)
+ ? events.map(nullifyPartnerEventRevenue)
: events,
link,
},
diff --git a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/route.ts b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/route.ts
index 1fdc5be6c2..7569134c05 100644
--- a/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/route.ts
+++ b/apps/web/app/(ee)/api/partner-profile/programs/[programId]/events/route.ts
@@ -10,7 +10,7 @@ import {
MAX_PARTNER_LINKS_FOR_LOCAL_FILTERING,
} from "@/lib/constants/partner-profile";
import { generateRandomName } from "@/lib/names";
-import { nullPartnerEventRevenue } from "@/lib/partners/hide-partner-revenue";
+import { nullifyPartnerEventRevenue } from "@/lib/partners/hide-partner-revenue";
import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import {
PartnerProfileLinkSchema,
@@ -167,7 +167,7 @@ export const GET = withPartnerProfile(
}),
};
- return hidePartnerRevenue ? nullPartnerEventRevenue(mapped) : mapped;
+ return hidePartnerRevenue ? nullifyPartnerEventRevenue(mapped) : mapped;
});
return NextResponse.json(response);
diff --git a/apps/web/lib/partners/hide-partner-revenue.ts b/apps/web/lib/partners/hide-partner-revenue.ts
index 30293ddc3c..ee87aaee6b 100644
--- a/apps/web/lib/partners/hide-partner-revenue.ts
+++ b/apps/web/lib/partners/hide-partner-revenue.ts
@@ -26,7 +26,7 @@ export function hidePartnerTotalSaleAmount<T extends object>(
* (`saleAmount`, nested `sale.amount`, and `link.saleAmount`).
* Caller should only invoke when revenue is hidden.
*/
-export function nullPartnerEventRevenue<T extends object>(event: T): T {
+export function nullifyPartnerEventRevenue<T extends object>(event: T): T {
const next = { ...event } as T & {
saleAmount?: unknown;
sale?: Record<string, unknown> | null;
@@ -49,7 +49,7 @@ export function nullPartnerEventRevenue<T extends object>(event: T): T {
}
/** Null `saleAmount` on analytics responses that include it. */
-export function nullAnalyticsSaleAmounts<T>(data: T): T {
+export function nullifyAnalyticsSaleAmounts<T>(data: T): T {
if (Array.isArray(data)) {
return data.map((row) =>
row && typeof row === "object" && "saleAmount" in row
@@ -70,7 +70,7 @@ export function nullAnalyticsSaleAmounts<T>(data: T): T {
* - sale.created: nested `sale.amount`
* - commission.created: top-level `amount`
*/
-export function nullPostbackRevenue(
+export function nullifyPostbackRevenue(
event: "sale.created" | "commission.created",
data: Record<string, unknown>,
): Record<string, unknown> {
diff --git a/apps/web/lib/postback/send-partner-postback.ts b/apps/web/lib/postback/send-partner-postback.ts
index 7fbdcedcef..cf6d16bb48 100644
--- a/apps/web/lib/postback/send-partner-postback.ts
+++ b/apps/web/lib/postback/send-partner-postback.ts
@@ -1,4 +1,4 @@
-import { nullPostbackRevenue } from "@/lib/partners/hide-partner-revenue";
+import { nullifyPostbackRevenue } from "@/lib/partners/hide-partner-revenue";
import { isPartnerRevenueHidden } from "@/lib/partners/is-partner-revenue-hidden";
import { POSTBACK_EVENT_ID_PREFIX } from "@/lib/postback/constants";
import { prisma } from "@/lib/prisma";
@@ -123,5 +123,5 @@ async function applyPostbackRevenueVisibility({
return data;
}
- return nullPostbackRevenue(event, data);
+ return nullifyPostbackRevenue(event, data);
}