Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

simplify limit description

Steven Tey8a57872db33a
diff --git a/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts b/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts
index 534fb85336..29b2dd8299 100644
--- a/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts
+++ b/apps/web/app/(ee)/api/workflows/create-partner-commission/route.ts
@@ -398,7 +398,7 @@ async function stepCreateCommission(
if (cappedEarnings === 0) {
return logAndReturn({
commission: null,
- outputLog: `Partner ${partnerId} has reached spend limit (${currencyFormatter(reward.spendLimitAmount)} ${reward.spendLimitInterval === "allTime" ? "in total" : `per ${reward.spendLimitInterval}`}) for ${event} event, skipping commission creation...`,
+ outputLog: `Partner ${partnerId} has reached spend limit (${currencyFormatter(reward.spendLimitAmount)} ${reward.spendLimitInterval === "allTime" ? "" : `per ${reward.spendLimitInterval}`}) for ${event} event, skipping commission creation...`,
});
}
diff --git a/apps/web/ui/partners/format-reward-description.ts b/apps/web/ui/partners/format-reward-description.ts
index 603f108786..bc043108e9 100644
--- a/apps/web/ui/partners/format-reward-description.ts
+++ b/apps/web/ui/partners/format-reward-description.ts
@@ -55,7 +55,7 @@ export function formatRewardDescription(
let description = parts.join(" ");
if (spendLimitParts && reward.spendLimitInterval) {
- description += `, with a ${spendLimitParts.amount} ${formatSpendLimitIntervalLabel(reward.spendLimitInterval)} limit ${reward.event === "sale" ? "per customer" : ""}`;
+ description += `, up to ${spendLimitParts.amount} ${formatSpendLimitIntervalLabel(reward.spendLimitInterval)} ${reward.event === "sale" ? "per customer" : ""}`;
}
return description;
@@ -162,6 +162,6 @@ function formatSpendLimitIntervalLabel(interval: RewardSpendLimitInterval) {
case "month":
return "monthly";
case "allTime":
- return "in total";
+ return "";
}
}
diff --git a/apps/web/ui/partners/program-reward-spend-limit.tsx b/apps/web/ui/partners/program-reward-spend-limit.tsx
index 0b913f0cf3..5b82f35897 100644
--- a/apps/web/ui/partners/program-reward-spend-limit.tsx
+++ b/apps/web/ui/partners/program-reward-spend-limit.tsx
@@ -15,9 +15,7 @@ export function getSpendLimitDescriptionParts({
trailingZeroDisplay: "stripIfInteger",
}),
interval:
- spendLimitInterval === "allTime"
- ? "in total"
- : `per ${spendLimitInterval}`,
+ spendLimitInterval === "allTime" ? "" : `per ${spendLimitInterval}`,
};
}
@@ -39,7 +37,7 @@ export function ProgramRewardSpendLimit({
return null;
}
- return ` up to ${parts.amount} ${parts.interval} ${event === "sale" ? "per customer" : ""}`;
+ return `, up to ${parts.amount} ${parts.interval} ${event === "sale" ? "per customer" : ""}`;
}
export function buildCommissionDescription({