Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

Keep admin network status updates from overwriting a ban

Rafi8b41c39ff506
diff --git a/apps/web/app/(ee)/api/admin/partners/[partnerId]/network-status/route.ts b/apps/web/app/(ee)/api/admin/partners/[partnerId]/network-status/route.ts
index 8e7f737604..02fc0ae51a 100644
--- a/apps/web/app/(ee)/api/admin/partners/[partnerId]/network-status/route.ts
+++ b/apps/web/app/(ee)/api/admin/partners/[partnerId]/network-status/route.ts
@@ -78,20 +78,36 @@ export const PATCH = withAdmin(async ({ params, req }) => {
});
}
- const updatedPartner = await prisma.partner.update({
- where: {
- id: partnerId,
- },
- data: {
- networkStatus: updatedStatus,
- changeHistoryLog: partnerChangeHistoryLog,
- reviewedAt: updatedStatus === "draft" ? null : new Date(),
- },
- select: {
- id: true,
- networkStatus: true,
- },
- });
+ const updatedPartner = await prisma.partner
+ .update({
+ where: {
+ id: partnerId,
+ networkStatus: {
+ not: "banned",
+ },
+ },
+ data: {
+ networkStatus: updatedStatus,
+ changeHistoryLog: partnerChangeHistoryLog,
+ reviewedAt: updatedStatus === "draft" ? null : new Date(),
+ },
+ select: {
+ id: true,
+ networkStatus: true,
+ },
+ })
+ .catch((error) => {
+ // A ban saved after the read above must not be overwritten
+ if (error.code === "P2025") return null;
+ throw error;
+ });
+
+ if (!updatedPartner) {
+ return new Response(
+ "Partner is banned from the network. Unban them first.",
+ { status: 400 },
+ );
+ }
if (
existingPartner.email &&
diff --git a/apps/web/app/(ee)/api/admin/partners/trusted/route.ts b/apps/web/app/(ee)/api/admin/partners/trusted/route.ts
index 4000a0e992..90f39093f7 100644
--- a/apps/web/app/(ee)/api/admin/partners/trusted/route.ts
+++ b/apps/web/app/(ee)/api/admin/partners/trusted/route.ts
@@ -103,23 +103,39 @@ export const POST = withAdmin(
changedAt: trustedAt,
});
- const updatedPartner = await prisma.partner.update({
- where: {
- id: partner.id,
- },
- data: {
- networkStatus: "trusted",
- trustedAt,
- changeHistoryLog: partnerChangeHistoryLog,
- },
- select: {
- id: true,
- name: true,
- email: true,
- image: true,
- trustedAt: true,
- },
- });
+ const updatedPartner = await prisma.partner
+ .update({
+ where: {
+ id: partner.id,
+ networkStatus: {
+ not: "banned",
+ },
+ },
+ data: {
+ networkStatus: "trusted",
+ trustedAt,
+ changeHistoryLog: partnerChangeHistoryLog,
+ },
+ select: {
+ id: true,
+ name: true,
+ email: true,
+ image: true,
+ trustedAt: true,
+ },
+ })
+ .catch((error) => {
+ // A ban saved after the read above must not be overwritten
+ if (error.code === "P2025") return null;
+ throw error;
+ });
+
+ if (!updatedPartner) {
+ return new Response(
+ "Partner is banned from the network. Unban them first.",
+ { status: 400 },
+ );
+ }
return NextResponse.json(updatedPartner);
},
@@ -169,14 +185,32 @@ export const DELETE = withAdmin(
changedAt: new Date(),
});
- await prisma.partner.update({
- where: { id: partner.id },
- data: {
- networkStatus: "approved",
- trustedAt: null,
- changeHistoryLog: partnerChangeHistoryLog,
- },
- });
+ const updatedPartner = await prisma.partner
+ .update({
+ where: {
+ id: partner.id,
+ networkStatus: {
+ not: "banned",
+ },
+ },
+ data: {
+ networkStatus: "approved",
+ trustedAt: null,
+ changeHistoryLog: partnerChangeHistoryLog,
+ },
+ })
+ .catch((error) => {
+ // A ban saved after the read above must not be overwritten
+ if (error.code === "P2025") return null;
+ throw error;
+ });
+
+ if (!updatedPartner) {
+ return new Response(
+ "Partner is banned from the network. Unban them first.",
+ { status: 400 },
+ );
+ }
return NextResponse.json({ success: true });
},