Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

address CR comments

Kiran K8d2f41ea9274
diff --git a/apps/web/app/(ee)/api/cron/webhooks/sync-click-workspaces/route.ts b/apps/web/app/(ee)/api/cron/webhooks/sync-click-workspaces/route.ts
index 32e6e0e807..22b582ac06 100644
--- a/apps/web/app/(ee)/api/cron/webhooks/sync-click-workspaces/route.ts
+++ b/apps/web/app/(ee)/api/cron/webhooks/sync-click-workspaces/route.ts
@@ -11,10 +11,9 @@ export const dynamic = "force-dynamic";
// Rebuild the Redis set of workspaces with active link.clicked webhooks.
// Runs every minute (* * * * *)
export const GET = withCron(async () => {
- const [synced, promoted] = await Promise.all([
- syncClickWebhookWorkspaceSet(),
- promoteLinkWebhooksForClick(),
- ]);
+ const promoted = await promoteLinkWebhooksForClick();
+
+ const synced = await syncClickWebhookWorkspaceSet();
return logAndRespond(
`Synced ${synced} workspace(s) with link.clicked webhooks. Promoted ${promoted} webhooks for click.`,
diff --git a/apps/web/lib/webhook/click-webhook-workspaces.ts b/apps/web/lib/webhook/click-webhook-workspaces.ts
index 4949649bc9..0c65b92ffc 100644
--- a/apps/web/lib/webhook/click-webhook-workspaces.ts
+++ b/apps/web/lib/webhook/click-webhook-workspaces.ts
@@ -137,7 +137,7 @@ export const promoteLinkWebhooksForClick = async () => {
},
data: {
triggers: [
- ...(webhook.triggers as WebhookTrigger[]),
+ ...((webhook.triggers as WebhookTrigger[]) ?? []),
LINK_CLICK_WEBHOOK_TRIGGER,
],
linkTarget: webhook.linkTarget ?? "links",
diff --git a/apps/web/ui/webhooks/webhook-trigger-selector.tsx b/apps/web/ui/webhooks/webhook-trigger-selector.tsx
index 2fc7754d52..5a0a6729c7 100644
--- a/apps/web/ui/webhooks/webhook-trigger-selector.tsx
+++ b/apps/web/ui/webhooks/webhook-trigger-selector.tsx
@@ -23,7 +23,7 @@ const CLICK_WEBHOOK_LINK_TARGET_OPTIONS = [
{
value: "folders",
label: "Include specific folders (Recommended)",
- description: "Trigger webhooks for all links from a selected folders",
+ description: "Trigger webhooks for all links from selected folders",
},
{
value: "links",