Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

account for isZeroDecimalCurrency

Steven Tey8de428a3e14e
diff --git a/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts b/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts
index 53062c8b37..58e189e997 100644
--- a/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts
+++ b/apps/web/app/(ee)/api/stripe/integration/webhook/checkout-session-completed.ts
@@ -580,7 +580,7 @@ export async function checkoutSessionCompleted({
eventName: saleData.event_name,
conversionDateTime: new Date().toISOString(),
eventId: saleData.event_id,
- conversionValue: saleData.amount / 100, // Data Manager expects major currency units
+ conversionValue: saleData.amount,
currencyCode: saleData.currency,
click: {
id: saleData.click_id,
diff --git a/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts b/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts
index 1984775b54..1985712c6e 100644
--- a/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts
+++ b/apps/web/app/(ee)/api/stripe/integration/webhook/invoice-paid.ts
@@ -414,7 +414,7 @@ export async function invoicePaid({
eventName: saleData.event_name,
conversionDateTime: new Date().toISOString(),
eventId: saleData.event_id,
- conversionValue: saleData.amount / 100, // Data Manager expects major currency units
+ conversionValue: saleData.amount,
currencyCode: saleData.currency,
click: {
id: saleData.click_id,
diff --git a/apps/web/lib/api/conversions/track-sale.ts b/apps/web/lib/api/conversions/track-sale.ts
index e769f61636..116f656337 100644
--- a/apps/web/lib/api/conversions/track-sale.ts
+++ b/apps/web/lib/api/conversions/track-sale.ts
@@ -648,7 +648,7 @@ const _trackSale = async ({
eventName: saleData.event_name,
conversionDateTime: new Date().toISOString(),
eventId: saleData.event_id,
- conversionValue: saleData.amount / 100, // Data Manager expects major currency units
+ conversionValue: saleData.amount,
currencyCode: saleData.currency,
click: {
id: saleData.click_id,
diff --git a/apps/web/lib/integrations/google-ads/upload-conversion.ts b/apps/web/lib/integrations/google-ads/upload-conversion.ts
index 84a6cac53f..e9cc5775ab 100644
--- a/apps/web/lib/integrations/google-ads/upload-conversion.ts
+++ b/apps/web/lib/integrations/google-ads/upload-conversion.ts
@@ -5,6 +5,7 @@ import {
APP_DOMAIN_WITH_NGROK,
getSearchParams,
GOOGLE_ADS_INTEGRATION_ID,
+ isZeroDecimalCurrency,
} from "@dub/utils";
import * as z from "zod/v4";
import { GoogleAdsApi, GoogleAdsClickId } from "./api";
@@ -55,6 +56,16 @@ export const queueGoogleAdsConversionUpload = async (
return;
}
+ // Data Manager expects major currency units, so we need to divide by 100
+ // if the currency is NOT a zero decimal currency (e.g. JPY doesn't have cents)
+ if (
+ payload.conversionValue &&
+ payload.currencyCode &&
+ !isZeroDecimalCurrency(payload.currencyCode)
+ ) {
+ payload.conversionValue = payload.conversionValue / 100;
+ }
+
try {
const response = await qstash.publishJSON({
url: `${APP_DOMAIN_WITH_NGROK}/api/google-ads/upload-conversion`,