Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

code improvements

Pedro Ladeira8e09dcf7940d
diff --git a/apps/web/lib/api/sales/calculate-sale-earnings.ts b/apps/web/lib/api/sales/calculate-sale-earnings.ts
index c9add44da3..79a0d227a5 100644
--- a/apps/web/lib/api/sales/calculate-sale-earnings.ts
+++ b/apps/web/lib/api/sales/calculate-sale-earnings.ts
@@ -21,7 +21,7 @@ export const calculateSaleEarnings = ({
if (reward.type === "flat") {
return sale.quantity * amount;
} else if (reward.type === "percentage") {
- return Math.round(sale.amount * (amount / 100));
+ return Math.round((sale.amount * amount) / 100);
}
return 0;
diff --git a/apps/web/tests/sales/calculate-sale-earnings.test.ts b/apps/web/tests/sales/calculate-sale-earnings.test.ts
index 1b6414f06e..1e6ee19e42 100644
--- a/apps/web/tests/sales/calculate-sale-earnings.test.ts
+++ b/apps/web/tests/sales/calculate-sale-earnings.test.ts
@@ -85,6 +85,12 @@ describe("calculateSaleEarnings", () => {
percent: 50,
expected: 1,
},
+ {
+ label: "500¢ at 2.9% (14.5¢; float 2.9/100 used to round to 14)",
+ saleAmount: 500,
+ percent: 2.9,
+ expected: 15,
+ },
])("$label → $expected", ({ saleAmount, percent, expected }) => {
expect(percentageEarnings(saleAmount, percent)).toBe(expected);
});