The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.
TypeScript clickhousemysqlnextjsopen-sourceplanetscaleprismatailwindcsstinybirdtypescriptupstashvercel
Refactor fraud risk assessment by replacing high-risk signal checks with application risk evaluations, introducing a new function to consolidate risk detection logic, and updating related API routes and UI components accordingly.
Kiran K8f9fc2dad2bd
diff --git a/apps/web/app/(ee)/api/cron/auto-approve-partner/route.ts b/apps/web/app/(ee)/api/cron/auto-approve-partner/route.tsindex bf5a10925d..f8cab4d977 100644--- a/apps/web/app/(ee)/api/cron/auto-approve-partner/route.ts+++ b/apps/web/app/(ee)/api/cron/auto-approve-partner/route.ts@@ -1,7 +1,8 @@import { handleAndReturnErrorResponse } from "@/lib/api/errors";-import { getPartnerHighRiskSignals } from "@/lib/api/fraud/get-partner-high-risk-signals";+import { getPartnerApplicationRisks } from "@/lib/api/fraud/get-partner-application-risks";import { verifyQstashSignature } from "@/lib/cron/verify-qstash";import { approvePartnerEnrollment } from "@/lib/partners/approve-partner-enrollment";+import { getPlanCapabilities } from "@/lib/plan-capabilities";import { prisma } from "@dub/prisma";import { log } from "@dub/utils";import { z } from "zod";@@ -50,12 +51,7 @@ export async function POST(req: Request) {partnerGroup: true,groupId: true,status: true,- partner: {- select: {- id: true,- payoutMethodHash: true,- },- },+ partner: true,},},},@@ -89,15 +85,23 @@ export async function POST(req: Request) {);}- const { hasHighRisk } = await getPartnerHighRiskSignals({- program,- partner: programEnrollment.partner,- });+ // Check if the workspace plan has fraud event management capabilities+ // If enabled, we'll evaluate risk signals before auto-approving+ const { canManageFraudEvents } = getPlanCapabilities(+ program.workspace.plan,+ );- if (hasHighRisk) {- return logAndRespond(- `Partner ${partnerId} has high risk. Skipping auto-approval.`,- );+ if (canManageFraudEvents) {+ const { riskSeverity } = await getPartnerApplicationRisks({+ program,+ partner: programEnrollment.partner,+ });++ if (riskSeverity === "high") {+ return logAndRespond(+ `Partner ${partnerId} has high risk. Skipping auto-approval.`,+ );+ }}await approvePartnerEnrollment({diff --git a/apps/web/app/(ee)/api/partners/[partnerId]/application-risks/route.ts b/apps/web/app/(ee)/api/partners/[partnerId]/application-risks/route.tsindex 74d382ea23..9a60871959 100644--- a/apps/web/app/(ee)/api/partners/[partnerId]/application-risks/route.ts+++ b/apps/web/app/(ee)/api/partners/[partnerId]/application-risks/route.ts@@ -1,58 +1,34 @@-import { FRAUD_RULES } from "@/lib/api/fraud/constants";-import { getPartnerHighRiskSignals } from "@/lib/api/fraud/get-partner-high-risk-signals";-import { checkPartnerEmailDomainMismatch } from "@/lib/api/fraud/rules/check-partner-email-domain-mismatch";-import { checkPartnerEmailMasked } from "@/lib/api/fraud/rules/check-partner-email-masked";-import { checkPartnerNoSocialLinks } from "@/lib/api/fraud/rules/check-partner-no-social-links";-import { checkPartnerNoVerifiedSocialLinks } from "@/lib/api/fraud/rules/check-partner-no-verified-social-links";+import { getPartnerApplicationRisks } from "@/lib/api/fraud/get-partner-application-risks";import { getDefaultProgramIdOrThrow } from "@/lib/api/programs/get-default-program-id-or-throw";import { getProgramEnrollmentOrThrow } from "@/lib/api/programs/get-program-enrollment-or-throw";import { withWorkspace } from "@/lib/auth";-import { getHighestSeverity } from "@/lib/get-highest-severity";-import { getPlanCapabilities } from "@/lib/plan-capabilities";-import { ExtendedFraudRuleType } from "@/lib/types";import { NextResponse } from "next/server";// GET /api/partners/:partnerId/application-risks - get application risks for a partner-export const GET = withWorkspace(async ({ workspace, params }) => {- const { partnerId } = params;- const programId = getDefaultProgramIdOrThrow(workspace);-- const { partner } = await getProgramEnrollmentOrThrow({- partnerId,- programId,- include: {- partner: true,- },- });+export const GET = withWorkspace(+ async ({ workspace, params }) => {+ const { partnerId } = params;+ const programId = getDefaultProgramIdOrThrow(workspace);++ const { partner } = await getProgramEnrollmentOrThrow({+ partnerId,+ programId,+ include: {+ partner: true,+ },+ });- const { hasCrossProgramBan, hasDuplicatePayoutMethod } =- await getPartnerHighRiskSignals({+ const { risksDetected, riskSeverity } = await getPartnerApplicationRisks({program: { id: programId },partner,});- const risksDetected: Partial<Record<ExtendedFraudRuleType, boolean>> = {- partnerCrossProgramBan: hasCrossProgramBan,- partnerDuplicatePayoutMethod: hasDuplicatePayoutMethod,- partnerEmailDomainMismatch: checkPartnerEmailDomainMismatch(partner),- partnerEmailMasked: checkPartnerEmailMasked(partner),- partnerNoSocialLinks: checkPartnerNoSocialLinks(partner),- partnerNoVerifiedSocialLinks: checkPartnerNoVerifiedSocialLinks(partner),- };-- const detectedRisksInfo = FRAUD_RULES.filter((rule) => {- return risksDetected[rule.type] === true;- });-- const { canManageFraudEvents } = getPlanCapabilities(workspace.plan);-- // Calculate the highest severity level from all detected risks- const riskSeverity = getHighestSeverity(detectedRisksInfo);-- // Return the response with risksDetected only if the workspace has fraud management capabilities,- // otherwise return an empty object to hide sensitive fraud detection details- return NextResponse.json({- risksDetected: canManageFraudEvents ? risksDetected : {},- riskSeverity,- });-});+ return NextResponse.json({+ risksDetected,+ riskSeverity,+ });+ },+ {+ requiredPlan: ["advanced", "enterprise"],+ },+);diff --git a/apps/web/lib/api/fraud/get-partner-application-risks.ts b/apps/web/lib/api/fraud/get-partner-application-risks.tsnew file mode 100644index 0000000000..f81c463226--- /dev/null+++ b/apps/web/lib/api/fraud/get-partner-application-risks.ts@@ -0,0 +1,68 @@+import { getHighestSeverity } from "@/lib/get-highest-severity";+import { ExtendedFraudRuleType } from "@/lib/types";+import { prisma } from "@dub/prisma";+import { Partner, Program } from "@dub/prisma/client";+import { FRAUD_RULES } from "./constants";+import { checkPartnerEmailDomainMismatch } from "./rules/check-partner-email-domain-mismatch";+import { checkPartnerEmailMasked } from "./rules/check-partner-email-masked";+import { checkPartnerNoSocialLinks } from "./rules/check-partner-no-social-links";+import { checkPartnerNoVerifiedSocialLinks } from "./rules/check-partner-no-verified-social-links";++export async function getPartnerApplicationRisks({+ program,+ partner,+}: {+ program: Pick<Program, "id">;+ partner: Pick<+ Partner,+ | "id"+ | "email"+ | "website"+ | "websiteVerifiedAt"+ | "youtubeVerifiedAt"+ | "twitterVerifiedAt"+ | "linkedinVerifiedAt"+ | "instagramVerifiedAt"+ | "tiktokVerifiedAt"+ | "country"+ >;+}) {+ const fraudGroups = await prisma.fraudEventGroup.findMany({+ where: {+ programId: program.id,+ partnerId: partner.id,+ status: "pending",+ type: {+ in: ["partnerCrossProgramBan", "partnerDuplicatePayoutMethod"],+ },+ },+ });++ const hasCrossProgramBan = fraudGroups.some(+ (group) => group.type === "partnerCrossProgramBan",+ );++ const hasDuplicatePayoutMethod = fraudGroups.some(+ (group) => group.type === "partnerDuplicatePayoutMethod",+ );++ const risksDetected: Partial<Record<ExtendedFraudRuleType, boolean>> = {+ partnerCrossProgramBan: hasCrossProgramBan,+ partnerDuplicatePayoutMethod: hasDuplicatePayoutMethod,+ partnerEmailDomainMismatch: checkPartnerEmailDomainMismatch(partner),+ partnerEmailMasked: checkPartnerEmailMasked(partner),+ partnerNoSocialLinks: checkPartnerNoSocialLinks(partner),+ partnerNoVerifiedSocialLinks: checkPartnerNoVerifiedSocialLinks(partner),+ };++ const triggeredRules = FRAUD_RULES.filter(+ (rule) => risksDetected[rule.type] === true,+ );++ const riskSeverity = getHighestSeverity(triggeredRules);++ return {+ risksDetected,+ riskSeverity,+ };+}diff --git a/apps/web/lib/api/fraud/get-partner-high-risk-signals.ts b/apps/web/lib/api/fraud/get-partner-high-risk-signals.tsdeleted file mode 100644index 4434510d1c..0000000000--- a/apps/web/lib/api/fraud/get-partner-high-risk-signals.ts+++ /dev/null@@ -1,38 +0,0 @@-import { prisma } from "@dub/prisma";-import { Partner, Program } from "@dub/prisma/client";--// Checks for high-risk signals for a partner including cross-program bans-// and duplicate payout methods.-export async function getPartnerHighRiskSignals({- program,- partner,-}: {- program: Pick<Program, "id">;- partner: Pick<Partner, "id" | "payoutMethodHash">;-}) {- const [crossProgramBanCount, duplicatePayoutCount] = await Promise.all([- // Cross-program bans- prisma.programEnrollment.count({- where: {- partnerId: partner.id,- programId: { not: program.id },- status: "banned",- },- }),-- // Duplicate payout method- partner.payoutMethodHash- ? prisma.partner.count({- where: {- payoutMethodHash: partner.payoutMethodHash,- },- })- : Promise.resolve(0),- ]);-- return {- hasCrossProgramBan: crossProgramBanCount > 0,- hasDuplicatePayoutMethod: duplicatePayoutCount > 1,- hasHighRisk: crossProgramBanCount > 0 || duplicatePayoutCount > 1,- };-}diff --git a/apps/web/ui/partners/fraud-risks/partner-application-risk-summary.tsx b/apps/web/ui/partners/fraud-risks/partner-application-risk-summary.tsxindex 9ab2b7312d..d74c8b254e 100644--- a/apps/web/ui/partners/fraud-risks/partner-application-risk-summary.tsx+++ b/apps/web/ui/partners/fraud-risks/partner-application-risk-summary.tsx@@ -37,7 +37,7 @@ export function PartnerApplicationRiskSummary({const { canManageFraudEvents } = getPlanCapabilities(plan);if (!canManageFraudEvents && !isLoading) {- return <PartnerApplicationRiskSummaryUpsell severity={severity} />;+ return <PartnerApplicationRiskSummaryUpsell />;}if (isLoading || triggeredFraudRules.length === 0) {@@ -107,20 +107,10 @@ const APPLICATION_RISK_CONFIG = {},};-export function PartnerApplicationRiskSummaryUpsell({- severity,-}: {- severity: FraudSeverity | null | undefined;-}) {+export function PartnerApplicationRiskSummaryUpsell() {const { partnersUpgradeModal, setShowPartnersUpgradeModal } =usePartnersUpgradeModal();- const severityConfig = severity ? APPLICATION_RISK_CONFIG[severity] : null;-- if (!severityConfig) {- return null;- }-// Dummy risk items for blur effectconst dummyRisks: Array<{ severity: FraudSeverity; text: string }> = [{ severity: "high", text: "High risk reason to unlock" },@@ -128,6 +118,9 @@ export function PartnerApplicationRiskSummaryUpsell({{ severity: "low", text: "Low risk reason to unlock" },];+ const severity: FraudSeverity = "high";+ const severityConfig = APPLICATION_RISK_CONFIG[severity];+return (<>{partnersUpgradeModal}@@ -177,7 +170,8 @@ export function PartnerApplicationRiskSummaryUpsell({</div><p className="text-content-default max-w-72 text-center text-xs font-medium">- Application risk review and event detection are Advanced plan{" "}+ Application risk review and event detection are available on the+ Advanced plan{" "}<Linkhref="https://dub.co/help"target="_blank"