Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

fix UI issues

Steven Tey90a63478c65b
diff --git a/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/network-partner-application-sheet.tsx b/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/network-partner-application-sheet.tsx
index 93a125809f..121412e9e2 100644
--- a/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/network-partner-application-sheet.tsx
+++ b/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/network-partner-application-sheet.tsx
@@ -273,8 +273,8 @@ export function NetworkPartnerApplicationSheet({
</div>
</div>
- <div className="@3xl/sheet:grid-cols-[minmax(440px,1fr)_minmax(0,360px)] scrollbar-hide grid min-h-0 grow grid-cols-1 gap-x-6 gap-y-4 overflow-y-auto p-4 sm:p-6">
- <div className="@3xl/sheet:order-2 @3xl/sheet:sticky @3xl/sheet:top-0 @3xl/sheet:self-start space-y-4">
+ <div className="@3xl/sheet:grid-cols-[minmax(440px,1fr)_minmax(0,360px)] @3xl/sheet:grid-rows-[minmax(0,1fr)] @3xl/sheet:overflow-hidden scrollbar-hide grid min-h-0 grow grid-cols-1 gap-x-6 gap-y-4 overflow-y-auto p-4 sm:p-6">
+ <div className="@3xl/sheet:order-2 @3xl/sheet:min-h-0 @3xl/sheet:overflow-y-auto scrollbar-hide space-y-4">
<PartnerInfoCards
type="admin"
partner={partner}
@@ -303,16 +303,16 @@ export function NetworkPartnerApplicationSheet({
/>
</div>
</div>
- <div className="@3xl/sheet:max-h-[50dvh] @3xl/sheet:overflow-y-auto @3xl/sheet:pr-1 overflow-x-hidden">
+ <div className="overflow-x-hidden">
<NetworkPartnerChangeHistory
changeHistoryLog={partner.changeHistoryLog}
/>
</div>
- <div className="@3xl/sheet:max-h-[50dvh] @3xl/sheet:overflow-y-auto @3xl/sheet:pr-1 overflow-x-hidden">
+ <div className="overflow-x-hidden">
<NetworkRequestIdentityVerification partner={partner} />
</div>
</div>
- <div className="@3xl/sheet:order-1">
+ <div className="@3xl/sheet:order-1 @3xl/sheet:min-h-0 @3xl/sheet:overflow-y-auto scrollbar-hide">
<div className="border-border-subtle overflow-hidden rounded-xl border bg-neutral-100">
<NetworkPartnerSheetTabs
currentTabId={currentTabId}
@@ -327,13 +327,13 @@ export function NetworkPartnerApplicationSheet({
</div>
)}
{currentTabId === "programs" && (
- <ScrollContainer className="@3xl/sheet:max-h-[72dvh]">
+ <ScrollContainer>
<NetworkPartnerProgramPerformance partner={partner} />
</ScrollContainer>
)}
{currentTabId === "duplicates" &&
partner.duplicatePartnerAccounts.length > 0 && (
- <ScrollContainer className="@3xl/sheet:max-h-[72dvh]">
+ <ScrollContainer>
<NetworkPartnerDuplicateAccounts
duplicatePartnerAccounts={
partner.duplicatePartnerAccounts
diff --git a/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/request-identity-verification.tsx b/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/request-identity-verification.tsx
index 7975d7d50f..bb8e60e547 100644
--- a/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/request-identity-verification.tsx
+++ b/apps/web/app/(ee)/admin.dub.co/(dashboard)/partners/network/request-identity-verification.tsx
@@ -4,7 +4,7 @@ import { AdminNetworkPartner } from "@/lib/types";
import { useConfirmModal } from "@/ui/modals/confirm-modal";
import { Button, CopyButton } from "@dub/ui";
import { ShieldCheck } from "@dub/ui/icons";
-import { useEffect, useState } from "react";
+import { useEffect, useRef, useState } from "react";
import { toast } from "sonner";
export function NetworkRequestIdentityVerification({
@@ -14,17 +14,21 @@ export function NetworkRequestIdentityVerification({
}) {
const [sessionUrl, setSessionUrl] = useState<string | null>(null);
const [isLoading, setIsLoading] = useState(false);
+ const partnerIdRef = useRef(partner.id);
useEffect(() => {
+ partnerIdRef.current = partner.id;
setSessionUrl(null);
+ setIsLoading(false);
}, [partner.id]);
const handleGenerateSession = async () => {
+ const requestPartnerId = partner.id;
setIsLoading(true);
try {
const response = await fetch(
- `/api/admin/partners/${partner.id}/identity-verification`,
+ `/api/admin/partners/${requestPartnerId}/identity-verification`,
{
method: "POST",
},
@@ -40,16 +44,26 @@ export function NetworkRequestIdentityVerification({
sessionUrl: string;
};
+ if (partnerIdRef.current !== requestPartnerId) {
+ return;
+ }
+
setSessionUrl(url);
toast.success("Veriff session generated.");
} catch (error) {
+ if (partnerIdRef.current !== requestPartnerId) {
+ return;
+ }
+
toast.error(
error instanceof Error
? error.message
: "Failed to generate Veriff session.",
);
} finally {
- setIsLoading(false);
+ if (partnerIdRef.current === requestPartnerId) {
+ setIsLoading(false);
+ }
}
};
@@ -76,36 +90,31 @@ export function NetworkRequestIdentityVerification({
This will trigger a new verification process for the partner.
</p>
- <Button
- variant="secondary"
- text="Generate Veriff Session"
- className="mt-2"
- loading={isLoading}
- onClick={() => setShowConfirmModal(true)}
- />
-
- {sessionUrl && (
- <div className="mt-3 space-y-1">
- <p className="text-xs font-medium text-neutral-700">
- Verification URL
- </p>
- <div className="flex items-center gap-2 rounded-lg border border-neutral-200 bg-white px-3 py-2">
- <a
- href={sessionUrl}
- target="_blank"
- rel="noopener noreferrer"
- className="min-w-0 flex-1 truncate text-xs text-blue-600 underline-offset-2 hover:underline"
- >
- {sessionUrl}
- </a>
- <CopyButton
- value={sessionUrl}
- variant="neutral"
- className="shrink-0 p-1 [&>*]:h-3 [&>*]:w-3"
- successMessage="Copied verification URL to clipboard!"
- />
- </div>
+ {sessionUrl ? (
+ <div className="mt-2 flex items-center gap-2 rounded-lg border border-neutral-200 bg-white px-3 py-2">
+ <a
+ href={sessionUrl}
+ target="_blank"
+ rel="noopener noreferrer"
+ className="min-w-0 flex-1 truncate text-xs text-blue-600 underline-offset-2 hover:underline"
+ >
+ {sessionUrl}
+ </a>
+ <CopyButton
+ value={sessionUrl}
+ variant="neutral"
+ className="shrink-0 p-1 [&>*]:h-3 [&>*]:w-3"
+ successMessage="Copied verification URL to clipboard!"
+ />
</div>
+ ) : (
+ <Button
+ variant="secondary"
+ text="Generate Veriff Session"
+ className="mt-2"
+ loading={isLoading}
+ onClick={() => setShowConfirmModal(true)}
+ />
)}
</section>
</>