Skip to content

armgit / dub

Public Imported from GitHub
0

The modern link attribution platform. Loved by world-class engineering teams at Twilio, Zillow, Jobber, Vercel, Raycast, and more.

address CR feedback

Steven Tey924f2ae2df41
diff --git a/apps/web/lib/actions/partners/bulk-approve-program-applications.ts b/apps/web/lib/actions/partners/bulk-approve-program-applications.ts
index 6df8ca21b9..6407f57c7d 100644
--- a/apps/web/lib/actions/partners/bulk-approve-program-applications.ts
+++ b/apps/web/lib/actions/partners/bulk-approve-program-applications.ts
@@ -124,6 +124,10 @@ export const bulkApproveProgramApplicationsAction = authActionClient
}
});
+ const previousEnrollmentStatuses = new Map(
+ programEnrollments.map(({ id, status }) => [id, status]),
+ );
+
waitUntil(
(async () => {
// Refetch the updated program enrollments with the partner
@@ -141,7 +145,7 @@ export const bulkApproveProgramApplicationsAction = authActionClient
await Promise.allSettled([
trackActivityLog(
- updatedEnrollments.map(({ partnerId }) => ({
+ updatedEnrollments.map(({ id, partnerId }) => ({
workspaceId: workspace.id,
programId: program.id,
resourceType: "partner",
@@ -150,7 +154,7 @@ export const bulkApproveProgramApplicationsAction = authActionClient
action: "partner_application.approved",
changeSet: {
status: {
- old: "pending",
+ old: previousEnrollmentStatuses.get(id)!,
new: "approved",
},
},
diff --git a/apps/web/lib/program-applications/approve-program-application.ts b/apps/web/lib/program-applications/approve-program-application.ts
index e6044a4109..4529d37a9b 100644
--- a/apps/web/lib/program-applications/approve-program-application.ts
+++ b/apps/web/lib/program-applications/approve-program-application.ts
@@ -151,7 +151,7 @@ export async function approveProgramApplication({
action: "partner_application.approved",
changeSet: {
status: {
- old: ProgramEnrollmentStatus.pending,
+ old: programEnrollment.status,
new: ProgramEnrollmentStatus.approved,
},
},